Skip to content

Fix mobile profile navving to reposts tab for artists sometimes - #12478

Merged
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile
Jul 9, 2025
Merged

Fix mobile profile navving to reposts tab for artists sometimes#12478
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Dug into it, was tricky to repro but I eventually got it to repro when I set my query client stale time. Digging in I found that the profile user handle selector was showing undefined at first so there was one cycle where the user was undefined.
  • To fix I swapped it to use useUserByParams

How Has This Been Tested?

ios:prod

@changeset-bot

changeset-botBot commented Jul 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88df77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) July 8, 2025 20:27
@DejayJD
DejayJD disabled auto-merge July 9, 2025 16:46
@DejayJD
DejayJD merged commit 15bba9a into mainJul 9, 2025
@DejayJD
DejayJD deleted the jd/fix-reposts-tab-on-profile branch July 9, 2025 16:46
audius-infra pushed a commit that referenced this pull request Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix mobile profile navving to reposts tab for artists sometimes by DejayJD · Pull Request #12478 · AudiusProject/apps · GitHub
Skip to content

Fix mobile profile navving to reposts tab for artists sometimes - #12478

Merged
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile
Jul 9, 2025
Merged

Fix mobile profile navving to reposts tab for artists sometimes#12478
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Dug into it, was tricky to repro but I eventually got it to repro when I set my query client stale time. Digging in I found that the profile user handle selector was showing undefined at first so there was one cycle where the user was undefined.
  • To fix I swapped it to use useUserByParams

How Has This Been Tested?

ios:prod

@changeset-bot

changeset-botBot commented Jul 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88df77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) July 8, 2025 20:27
@DejayJD
DejayJD disabled auto-merge July 9, 2025 16:46
@DejayJD
DejayJD merged commit 15bba9a into mainJul 9, 2025
@DejayJD
DejayJD deleted the jd/fix-reposts-tab-on-profile branch July 9, 2025 16:46
audius-infra pushed a commit that referenced this pull request Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix mobile profile navving to reposts tab for artists sometimes by DejayJD · Pull Request #12478 · AudiusProject/apps · GitHub
Skip to content

Fix mobile profile navving to reposts tab for artists sometimes - #12478

Merged
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile
Jul 9, 2025
Merged

Fix mobile profile navving to reposts tab for artists sometimes#12478
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Dug into it, was tricky to repro but I eventually got it to repro when I set my query client stale time. Digging in I found that the profile user handle selector was showing undefined at first so there was one cycle where the user was undefined.
  • To fix I swapped it to use useUserByParams

How Has This Been Tested?

ios:prod

@changeset-bot

changeset-botBot commented Jul 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88df77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) July 8, 2025 20:27
@DejayJD
DejayJD disabled auto-merge July 9, 2025 16:46
@DejayJD
DejayJD merged commit 15bba9a into mainJul 9, 2025
@DejayJD
DejayJD deleted the jd/fix-reposts-tab-on-profile branch July 9, 2025 16:46
audius-infra pushed a commit that referenced this pull request Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix mobile profile navving to reposts tab for artists sometimes by DejayJD · Pull Request #12478 · AudiusProject/apps · GitHub
Skip to content

Fix mobile profile navving to reposts tab for artists sometimes - #12478

Merged
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile
Jul 9, 2025
Merged

Fix mobile profile navving to reposts tab for artists sometimes#12478
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Dug into it, was tricky to repro but I eventually got it to repro when I set my query client stale time. Digging in I found that the profile user handle selector was showing undefined at first so there was one cycle where the user was undefined.
  • To fix I swapped it to use useUserByParams

How Has This Been Tested?

ios:prod

@changeset-bot

changeset-botBot commented Jul 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88df77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) July 8, 2025 20:27
@DejayJD
DejayJD disabled auto-merge July 9, 2025 16:46
@DejayJD
DejayJD merged commit 15bba9a into mainJul 9, 2025
@DejayJD
DejayJD deleted the jd/fix-reposts-tab-on-profile branch July 9, 2025 16:46
audius-infra pushed a commit that referenced this pull request Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Fix mobile profile navving to reposts tab for artists sometimes by DejayJD · Pull Request #12478 · AudiusProject/apps · GitHub
Skip to content

Fix mobile profile navving to reposts tab for artists sometimes - #12478

Merged
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile
Jul 9, 2025
Merged

Fix mobile profile navving to reposts tab for artists sometimes#12478
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Dug into it, was tricky to repro but I eventually got it to repro when I set my query client stale time. Digging in I found that the profile user handle selector was showing undefined at first so there was one cycle where the user was undefined.
  • To fix I swapped it to use useUserByParams

How Has This Been Tested?

ios:prod

@changeset-bot

changeset-botBot commented Jul 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88df77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) July 8, 2025 20:27
@DejayJD
DejayJD disabled auto-merge July 9, 2025 16:46
@DejayJD
DejayJD merged commit 15bba9a into mainJul 9, 2025
@DejayJD
DejayJD deleted the jd/fix-reposts-tab-on-profile branch July 9, 2025 16:46
audius-infra pushed a commit that referenced this pull request Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix mobile profile navving to reposts tab for artists sometimes by DejayJD · Pull Request #12478 · AudiusProject/apps · GitHub
Skip to content

Fix mobile profile navving to reposts tab for artists sometimes - #12478

Merged
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile
Jul 9, 2025
Merged

Fix mobile profile navving to reposts tab for artists sometimes#12478
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Dug into it, was tricky to repro but I eventually got it to repro when I set my query client stale time. Digging in I found that the profile user handle selector was showing undefined at first so there was one cycle where the user was undefined.
  • To fix I swapped it to use useUserByParams

How Has This Been Tested?

ios:prod

@changeset-bot

changeset-botBot commented Jul 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88df77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) July 8, 2025 20:27
@DejayJD
DejayJD disabled auto-merge July 9, 2025 16:46
@DejayJD
DejayJD merged commit 15bba9a into mainJul 9, 2025
@DejayJD
DejayJD deleted the jd/fix-reposts-tab-on-profile branch July 9, 2025 16:46
audius-infra pushed a commit that referenced this pull request Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix mobile profile navving to reposts tab for artists sometimes by DejayJD · Pull Request #12478 · AudiusProject/apps · GitHub
Skip to content

Fix mobile profile navving to reposts tab for artists sometimes - #12478

Merged
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile
Jul 9, 2025
Merged

Fix mobile profile navving to reposts tab for artists sometimes#12478
DejayJD merged 3 commits into
mainfrom
jd/fix-reposts-tab-on-profile

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Dug into it, was tricky to repro but I eventually got it to repro when I set my query client stale time. Digging in I found that the profile user handle selector was showing undefined at first so there was one cycle where the user was undefined.
  • To fix I swapped it to use useUserByParams

How Has This Been Tested?

ios:prod

@changeset-bot

changeset-botBot commented Jul 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88df77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) July 8, 2025 20:27
@DejayJD
DejayJD disabled auto-merge July 9, 2025 16:46
@DejayJD
DejayJD merged commit 15bba9a into mainJul 9, 2025
@DejayJD
DejayJD deleted the jd/fix-reposts-tab-on-profile branch July 9, 2025 16:46
audius-infra pushed a commit that referenced this pull request Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers