Drop smart collections, old explore - #12516

Merged
dylanjeffers merged 3 commits into
mainfrom
drop-smart-collections
Jul 11, 2025
Merged

Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom
drop-smart-collections

Conversation

@dylanjeffers

@dylanjeffersdylanjeffers commented Jul 11, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Drops old explore
Drops smart collections

@changeset-bot

changeset-botBot commented Jul 11, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3ee3f30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers changed the title Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@dylanjeffersdylanjeffers changed the title Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers merged commit 82780e3 into mainJul 11, 2025
@dylanjeffers
dylanjeffers deleted the drop-smart-collections branch July 11, 2025 23:18
cursor[bot]
cursorBot reviewed Jul 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors

The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.

packages/sdk/src/sdk/api/users/types.ts#L66-L75

https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75

Fix in Cursor • Fix in Web

Bug: Function Signature Mismatch in CollectionHeader

The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.

packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239

https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

audius-infra pushed a commit that referenced this pull request Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks
+1 more reviewer
@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Drop smart collections, old explore - #12516
Merged
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Jul 11, 2025
Merged
Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Drops old explore

Drops smart collections
@changeset-bot
changeset-botBot
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 3ee3f30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dylanjeffersdylanjeffers
changed the title
Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
@dylanjeffersdylanjeffers
changed the title
Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers
merged commit 82780e3
into
mainJul 11, 2025
@dylanjeffers
dylanjeffers
deleted the

drop-smart-collections

branch
July 11, 2025 23:18
cursor[bot]
cursorBot
reviewed
Jul 11, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors
The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.
packages/sdk/src/sdk/api/users/types.ts#L66-L75
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75
Fix in Cursor • Fix in Web
Bug: Function Signature Mismatch in CollectionHeader
The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.
packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/XXL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Drop smart collections, old explore - #12516
Merged
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Jul 11, 2025
Merged
Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Drops old explore

Drops smart collections
@changeset-bot
changeset-botBot
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 3ee3f30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dylanjeffersdylanjeffers
changed the title
Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
@dylanjeffersdylanjeffers
changed the title
Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers
merged commit 82780e3
into
mainJul 11, 2025
@dylanjeffers
dylanjeffers
deleted the

drop-smart-collections

branch
July 11, 2025 23:18
cursor[bot]
cursorBot
reviewed
Jul 11, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors
The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.
packages/sdk/src/sdk/api/users/types.ts#L66-L75
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75
Fix in Cursor • Fix in Web
Bug: Function Signature Mismatch in CollectionHeader
The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.
packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/XXL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Drop smart collections, old explore - #12516
Merged
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Jul 11, 2025
Merged
Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Drops old explore

Drops smart collections
@changeset-bot
changeset-botBot
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 3ee3f30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dylanjeffersdylanjeffers
changed the title
Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
@dylanjeffersdylanjeffers
changed the title
Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers
merged commit 82780e3
into
mainJul 11, 2025
@dylanjeffers
dylanjeffers
deleted the

drop-smart-collections

branch
July 11, 2025 23:18
cursor[bot]
cursorBot
reviewed
Jul 11, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors
The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.
packages/sdk/src/sdk/api/users/types.ts#L66-L75
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75
Fix in Cursor • Fix in Web
Bug: Function Signature Mismatch in CollectionHeader
The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.
packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/XXL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Drop smart collections, old explore - #12516
Merged
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Jul 11, 2025
Merged
Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Drops old explore

Drops smart collections
@changeset-bot
changeset-botBot
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 3ee3f30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dylanjeffersdylanjeffers
changed the title
Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
@dylanjeffersdylanjeffers
changed the title
Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers
merged commit 82780e3
into
mainJul 11, 2025
@dylanjeffers
dylanjeffers
deleted the

drop-smart-collections

branch
July 11, 2025 23:18
cursor[bot]
cursorBot
reviewed
Jul 11, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors
The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.
packages/sdk/src/sdk/api/users/types.ts#L66-L75
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75
Fix in Cursor • Fix in Web
Bug: Function Signature Mismatch in CollectionHeader
The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.
packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/XXL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Drop smart collections, old explore - #12516
Merged
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Jul 11, 2025
Merged
Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Drops old explore

Drops smart collections
@changeset-bot
changeset-botBot
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 3ee3f30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dylanjeffersdylanjeffers
changed the title
Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
@dylanjeffersdylanjeffers
changed the title
Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers
merged commit 82780e3
into
mainJul 11, 2025
@dylanjeffers
dylanjeffers
deleted the

drop-smart-collections

branch
July 11, 2025 23:18
cursor[bot]
cursorBot
reviewed
Jul 11, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors
The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.
packages/sdk/src/sdk/api/users/types.ts#L66-L75
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75
Fix in Cursor • Fix in Web
Bug: Function Signature Mismatch in CollectionHeader
The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.
packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/XXL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Drop smart collections, old explore - #12516
Merged
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Jul 11, 2025
Merged
Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Drops old explore

Drops smart collections
@changeset-bot
changeset-botBot
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 3ee3f30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dylanjeffersdylanjeffers
changed the title
Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
@dylanjeffersdylanjeffers
changed the title
Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers
merged commit 82780e3
into
mainJul 11, 2025
@dylanjeffers
dylanjeffers
deleted the

drop-smart-collections

branch
July 11, 2025 23:18
cursor[bot]
cursorBot
reviewed
Jul 11, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors
The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.
packages/sdk/src/sdk/api/users/types.ts#L66-L75
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75
Fix in Cursor • Fix in Web
Bug: Function Signature Mismatch in CollectionHeader
The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.
packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/XXL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Drop smart collections, old explore - #12516
Merged
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Jul 11, 2025
Merged
Drop smart collections, old explore#12516
dylanjeffers merged 3 commits into
mainfrom 
drop-smart-collections
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Drops old explore

Drops smart collections
@changeset-bot
changeset-botBot
commented
Jul 11, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 3ee3f30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@dylanjeffersdylanjeffers
changed the title
Drop smart collectionsDrop smart collections, old explore, audio-nft-playlistsJul 11, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
@dylanjeffersdylanjeffers
changed the title
Drop smart collections, old explore, audio-nft-playlistsDrop smart collections, old exploreJul 11, 2025
@dylanjeffers
dylanjeffers
merged commit 82780e3
into
mainJul 11, 2025
@dylanjeffers
dylanjeffers
deleted the

drop-smart-collections

branch
July 11, 2025 23:18
cursor[bot]
cursorBot
reviewed
Jul 11, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Playlist Type Mismatch Causes Frontend Errors
The SDK's PlaylistLibraryIdentifierSchema in packages/sdk/src/sdk/api/users/types.ts incorrectly retains ExplorePlaylistIdentifierSchema. This creates a type mismatch with packages/common/src/models/PlaylistLibrary.ts, where ExplorePlaylistIdentifier (and AudioNftPlaylistIdentifier) have been removed, making PlaylistLibraryIdentifier a basic playlist type. Consequently, the SDK can return explore_playlist items that the frontend cannot handle, leading to runtime type errors, for example, in PlaylistLibraryNavItem.
packages/sdk/src/sdk/api/users/types.ts#L66-L75
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/sdk/src/sdk/api/users/types.ts#L66-L75
Fix in Cursor • Fix in Web
Bug: Function Signature Mismatch in CollectionHeader
The onPlay and onPreview props for CollectionHeader were updated to expect no parameters (() => void). However, CollectionPage incorrectly passes an empty object {} when invoking these functions, leading to a function signature mismatch.
packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
https://github.com/AudiusProject/audius-protocol/blob/3ee3f30b9e2b603aecdec43049f4932a21c07642/packages/web/src/pages/collection-page/components/mobile/CollectionPage.tsx#L237-L239
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.143
e5e6832
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed
[82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers
[73dd687] Fix follower count formatting (#12520) JD Francis
[5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ
[371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed
[afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers
[9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers
[9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed
[d479052] Migrate to UserBadgesV2 on web (#12507) Reed
[442ce6d] [PE-6477] BONK badges (#12506) Reed
[99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis
[464bdd0] Fix useHighlightComment hook (#12508) KJ
[2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott
[5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis
[a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau
[5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ
[3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis
[543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau
[0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo
[2d5426c] Fix guest account issues (#12496) JD Francis
[8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis
[b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed
[d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ
[eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers
[bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed
[fa34cca] Don't use call with queryClient in sagas (#12486) Reed
[15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis
[45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo
[1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed
[f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers
[0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis
[19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers
[0dfd7d0] Fix X icon color on mobile (#12479) Reed
[bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo
[f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis
[1d20005] Remove ToS banner update (#12473) Ray Jacobson
[c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis
[27aadc3] Add mobile web search explore (#12456) Isaac Solo
[8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers
[bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@isaacsoloisaacsoloisaacsolo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/XXL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@isaacsolo