Uh oh!
There was an error while loading. Please reload this page.
Fix wrong amounts for USDC purchase buyer notifs - #12494
Merged
Merged
Conversation
|
dharit-tan
commented
Jul 9, 2025
| {buyerUser?.handle ? <UserNameLink user={buyerUser} /> : 'someone'} | ||
| {` just bought your ${entityType} `} | ||
| <EntityLink entity={content} /> | ||
| {' for $'} |
ContributorAuthor
There was a problem hiding this comment.
@rickyrombo any idea why on web, USDC(x).toLocaleString includes a $ sign, but on mobile it does not?
Contributor
There was a problem hiding this comment.
The javascript engine in React Native is different, and does not implement all of BigInt.toLocaleString() unfortunately
Contributor
There was a problem hiding this comment.
https://stackoverflow.com/questions/41408025/react-native-tolocalestring-not-working-on-android there's probably some ways to polyfill the behavior we need, but it may be overkill for such a small feature
ContributorAuthor
There was a problem hiding this comment.
yes let's just add $ lol
DejayJD
reviewed
Jul 9, 2025
Comment on lines
+35
to
+43
| body: (content: TrackEntity | CollectionEntity, sellerUser: User) => ( | ||
| <> | ||
| {'You just purchased '} | ||
| <EntityLink entity={content} /> | ||
| {' from '} | ||
| <UserNameLink user={sellerUser} /> | ||
| {'!'} | ||
| </> | ||
| ) |
dharit-tan
enabled auto-merge (squash)
July 9, 2025 20:52
DejayJD
approved these changes
Jul 9, 2025
dharit-tan added a commit
that referenced
this pull request
Jul 9, 2025
Co-authored-by: Dylan Jeffers <dylan@audius.co>
audius-infra pushed a commit
that referenced
this pull request
Jul 12, 2025
[1cd89dc] [PE-6512] Hex USDC Logos (#12522) Reed [82780e3] Drop smart collections, old explore (#12516) Dylan Jeffers [73dd687] Fix follower count formatting (#12520) JD Francis [5c2a3f9] [PE-6503] Add highlighting for comment replies (#12519) KJ [371ab90] [PE-6506] Artist coin message blast UI (#12518) Reed [afd0b16] Drop coming soon offline mode features (#12514) Dylan Jeffers [9bd6f7d] Fix purchase complete x share button size (#12513) Dylan Jeffers [9d3a7df] Migrate to UserBadgesV2 on mobile (#12511) Reed [d479052] Migrate to UserBadgesV2 on web (#12507) Reed [442ce6d] [PE-6477] BONK badges (#12506) Reed [99a5a43] [QA-2205] Fix remix section scrolling to top (properly this time) (#12509) JD Francis [464bdd0] Fix useHighlightComment hook (#12508) KJ [2c8aa30] [API-261] Fire async share action when opening the share modal/drawer for content (#12492) Randy Schott [5908ced] [QA-2207] Fix double scrollbars (#12504) JD Francis [a1b4336] feat: Add BONK token support to backend and SDK (#12489) Farid Salau [5ab9772] [PE-6460] Add top of section display and highlighting on linked comments (#12501) KJ [3a223ce] [QA-2205] Fix remix section scroll to top bug (#12503) JD Francis [543ee7e] feat: Add core token registry infrastructure (#12488) Farid Salau [0b788ef] Fix scrolling in recent searches (#12500) Isaac Solo [2d5426c] Fix guest account issues (#12496) JD Francis [8e17858] [QA-2209] Fix track replace crashing app (#12497) JD Francis [b066b17] Fix wrong amounts for USDC purchase buyer notifs (#12494) Reed [d34e011] [PE-6458] Update SDK and getComment hook (#12487) KJ [eddb083] [QA-2185] Fix user link flow (#12476) Dylan Jeffers [bccc9b7] [PE-6492] Mobile hex tokens (#12491) Reed [fa34cca] Don't use call with queryClient in sagas (#12486) Reed [15bba9a] Fix mobile profile navving to reposts tab for artists sometimes (#12478) JD Francis [45b2bde] Fix search result scroll cutoff (#12484) Isaac Solo [1a08b32] [PE-6476] Web hexagonal token icons (#12480) Reed [f878d8f] Fix podcast playback rate on mobile (#12475) Dylan Jeffers [0f78928] [PE-6466] Fix /user network spam on app start (#12450) JD Francis [19208ad] [QA-2192] Fix social link spacing (#12474) Dylan Jeffers [0dfd7d0] Fix X icon color on mobile (#12479) Reed [bad4d5f] Search explore milestone 2: for you, recent premium, best selling (#12467) Isaac Solo [f780db4] [PE-6421] Improve ProfileScreen render time by ~50% (#12470) JD Francis [1d20005] Remove ToS banner update (#12473) Ray Jacobson [c5f8442] [HOTFIX] Small ui bugs - UserLink margin & trending playlist indices (#12472) JD Francis [27aadc3] Add mobile web search explore (#12456) Isaac Solo [8d2627f] [PE-6485] Add track tile integration tests (#12466) Dylan Jeffers [bdc3982] [PE-6489] Make buy/sell work on stage (#12471) Farid Salau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix incorrect amount formatting + refactor message objects in these notifs
How Has This Been Tested?