Skip to content

[DEPRECATED] Governance v1 - #331

Closed
SidSethi wants to merge 42 commits into
hn_eth_contracts_devfrom
ss-slash-by-governance
Closed

[DEPRECATED] Governance v1#331
SidSethi wants to merge 42 commits into
hn_eth_contracts_devfrom
ss-slash-by-governance

Conversation

@SidSethi

@SidSethiSidSethi commented Mar 20, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

[Note - deprecated in favor of https://github.com//pull/365]

  • API
  • unit test (happy path)

Detailed spec + checklist on Notion - Slashing by governance

@SidSethi
SidSethiforce-pushed the ss-slash-by-governance branch from ab7d200 to 371a1f9CompareMarch 24, 2020 01:44
SidSethi
SidSethi commented Mar 24, 2020
View reviewed changes
Comment threadeth-contracts/migrations/7_governance_migration.js Outdated
@SidSethiSidSethi changed the title [WIP - DO NOT REVIEW] Governance contract V0Governance v0Mar 24, 2020
hareeshnagaraj
hareeshnagaraj suggested changes Mar 25, 2020
View reviewed changes

@hareeshnagarajhareeshnagaraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks very good, minor question around slash

Comment threadeth-contracts/contracts/Governance.sol Outdated
Comment threadeth-contracts/contracts/Governance.sol Outdated
Comment threadeth-contracts/contracts/Governance.sol Outdated
Comment threadeth-contracts/contracts/Governance.sol Outdated
dmanjunath
dmanjunath approved these changes Mar 25, 2020
View reviewed changes

@dmanjunathdmanjunath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't the final version of the contract, but it's looking pretty solid

Comment threadeth-contracts/contracts/Governance.sol Outdated
Comment threadeth-contracts/contracts/Governance.sol Outdated
Comment threadeth-contracts/migrations/7_governance_migration.js Outdated
@SidSethi

SidSethi commented Mar 25, 2020

Copy link
Copy Markdown
ContributorAuthor

Slashing by Governance

@SidSethiSidSethi changed the title Governance v0[DO NOT MERGE] Governance v0Mar 26, 2020
@hareeshnagaraj
TESTING multiplier w/slash degradation
fa86794
@hareeshnagaraj
Fixed slash discrepancy, further testing now
f04861b
@hareeshnagaraj
test checkpoint
bf36a5a
@hareeshnagaraj
Checkpointing code ---- MOVING TO ROUNDS BASED CLAIM MODEL
3e58bad
@hareeshnagaraj
[eth-contracts] Rounds-based reward model (#348)
b5f7146
* Eliminates stake multiplier in favor of proportional on-demand minting
* Fully compatible with delegation working branch
@hareeshnagaraj
[eth-contracts] Lockup for undelegate operations (#359)
e6aa800
* Enforces a block difference for undelegate operations, locking funds
* Handles reward negation for locked up funds
* Slash operations reset undelegate requests
* Disabled delegate operations while claim is pending
@hareeshnagaraj
Merge branch 'hn_eth_contracts_dev' into hn_delegation_working_branch
bcd7833
@SidSethiSidSethi changed the title [DO NOT MERGE] Governance v0[DO NOT MERGE] Governance v1Apr 8, 2020
@SidSethiSidSethi mentioned this pull request Apr 8, 2020
Merged
@SidSethiSidSethi changed the title [DO NOT MERGE] Governance v1[DEPRECATED] Governance v1Apr 8, 2020
@SidSethi
SidSethiforce-pushed the ss-slash-by-governance branch from fb12e81 to f12d2fbCompareApril 8, 2020 21:34
@SidSethi

SidSethi commented Apr 10, 2020

Copy link
Copy Markdown
ContributorAuthor

deprecated in favor of #365

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roneilrroneilrAwaiting requested review from roneilr
2 more reviewers
@dmanjunathdmanjunathdmanjunath approved these changes
@hareeshnagarajhareeshnagarajhareeshnagaraj requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SidSethi@dmanjunath@hareeshnagaraj