Skip to content

Governance v1 (Registry integration, DelegationManager integration, Slash changed to burn) - #365

Merged
SidSethi merged 7 commits into
hn_delegation_working_branchfrom
ss-slash-by-governance
Apr 10, 2020
Merged

Governance v1 (Registry integration, DelegationManager integration, Slash changed to burn)#365
SidSethi merged 7 commits into
hn_delegation_working_branchfrom
ss-slash-by-governance

Conversation

@SidSethi

@SidSethiSidSethi commented Apr 8, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

[Note - Replaces previous PR - https://github.com//pull/331]

[Note - Pls ignore the first 3 commits, they have already been reviewed/approved.]

Detailed spec + checklist on Notion - Slashing by governance

@SidSethiSidSethi mentioned this pull request Apr 8, 2020
Closed
2 tasks
@SidSethi
SidSethiforce-pushed the ss-slash-by-governance branch from fb12e81 to f12d2fbCompareApril 8, 2020 21:34
@SidSethiSidSethi changed the title Governance + new delegation integration[DO NOT REVIEW] Governance + new delegation integrationApr 8, 2020
@SidSethiSidSethi changed the title [DO NOT REVIEW] Governance + new delegation integrationGovernance v1 (Registry integration, DelegationManager integration, Slash changed to burn)Apr 9, 2020
hareeshnagaraj
hareeshnagaraj suggested changes Apr 10, 2020
View reviewed changes

@hareeshnagarajhareeshnagaraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. other than migrations nothing else should block merge. minor nit around truffle-test.sh and some test validation can be addressed later

Comment threadeth-contracts/scripts/truffle-test.sh Outdated
Comment threadeth-contracts/migrations/7_governance_migration.js
Comment threadeth-contracts/test/governance.test.js Outdated
Comment threadeth-contracts/test/governance.test.js Outdated
@SidSethi
SidSethiforce-pushed the ss-slash-by-governance branch from ba4f378 to 0582ba2CompareApril 10, 2020 18:13
@SidSethi
SidSethi merged commit 00312e4 into hn_delegation_working_branchApr 10, 2020
@SidSethi
SidSethi deleted the ss-slash-by-governance branch April 10, 2020 18:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmanjunathdmanjunathAwaiting requested review from dmanjunath
1 more reviewer
@hareeshnagarajhareeshnagarajhareeshnagaraj requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SidSethi@hareeshnagaraj