Organize dirty work from codex/shared-task-ledger-final-72e621 - #1334
Organize dirty work from codex/shared-task-ledger-final-72e621#1334BigSimmo wants to merge 1 commit into
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:13577c2ee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | #055 | P2 | issue | Upload crash can strand a queued document without a job | **Outcome:** a crash between document and job creation cannot strand an upload indefinitely. **Next:** add the stranded-row reproducer, then choose the smallest idempotent atomic-enqueue RPC or bounded scheduled sweep consistent with current ownership and rollback contracts. **Success:** exactly one recoverable job is created; existing open jobs do not duplicate; owner scope, retry, audit, and rollback remain intact. **Verify:** focused upload/recovery/schema tests, migration guards, disposable replay, drift, `verify:cheap`, production-readiness. **Stop:** no at-least-once claim until the crash case passes; hosted changes require approval. | `src/app/api/upload/route.ts`; `docs/webhooks.md:168-192` | 2026-07-24 | | ||
| | #056 | P2 | task | Reconcile the preserved browser-readiness and contrast patch | **Outcome:** disabled Formulation navigation remains legible and Firefox/WebKit waits prove real React readiness without weakening assertions. **Next:** prove ownership of `agent/formulation-disabled-contrast`, compare its four-file diff with current `main`, retain only reproducing fixes, then run the affected specs in all browsers. **Success:** disabled contrast passes; a missing handler still fails; Chromium, Firefox, and WebKit pass. **Verify:** focused unit/Playwright, `verify:cheap`, identity-verified `ensure`, `verify:ui`. **Stop:** discard stale harness workarounds that no longer reproduce. | preserved worktree `release-browser-contrast-20260723`; session 2026-07-24 | 2026-07-24 | | ||
| | #057 | P2 | task | Prove one exact-SHA release candidate end to end | **Outcome:** local and hosted release evidence evaluates the same SHA and safely proves the production `RAG_QUERY_HASH_SECRET` boot requirement. **Next:** after candidate fixes land, obtain approvals, verify SHA/environment identity, confirm secret placement without revealing it, and run the bounded canonical release checks. **Success:** required gates are green and any waiver is explicit/owned. **Verify:** release runbook, golden retrieval, RAG-only quality, production-readiness, deployment/health identity, protected-main merge proof. **Stop:** no unidentified tree, duplicate paid canary, invented staging, or exposed secret. | `docs/operator-backlog.md`; `docs/launch-operator-runbook.md`; PIA-2 | 2026-07-24 | | ||
| | #058 | P2 | task | Compact document source text accordion is paused | **Outcome:** hand off the completed two-level closed accordion for every canonical `/documents/[id]` viewer without losing deep-link, search-highlight, print, mobile, or composer behavior. **Next:** only when the user explicitly returns to this task, prove the clean preserved branch `codex/chat-document-text-accordion-7cb4`, reconcile its two commits with current `main`, rerun focused document-viewer tests and the required local gates, then use the protected-main PR path. **Success:** Text, full page text, and passages start closed; navigation, citations, and search open the correct disclosure; nested rows are mutually exclusive; print restores state; 320/390/1280 px have no overflow or composer obstruction. **Verify:** focused mocked Playwright, `verify:cheap`, identity-verified `ensure`, `verify:ui`, static production-readiness. **Stop:** do not resume implementation, run its tests/server, or publish it without an explicit return to that paused task. | branch `codex/chat-document-text-accordion-7cb4`; commits `f09857da2`, `62521a86c`; delegation pause 2026-07-24 | 2026-07-24 | |
There was a problem hiding this comment.
When a future session resumes #58, the documented branch and both commits are unavailable: repository-wide ref/reflog/object checks find neither codex/chat-document-text-accordion-7cb4 nor f09857da2/62521a86c. Because merging this documentation does not preserve local-only Git objects, the promised completed handoff cannot be recovered without reimplementation; push or archive a reachable ref before recording the task as preserved.
AGENTS.md reference: AGENTS.md:L453-L455
Useful? React with 👍 / 👎.
| - On completion, move the source row to **Resolved / archive** and remove it from this queue. New | ||
| reproducible evidence may create a new narrower issue; historical claims do not automatically reopen. |
There was a problem hiding this comment.
When /issues done <id> follows .claude/skills/issues/SKILL.md, it only moves the open row to the archive, while /issues update only edits that row; neither command removes or updates this newly duplicated queue entry. Closing #52, for example, therefore leaves the supposedly current queue still directing users to a resolved P1 item, so the mutation workflow must maintain the queue or the queue should be derived from the canonical rows.
AGENTS.md reference: AGENTS.md:L460-L463
Useful? React with 👍 / 👎.
| | 1 | #052 | Align the Safety Plan Generator with the no-patient-data contract | P1 | Required now | Sol/xhigh + privacy/clinical review | Now; before real-patient use | 3–5 hours | | ||
| | 2 | #053 | Close or explicitly defer the APP 8/DPA/ZDR governance basis | P1 | Requires user/operator/provider decision | Sol/xhigh + counsel + account owner | Start now; complete before real-patient use | 2–4 hours preparation; external elapsed time varies | | ||
| | 3 | #054 | Fail closed when answer relevance metadata is absent | P2 | Required now | Sol/xhigh | Next local clinical-safety change | 2–4 hours | | ||
| | 4 | #030 | Require distinct documents for distinct comparison slots | P2 | Required now | Sol/high | Before trusting another admission/discharge verdict | 2–4 hours | |
There was a problem hiding this comment.
When /issues groups the Open items table by priority, #30 is reported as P3 even though this queue marks it P2 and required now; the reverse mismatch exists for #25, which is P2 in the source row but P3 in the queue. These conflicting classifications make the standard issue view and the recommended execution order disagree about what should be acted on, so update the source priorities or use a clearly distinct, consistently maintained classification.
AGENTS.md reference: AGENTS.md:L457-L459
Useful? React with 👍 / 👎.
📝 WalkthroughWalkthroughThe pull request updates the universal task ledger’s execution contract and queue, adds open items ChangesUniversal task ledger
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/codebase-index.md`:
- Line 339: Update the Universal task ledger entry in the Markdown table to use
a relative Markdown link to outstanding-issues.md instead of rendering the path
as inline code, preserving the existing label and table structure.
In `@docs/outstanding-issues.md`:
- Around line 62-63: Update the `#051/`#023 entry in the outstanding-issues queue
to reconcile the expired July 26, 2026 schedule gate: record the resulting
scheduled artifacts and disposition, or change the row’s status and timing so it
no longer presents that gate as future. Keep the dependent `#018/`#029 entry
consistent with the updated `#051/`#023 state.
- Around line 78-92: Update the Operator backlog/runbooks queue entry and its
surrounding execution contract so every retained queue row maps to an open
ledger item with a `#ID` and corresponding detail row. Either add the missing
ledger item and define its completion/archive path, or remove the orphaned entry
from the queue and contract; preserve traceability and archive behavior for all
remaining entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 853525a3-ca2c-4a14-9854-19e029f4642f
📒 Files selected for processing (2)
docs/codebase-index.mddocs/outstanding-issues.md
| | Search/RAG roadmap | `docs/search-rag-master-plan.md` | | ||
| | Reindex operations | `docs/reindex-runbook.md` | | ||
| | Production readiness | `docs/production-readiness-checklist.md` | | ||
| | Universal task ledger | `docs/outstanding-issues.md` | |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use an actual Markdown link for the ledger entry.
Backticks render docs/outstanding-issues.md as plain code, not a navigable link. Use a relative link from this file, such as [docs/outstanding-issues.md](outstanding-issues.md).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/codebase-index.md` at line 339, Update the Universal task ledger entry
in the Markdown table to use a relative Markdown link to outstanding-issues.md
instead of rendering the path as inline code, preserving the existing label and
table structure.
| | 9 | #051, #023 | Compare the scheduled structured canary with run `30018289898` | P2 | Defer until scheduled artifact; provider approval | Sol/xhigh + RAG reviewer | After 2026-07-26 18:00 UTC | 1–2 hours | | ||
| | 10 | #018, #029 | Reproduce and address each remaining RAG residual separately | P2 | Defer until #051/#023 | Sol/xhigh + clinical/RAG review | Only after the comparable canary review | 1–2 days per proven mechanism | |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Reconcile the expired #051/#23 schedule gate.
The queue still says to defer until July 26, 2026 at 18:00 UTC, but the current date is July 28, 2026. Record the scheduled artifacts and disposition, or update the queue state so this no longer appears as a future gate.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/outstanding-issues.md` around lines 62 - 63, Update the `#051/`#023 entry
in the outstanding-issues queue to reconcile the expired July 26, 2026 schedule
gate: record the resulting scheduled artifacts and disposition, or change the
row’s status and timing so it no longer presents that gate as future. Keep the
dependent `#018/`#029 entry consistent with the updated `#051/`#023 state.
| | 25 | Operator backlog/runbooks | Perform staging soak or DR reconstitution only for a real rehearsal | P3 | Defer until release/rehearsal trigger | Sol/high + operator | When a real candidate or scheduled rehearsal exists | 0.5–2 days | | ||
| ### Execution contract | ||
| - Every retained row's **Detail / next action** below defines its smallest scope. The linked source or | ||
| runbook supplies deeper implementation steps. | ||
| - Success means the stated outcome is observable, focused verification passes, and required human or | ||
| provider evidence is recorded without secrets. | ||
| - Local changes use focused tests first, then `verify:cheap` when warranted. UI changes additionally | ||
| use identity-verified `ensure` and the appropriate `verify:ui` slice. RAG, ingestion, privacy, | ||
| production-environment, and clinical-output changes also run production-readiness. | ||
| - Stop when a dependency, approval, reproducer, identity check, migration replay, or safety gate is | ||
| absent. Do not broaden scope, spend on live checks, or contact providers to force a task closed. | ||
| - On completion, move the source row to **Resolved / archive** and remove it from this queue. New | ||
| reproducible evidence may create a new narrower issue; historical claims do not automatically reopen. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Make every queue entry traceable to an open item.
Operator backlog/runbooks has no #ID or corresponding table row, but the execution contract requires every retained row to have detail and be moved to the archive on completion. Add a ledger item or explicitly remove this entry from the queue contract.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/outstanding-issues.md` around lines 78 - 92, Update the Operator
backlog/runbooks queue entry and its surrounding execution contract so every
retained queue row maps to an open ledger item with a `#ID` and corresponding
detail row. Either add the missing ledger item and define its completion/archive
path, or remove the orphaned entry from the queue and contract; preserve
traceability and archive behavior for all remaining entries.
This PR organizes the current dirty changes on codex/shared-task-ledger-final-72e621.
Summary by CodeRabbit