docs: restore remaining reviewed session follow-ups

[BigSimmo]

Summary

• restores the design-sync notes and mockup token substitutions that did not land in docs: consolidate remaining reviewed session follow-ups #1509
• preserves the corrected chore(deps-dev): bump prettier from 3.9.0 to 3.9.1 #98 retrieval-probe evidence and consolidates findings Parse nested JSONB job-status RPC result before completion gate checks #156-**_{_{}} Join documents before claiming schema jobs** #158
• retains issues: log this session's own reviews and the content-verification lesson #1511's content-verification lesson as Harden Playwright cache restore behavior #154 and issues: record the cross-session concurrency hazards seen on this task #1513's concurrency lesson as **_{_{}} Parse the JSON status RPC result before checking ok** #155 and all current-main review-ledger history

Areas touched

• .design-sync/NOTES.md
• docs/outstanding-issues.md
• docs/branch-review-ledger.md
• mockup-only favourites library styling

Verification

• npm run check:outstanding-issues — passed: 156 rows, 47 open, 109 archived, next-id 159
• npm run check:branch-review-ledger — passed before the final review append: 286 live + 1206 archived records
• npm run check:design-system-contract — passed: 614 production files
• npm run docs:check-links — passed: 1418 references
• npm run docs:check-scripts — passed: 413 references
• npm run docs:check-index — passed
• npm run format:changed — passed
• node ./node_modules/typescript/bin/tsc --noEmit — passed
• focused ESLint on the mockup — passed
• git diff --check origin/main...HEAD — passed

Not run

• provider-backed checks were not run; this change does not require them
• the previous exact head passed Build, unit coverage, static/config/security jobs, Lighthouse, visual baselines, and all three Production UI shards; the post-issues: log this session's own reviews and the content-verification lesson #1511 exact head must rerun hosted CI

RAG impact: no retrieval behaviour change — documentation evidence only; protected retrieval source is unchanged.

Summary by CodeRabbit

• Style

  • Updated mockup button hover states for clearer visual feedback.
  • Improved hover styling in the review console and set navigator.

• Documentation

  • Refined design-token triage notes and documented related repairs.
  • Updated review records and outstanding-issue tracking with recent findings, resolutions, and verification details.

[cursor]

PR #1510 is reopen-ready at 1e68f197.

Done

• Synced with current main (includes issues: record the cross-session concurrency hazards seen on this task #1513); merge tree clean — mergeable: MERGEABLE, mergeStateStatus: CLEAN
• Hosted CI green on tip, including PR required, Static PR, Safety, Unit coverage, Build, Production UI critical
• Bugbot: no Cursor Bugbot inline findings on this PR; local bugbot review found the P1 #098 false canary evidence (fixed)
• CodeRabbit: all 4 threads resolved; fixed computed-value-time wording, unique #033 queue order, and duplicated #098 Done block
• Left PR state untouched (still open; not closed/reopened)

Key content fixes

• #098: removed false canary/refutation claim; kept accurate work-branch note
• .design-sync/NOTES.md: #154 → #157, restored 7-token accounting, corrected CSS timing wording
• Recommended queue: #033 → order 19 (no duplicate 18)

No further unresolved review threads. Safe to reopen when you want.

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.design-sync/NOTES.md:
- Around line 84-89: Update the triage rule in the notes to say unresolved
var(--name) declarations become invalid at computed-value time and resolve to
the property’s initial or inherited value, replacing the inaccurate “dropped at
CSS parse time” wording while preserving the setter/fallback defect criteria.
In `@docs/branch-review-ledger.md`:
- Around line 332-345: Resolve the PR-1510 ledger lookup by replacing the
unresolvable ref “1510” with its full resolvable commit SHA, then rerun
ledger:lookup against that ref and append the resulting review record to the
branch-review ledger. Preserve the existing ledger and outstanding-issues guard
results.
In `@docs/outstanding-issues.md`:
- Around line 66-67: Update the queue-order value for the `#147` or `#033` entry in
the outstanding-issues table so each item has a unique order, while preserving
the surrounding rows’ ordering and keeping the numbering consistent.
- Line 129: In the `#098` row, remove the second duplicated completion block
beginning with “Done 2026-07-30 (PR `#1450`, `1bff4c78`)” and ending with the
repeated round-trip-counter blind-spot statement. Preserve the first identical
block and all subsequent search-budget findings and next steps unchanged.

🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 42a59e9a-2b14-4874-aec7-22809cc90cf3

📥 Commits

Reviewing files that changed from the base of the PR and between 46c2c1e and 05fb605.

📒 Files selected for processing (4)

• .design-sync/NOTES.md
• docs/branch-review-ledger.md
• docs/outstanding-issues.md
• src/components/favourites-page-mockups/favourites-library-redesign-page.tsx

[coderabbitai]

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

⚠️Branch updated during autofix.

The branch was updated while autofix was in progress. Please try again.