Skip to content

[WIP] Fix unsupported Gitleaks merge_group runs - #188

Merged
BigSimmo merged 3 commits into
mainfrom
claude/dont-require-unsupported-gitleaks-merg
Jul 2, 2026
Merged

[WIP] Fix unsupported Gitleaks merge_group runs#188
BigSimmo merged 3 commits into
mainfrom
claude/dont-require-unsupported-gitleaks-merg

Conversation

@Claude

@ClaudeClaudeAI commented Jul 2, 2026

Copy link
Copy Markdown

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>P1 Badge Don't require unsupported Gitleaks merge_group runs</issue_title>
<issue_description>P1 Badge Don't require unsupported Gitleaks merge_group runs

When merge queue is enabled and Gitleaks is required, this new trigger makes the workflow run gitleaks/gitleaks-action@v3 on merge_group; I checked the action's v3.0.0 source and its supportedEvents list excludes merge_group, so it exits with ERROR: The [merge_group] event is not yet supported. That means every queued PR will get a failing required Gitleaks check instead of the intended queue validation unless the scan is implemented with a merge-group-compatible command/action or guarded differently.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in #183 (comment)</issue_description>

<agent_instructions>Fix issue </agent_instructions>

Comments on the Issue (you are @claude[agent] in this section)

ClaudeAIand others added 2 commits July 2, 2026 14:29
Adds merge_group trigger to both CI and Secret Scan workflows for merge
queue support. Guards the gitleaks-action step with an event check since
gitleaks/gitleaks-action@v3 does not support the merge_group event.
The job still runs and succeeds on merge_group (satisfying the required
check), but the actual scan step is skipped. No coverage is lost because
the scan already ran on the pull_request event.
Closes#187
Agent-Logs-Url: https://github.com/BigSimmo/Database/sessions/aa4ae460-f69f-4247-8fa5-0aa6e38244f0
Co-authored-by: BigSimmo <87357024+BigSimmo@users.noreply.github.com>
@Claude
ClaudeAI requested a review from BigSimmoJuly 2, 2026 14:31
@BigSimmo
BigSimmo marked this pull request as ready for review July 2, 2026 14:42
@BigSimmo
BigSimmo enabled auto-merge (squash) July 2, 2026 14:42
@BigSimmo
BigSimmo merged commit c4d7aa3 into mainJul 2, 2026
4 checks passed
@BigSimmo
BigSimmo deleted the claude/dont-require-unsupported-gitleaks-merg branch July 2, 2026 16:31
BigSimmo added a commit that referenced this pull request Aug 13, 2026
… queue text (#1890)
* docs(issues): retire 22 non-actionable ledger rows and correct the #231 queue text
A yield review of all 114 open rows against current main. The queue had become
roughly 60 tasks and 50 notes; this removes the notes and fixes two places where
the ledger was actively misdirecting.
The correction that matters most: the recommended-queue entry for #231, the top
clinical P1, told every session to "measure and fix the fast-route budget /
generation timeout" — an approach #231's own detail records as tested and
rejected, because the decisive 40-second probe completed generation in 25.272s
with route_deadline_exceeded=false and still failed quality. The session-start
hook prints the queue, not the row, so the refuted text was the text agents read.
Closed 22 rows:
- #304 was already done on main (commit d182844 refreshed the ranking
snapshot; generatedAt is 0 days old, not 2026-07-20), yet sat in the queue
advertising a freshness fuse that is not armed.
- #241#244#272#294#300#257 were standing cautions whose own text says
"no action". Each one's knowledge now lives in the code it protects, so
closing the row loses nothing.
- #196-#200 are five steps of the disaster-recovery checklist that is
canonical in docs/operator-backlog.md, with no trigger until a restore.
- #86#188 were index rows over children that are individually findable.
- #250#253#254 were superseded; #250 and #253 say so themselves.
- #156#301#152#236#260 merged into #168, #292 and #169 respectively —
each pair or group was one problem recorded two to four times.
Demoted 20 rows with a stated reason (premature ops for a single-user
prototype, upstream-blocked, measurement-gated, or design-system adoption
competing with an open clinical P1). The Pri cell is unchanged because the
writer has no --pri flag — which is now #313.
Added three rows for mechanism gaps this sweep exposed: rows outliving their
own completion (#312), the missing --pri flag (#313), and the queue being able
to contradict the row it cites with no guard (#314).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
* docs(ledger): record the ledger yield review handoff
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
* Keep recovery work visible and pin forced colors
---------
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Don't require unsupported Gitleaks merge_group runs**

2 participants

@Claude@BigSimmo