docs(issues): retire 22 non-actionable ledger rows and correct the #231 queue text - #1890
Conversation
… queue text A yield review of all 114 open rows against current main. The queue had become roughly 60 tasks and 50 notes; this removes the notes and fixes two places where the ledger was actively misdirecting. The correction that matters most: the recommended-queue entry for #231, the top clinical P1, told every session to "measure and fix the fast-route budget / generation timeout" — an approach #231's own detail records as tested and rejected, because the decisive 40-second probe completed generation in 25.272s with route_deadline_exceeded=false and still failed quality. The session-start hook prints the queue, not the row, so the refuted text was the text agents read. Closed 22 rows: - #304 was already done on main (commit d182844 refreshed the ranking snapshot; generatedAt is 0 days old, not 2026-07-20), yet sat in the queue advertising a freshness fuse that is not armed. - #241#244#272#294#300#257 were standing cautions whose own text says "no action". Each one's knowledge now lives in the code it protects, so closing the row loses nothing. - #196-#200 are five steps of the disaster-recovery checklist that is canonical in docs/operator-backlog.md, with no trigger until a restore. - #86#188 were index rows over children that are individually findable. - #250#253#254 were superseded; #250 and #253 say so themselves. - #156#301#152#236#260 merged into #168, #292 and #169 respectively — each pair or group was one problem recorded two to four times. Demoted 20 rows with a stated reason (premature ops for a single-user prototype, upstream-blocked, measurement-gated, or design-system adoption competing with an open clinical P1). The Pri cell is unchanged because the writer has no --pri flag — which is now #313. Added three rows for mechanism gaps this sweep exposed: rows outliving their own completion (#312), the missing --pri flag (#313), and the queue being able to contradict the row it cites with no guard (#314). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:59 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:33cc073e9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BigSimmo
commented
Aug 12, 2026
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch claude/ledger-tasks-fable-xhl7xb at starting commit 01a83f5; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:claude/ledger-tasks-fable-xhl7xb, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BigSimmo
commented
Aug 12, 2026
@claude Work the current PR head |
Hi @BigSimmo — thanks for the @claude mention. Open this in Claude Code on the web to continue here: https://claude.ai/code Context: Automated backlink from the Claude backlink workflow. Claude Code can pick up the mention and push a scoped fix to the branch. |
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
BigSimmo
commented
Aug 13, 2026
@claude Please main-sync this PR from exact head This branch changes repository governance/ledgers as well as small code/contracts. Current Run all ledger/policy/write-discipline checks, the focused design-token contract, relevant component tests, typecheck and format. Report the new head and exact outcomes. |
Hi @BigSimmo — thanks for the @claude mention. Open this in Claude Code on the web to continue here: https://claude.ai/code Context: Automated backlink from the Claude backlink workflow. Claude Code can pick up the mention and push a scoped fix to the branch. |
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
BigSimmo
commented
Aug 13, 2026
@copilot Merge Current Run all ledger/policy/write-discipline checks, focused design-token contract, relevant component tests, typecheck and format. Report the pushed 40-character SHA and exact outcomes. |
Keep current-main policy, immutable ledger history and outstanding-task state after 211 newer base commits. Preserve only the branch's self-contained caution comments and exact forced-colours selector regression, including both dark selectors.
BigSimmo
commented
Aug 13, 2026
Sweep note for head |
Summary
#231, the top clinical P1. It told every session to "measure and fix the fast-route budget / generation timeout" — an approach#231's own detail records as tested and rejected, because the decisive 40-second probe completed generation in 25.272s (27.237s total) withroute_deadline_exceeded=falseand still failed generation quality..claude/hooks/issues-surface.shprints the queue, not the row, so the refuted text was the text agents actually read. The entry now states the budget is not the binding cause and points at offline instrumentation instead.#304, which was already done on main. Commitd182844(PR fix(rag): refresh the ranking snapshot before its 19 Aug expiry (#304), at zero cost #1876) refreshed the ranking snapshot;generatedAtis 0 days old withsourceRunId 31329507691, not the2026-07-20 / 29763761133the row described, so the 30-day freshness fuse it advertised as imminent is not armed.#241#244#272#294#300#257. Each one's knowledge was first moved into the code it protects, so closing the row loses nothing: the forced-colours selector group now says trimming it silently drops dark HCM;differentials-home.tsxnow says its "0 matches" strings are correct empty results and must not becomeErrorState;bindings.tsxnow says whycheck:therapy-data-indexis load-bearing; the viewer plan states its OffscreenCanvas condition self-containedly.#272needed no edit — the caution was already fully stated atpage-secondary-navigation.tsx:63-70.#196–#200to the runbook. Five steps of the disaster-recovery checklist that is canonical indocs/operator-backlog.md, with no trigger until a schema restore. Tracking a runbook as five queue rows is the same mistakeAGENTS.mdforbids in the other direction.#086#188(umbrellas over individually findable children),#250#253(both recommend closing themselves),#254(archaeology on a dispute settled when PR Codex/cloud mcp parity 20260804 #1613 closed).#156→#168,#301→#292, and#152#236#260→#169— each group was one problem recorded two to four times.#027#183), upstream-blocked (#090), measurement-gated (#013#016#101#282), findings that argue against acting (#033#035#036), and design-system adoption competing with an open clinical P1 (#266–#269#299).#312#313#314for mechanism gaps this sweep exposed — rows outliving their own completion, the writer's missing--priflag, and the queue being able to contradict the row it cites with nothing guarding it.AGENTS.mdPR-bundling reference from the retired#086umbrella to its live#190–#195children.Net: 114 open rows → 95 (22 closed, 3 added).
Verification
npm run verify:pr-local— all 24 checks completed,failed: (none). Includeslint,typecheck,test,build, andOffline RAG fixture and manifest validation passed (36 golden cases, 23 suites).npm run check:outstanding-issues—312 rows (95 open, 217 archived), unique ids, next-id=315 above the highest, no merge driver, no ids deleted from base 3dc1f37337d2npx vitest run tests/design-token-contract.test.ts—34 passed, covering the editedckb-v2-tokens.cssnpm run test:focusedon the two edited components —Test Files 5 passed (5) / Tests 22 passed (22)npm run formatrun and committedUI verification not run: every change to
src/in this diff is a comment. The CSS edit is inside an existing comment block and the two.tsxedits are JSX/line comments; no selector, token value, element, class or prop changed, so there is no rendered output forverify:uito exercise.check:pr-policyclassifies the diffui: trueon paths alone.npm ci --include=devwas run mid-verification: the firstverify:pr-localattempt failed atcheck:installed-lock-paritywith "installed file inventory differs from the trusted post-install stamp", which is container drift rather than anything in this diff. The re-run afternpm cipassed every check.Risk and rollout
Pricolumn (see below), soissues:reportpriority counts still read at the old priority for those 20 rows.git reverton the single commit. Closed rows are archived, not deleted, so every outcome line and its reasoning survives in the archive table either way.Notes
No Clinical Governance Preflight section:
classifyPullRequestFileson this exact file list returnsclinicalRisk: false, operationalRisk: false, ragRanking: false, ui: true, sopr-policyrequires neither the preflight nor aRAG impact:line. The only clinical-adjacent file isdifferentials-home.tsx, and the change there is a comment stating why its existing empty-state strings must not be converted.Known gap this PR documents rather than fixes:
scripts/outstanding-issues.mjs updatehas no--priflag, so the 20 demotions are stamped in the detail cell and thePricolumn is unchanged. Hand-editing the column would have meant hand-authoring rows, whichAGENTS.mdforbids and which the writer exists to prevent. Filed as#313with the fix described.One judgement call worth flagging for review: closing the six standing-caution rows depends on the code comments added here being durable. If a reviewer thinks any of that knowledge is safer in the ledger than in a comment, that row is the one to argue about —
#300in particular, since converting those sites toErrorStatewould tell a clinician the system broke when it did not.🤖 Generated with Claude Code
https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
Generated by Claude Code