Skip to content

docs(issues): retire 22 non-actionable ledger rows and correct the #231 queue text - #1890

Merged
BigSimmo merged 9 commits into
mainfrom
claude/ledger-tasks-fable-xhl7xb
Aug 13, 2026
Merged

docs(issues): retire 22 non-actionable ledger rows and correct the #231 queue text#1890
BigSimmo merged 9 commits into
mainfrom
claude/ledger-tasks-fable-xhl7xb

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Corrected the recommended-queue entry for #231, the top clinical P1. It told every session to "measure and fix the fast-route budget / generation timeout" — an approach #231's own detail records as tested and rejected, because the decisive 40-second probe completed generation in 25.272s (27.237s total) with route_deadline_exceeded=false and still failed generation quality. .claude/hooks/issues-surface.sh prints the queue, not the row, so the refuted text was the text agents actually read. The entry now states the budget is not the binding cause and points at offline instrumentation instead.
  • Closed #304, which was already done on main. Commit d182844 (PR fix(rag): refresh the ranking snapshot before its 19 Aug expiry (#304), at zero cost #1876) refreshed the ranking snapshot; generatedAt is 0 days old with sourceRunId 31329507691, not the 2026-07-20 / 29763761133 the row described, so the 30-day freshness fuse it advertised as imminent is not armed.
  • Closed six standing-caution rows whose own text says "no action"#241#244#272#294#300#257. Each one's knowledge was first moved into the code it protects, so closing the row loses nothing: the forced-colours selector group now says trimming it silently drops dark HCM; differentials-home.tsx now says its "0 matches" strings are correct empty results and must not become ErrorState; bindings.tsx now says why check:therapy-data-index is load-bearing; the viewer plan states its OffscreenCanvas condition self-containedly. #272 needed no edit — the caution was already fully stated at page-secondary-navigation.tsx:63-70.
  • Retired #196#200 to the runbook. Five steps of the disaster-recovery checklist that is canonical in docs/operator-backlog.md, with no trigger until a schema restore. Tracking a runbook as five queue rows is the same mistake AGENTS.md forbids in the other direction.
  • Closed index and superseded rows#086#188 (umbrellas over individually findable children), #250#253 (both recommend closing themselves), #254 (archaeology on a dispute settled when PR Codex/cloud mcp parity 20260804 #1613 closed).
  • Merged eleven rows into four.#156#168, #301#292, and #152#236#260#169 — each group was one problem recorded two to four times.
  • Demoted 20 rows with a stated reason: premature ops for a single-user prototype (#027#183), upstream-blocked (#090), measurement-gated (#013#016#101#282), findings that argue against acting (#033#035#036), and design-system adoption competing with an open clinical P1 (#266#269#299).
  • Added #312#313#314 for mechanism gaps this sweep exposed — rows outliving their own completion, the writer's missing --pri flag, and the queue being able to contradict the row it cites with nothing guarding it.
  • Repointed the AGENTS.md PR-bundling reference from the retired #086 umbrella to its live #190#195 children.

Net: 114 open rows → 95 (22 closed, 3 added).

Verification

  • npm run verify:pr-local — all 24 checks completed, failed: (none). Includes lint, typecheck, test, build, and Offline RAG fixture and manifest validation passed (36 golden cases, 23 suites).
  • npm run check:outstanding-issues312 rows (95 open, 217 archived), unique ids, next-id=315 above the highest, no merge driver, no ids deleted from base 3dc1f37337d2
  • npx vitest run tests/design-token-contract.test.ts34 passed, covering the edited ckb-v2-tokens.css
  • npm run test:focused on the two edited components — Test Files 5 passed (5) / Tests 22 passed (22)
  • npm run format run and committed

UI verification not run: every change to src/ in this diff is a comment. The CSS edit is inside an existing comment block and the two .tsx edits are JSX/line comments; no selector, token value, element, class or prop changed, so there is no rendered output for verify:ui to exercise. check:pr-policy classifies the diff ui: true on paths alone.

npm ci --include=dev was run mid-verification: the first verify:pr-local attempt failed at check:installed-lock-parity with "installed file inventory differs from the trusted post-install stamp", which is container drift rather than anything in this diff. The re-run after npm ci passed every check.

Risk and rollout

  • Risk: Low. No executable behaviour changes. The reversible risk is judgement, not code — a row closed here that turns out to matter has to be re-opened by hand, and demotions are recorded in the detail cell rather than the Pri column (see below), so issues:report priority counts still read at the old priority for those 20 rows.
  • Rollback:git revert on the single commit. Closed rows are archived, not deleted, so every outcome line and its reasoning survives in the archive table either way.
  • Provider or production effects: None. No provider call, no hosted mutation, no migration, no deployment behaviour.

Notes

No Clinical Governance Preflight section:classifyPullRequestFiles on this exact file list returns clinicalRisk: false, operationalRisk: false, ragRanking: false, ui: true, so pr-policy requires neither the preflight nor a RAG impact: line. The only clinical-adjacent file is differentials-home.tsx, and the change there is a comment stating why its existing empty-state strings must not be converted.

Known gap this PR documents rather than fixes:scripts/outstanding-issues.mjs update has no --pri flag, so the 20 demotions are stamped in the detail cell and the Pri column is unchanged. Hand-editing the column would have meant hand-authoring rows, which AGENTS.md forbids and which the writer exists to prevent. Filed as #313 with the fix described.

One judgement call worth flagging for review: closing the six standing-caution rows depends on the code comments added here being durable. If a reviewer thinks any of that knowledge is safer in the ledger than in a comment, that row is the one to argue about — #300 in particular, since converting those sites to ErrorState would tell a clinician the system broke when it did not.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU


Generated by Claude Code

… queue text
A yield review of all 114 open rows against current main. The queue had become
roughly 60 tasks and 50 notes; this removes the notes and fixes two places where
the ledger was actively misdirecting.
The correction that matters most: the recommended-queue entry for #231, the top
clinical P1, told every session to "measure and fix the fast-route budget /
generation timeout" — an approach #231's own detail records as tested and
rejected, because the decisive 40-second probe completed generation in 25.272s
with route_deadline_exceeded=false and still failed quality. The session-start
hook prints the queue, not the row, so the refuted text was the text agents read.
Closed 22 rows:
- #304 was already done on main (commit d182844 refreshed the ranking
snapshot; generatedAt is 0 days old, not 2026-07-20), yet sat in the queue
advertising a freshness fuse that is not armed.
- #241#244#272#294#300#257 were standing cautions whose own text says
"no action". Each one's knowledge now lives in the code it protects, so
closing the row loses nothing.
- #196-#200 are five steps of the disaster-recovery checklist that is
canonical in docs/operator-backlog.md, with no trigger until a restore.
- #86#188 were index rows over children that are individually findable.
- #250#253#254 were superseded; #250 and #253 say so themselves.
- #156#301#152#236#260 merged into #168, #292 and #169 respectively —
each pair or group was one problem recorded two to four times.
Demoted 20 rows with a stated reason (premature ops for a single-user
prototype, upstream-blocked, measurement-gated, or design-system adoption
competing with an open clinical P1). The Pri cell is unchanged because the
writer has no --pri flag — which is now #313.
Added three rows for mechanism gaps this sweep exposed: rows outliving their
own completion (#312), the missing --pri flag (#313), and the queue being able
to contradict the row it cites with no guard (#314).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
@coderabbitai

coderabbitaiBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:59 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d3c45861-7ce8-4425-9359-9d1c5a36ef87

📥 Commits

Reviewing files that changed from the base of the PR and between 084f0f9 and f3dfd6e.

📒 Files selected for processing (5)
  • docs/plans/document-viewer-redesign-plan.md
  • src/app/ckb-v2-tokens.css
  • src/components/clinical-dashboard/differentials-home.tsx
  • src/components/therapy-compass/bindings.tsx
  • tests/design-token-contract.test.ts

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 12, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo enabled auto-merge August 12, 2026 21:32

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:33cc073e9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threaddocs/outstanding-issues.md Outdated
Comment threadsrc/app/ckb-v2-tokens.css
@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch claude/ledger-tasks-fable-xhl7xb at starting commit 01a83f5; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:claude/ledger-tasks-fable-xhl7xb, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit:01a83f5bb4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BigSimmoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

@claude Work the current PR head 01a83f5bb47e390753327a3124b5a2d73b755e82 only. First address both current unresolved P2 review threads: (1) keep the still-pending disaster-recovery obligations represented as an open consolidated ledger item rather than archiving #196#200 as completed work, while preserving the canonical runbook as the procedure; (2) add the exact forced-colours selector-group contract assertion the new comment claims exists before retiring #244. Use the repository issue/ledger workflow rather than hand-editing durable rows, add the narrow regression test, and run relevant ledger/design-token checks. Then fetch current main and merge it into this PR branch without rebase or force-push, resolving only merge conflicts while preserving the verified fixes and newer main changes. Push the scoped repair/merge commit(s), reply with pushed SHA(s) and verification, and resolve only threads whose fixes are on the current pushed head. Do not merge or close the PR, deploy, alter auto-merge, or broaden scope.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @BigSimmo — thanks for the @claude mention.

Open this in Claude Code on the web to continue here: https://claude.ai/code

Context: BigSimmo/Database · #1890

Automated backlink from the Claude backlink workflow. Claude Code can pick up the mention and push a scoped fix to the branch.

@claude

claudeBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@BigSimmo
BigSimmo disabled auto-merge August 12, 2026 21:50
@BigSimmo
BigSimmo enabled auto-merge August 12, 2026 21:53
@BigSimmo
BigSimmo disabled auto-merge August 12, 2026 22:05
@BigSimmo
BigSimmo enabled auto-merge August 12, 2026 22:07
@BigSimmo
BigSimmo disabled auto-merge August 12, 2026 22:49
@BigSimmo
BigSimmo enabled auto-merge (squash) August 12, 2026 23:07
@BigSimmo
BigSimmo disabled auto-merge August 12, 2026 23:17
@BigSimmo
BigSimmo enabled auto-merge August 12, 2026 23:37
@BigSimmo
BigSimmo disabled auto-merge August 12, 2026 23:51
@BigSimmo
BigSimmo enabled auto-merge August 13, 2026 00:07
@BigSimmo
BigSimmo disabled auto-merge August 13, 2026 00:17
@BigSimmo
BigSimmo enabled auto-merge August 13, 2026 00:37
@BigSimmo
BigSimmo disabled auto-merge August 13, 2026 01:07
@BigSimmo
BigSimmo enabled auto-merge August 13, 2026 01:37
@BigSimmo
BigSimmo disabled auto-merge August 13, 2026 01:59
@BigSimmo
BigSimmo enabled auto-merge (squash) August 13, 2026 02:07
@BigSimmoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

@claude Please main-sync this PR from exact head 500e41c6d8347163ad388bfada991317b7df4dbf: merge the latest main once (never rebase), resolve all conflicts minimally, commit and push. Do not merge/close the PR, force-push, alter auto-merge, or touch unrelated files.

This branch changes repository governance/ledgers as well as small code/contracts. Current main is authoritative for AGENTS.md, docs/branch-review-ledger.md and docs/outstanding-issues.md: preserve all newer policy/history/open tasks; do not rewrite immutable history, re-resolve genuinely pending work, or reintroduce duplicates. Retain this PR’s already-verified fixes: one consolidated open P2 disaster-recovery task with the schema-restore trigger and all five pending actions, plus the exact complete forced-colours selector-group regression covering both dark selectors. Preserve newer main changes in Therapy bindings and Differentials home.

Run all ledger/policy/write-discipline checks, the focused design-token contract, relevant component tests, typecheck and format. Report the new head and exact outcomes.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @BigSimmo — thanks for the @claude mention.

Open this in Claude Code on the web to continue here: https://claude.ai/code

Context: BigSimmo/Database · #1890

Automated backlink from the Claude backlink workflow. Claude Code can pick up the mention and push a scoped fix to the branch.

@claude

claudeBot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@BigSimmoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

@copilot Merge main at 0709965e66e04173ec0b0de1d121e85ac1ff7e04 into current head 500e41c6d8347163ad388bfada991317b7df4dbf, resolve conflicts minimally, and push the merge commit to claude/ledger-tasks-fable-xhl7xb. Never rebase or force-push. Do not merge/close the PR, deploy, alter auto-merge, or touch unrelated files.

Current main is authoritative for AGENTS.md, docs/branch-review-ledger.md and docs/outstanding-issues.md: preserve all newer policy, immutable history and open tasks; do not re-close genuinely pending work or reintroduce duplicates. Retain the already-verified fixes from this PR: one consolidated open P2 disaster-recovery task containing the schema-restore trigger plus all five actions, and the exact forced-colours selector-group regression covering both dark selectors. Preserve newer current-main Therapy/Differentials changes.

Run all ledger/policy/write-discipline checks, focused design-token contract, relevant component tests, typecheck and format. Report the pushed 40-character SHA and exact outcomes.

Keep current-main policy, immutable ledger history and outstanding-task state after 211 newer base commits. Preserve only the branch's self-contained caution comments and exact forced-colours selector regression, including both dark selectors.
@BigSimmoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Sweep note for head 107daadc347fdf0e60375da9c88d711dc105a001: the 211-commit main-sync was resolved conservatively. Current main remains authoritative for AGENTS.md, immutable review history and docs/outstanding-issues.md; the branch no longer applies its stale broad row closures/demotions or re-archives restore-dependent work. The resulting five-file diff preserves only the self-contained caution comments and the exact forced-colours selector-group regression (including both dark selectors). Exact-head CI is now authoritative for this reduced scope.

@BigSimmo
BigSimmo merged commit 778de3d into mainAug 13, 2026
26 checks passed
@BigSimmo
BigSimmo deleted the claude/ledger-tasks-fable-xhl7xb branch August 13, 2026 04:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@claude