fix(ui): raise remaining interactive tap floors - #2424
Conversation
Primary actions on documents, compare, tools, calculators, forms, and chips still used sub-48px heights. Raise those controls to the tap floor so phone targets stay reachable without shrinking CTAs. Co-authored-by: Cursor <cursoragent@cursor.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 102 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (13)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_cb34185d-0a75-4698-982a-e8f68dd4f020) |
CI triageCI failed on this PR. Automated classification of the 3 failed job(s):
Compared with main CI run #14256 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6ab213b0-1a9b-478e-ac52-ca7296a777fb) |
CI's Static PR checks job failed because merging main (#2422) shifted component adoption counts without regenerating the tracked snapshot. Re-run npm run design-system:adoption:update to bring docs/design-system/adoption-manifest.json and COMPONENTS.md back in step.
# Conflicts: # docs/design-system/COMPONENTS.md
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_46e19f74-40a0-49d2-b64d-ac307dca55e2) |
This PR's Chip change unified the remove button's hit area to a fixed min-h-tap regardless of wrap state, but two ui-v2-components.dom.test.tsx assertions still expected the old h-full / min-h-5 h-full classes that no longer apply to the button element. Update both to assert min-h-tap.
Uh oh!
There was an error while loading. Please reload this page.
Resolve conflicts in favour of main, which has since landed the same design-system intent through the shared recipes and Button/PageHeader adoption (PRs #2420, #2424, #2425, #2426): - ui-primitives.tsx: main split the module into primitive-recipes/*; the branch's compact-meta edits to `interactiveCompact` and `tableMicroActionRow` are already present verbatim in recipes.ts. - specifier compare/map/record/builder, differential-detail: main's `primaryControl` / `Button` adoption carries the same `min-h-tap` floor through `controlBase`, so the hand-rolled classes are superseded. - formulation-builder: main's `fieldControlPlain` recipe supersedes the hand-rolled textarea classes. - pathways-screen: main's therapy-pathways redesign (#2413) already removed the arbitrary spacing literals this branch was ratcheting. Regenerate the contract baseline against the merged tree.
Summary
Verification
pm run format on changed files (included in this commit)
pm run verify:pr-local
Verification not run: approved 6-PR split publication; local format applied to the replayed slice. �erify:pr-local, lint, typecheck, unit, and hosted CI were left unrun by request.
UI verification not run: �erify:ui left unrun by request.
pm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
pm run verify:release before release or handoff confidence claims
For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, �erify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.
pm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed** — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
pm run eval:rag -- --limit 15 +
pm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
pm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
pm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed
Risk and rollout
Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.
Clinical Governance Preflight
N/A — design-system tap/chrome/tokens only; no ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical-output contract changes.
Notes
Note
Low Risk
CSS tap-target and one local Checkbox adoption plus settings scroll styling; no auth, data, or retrieval changes.
Overview
Standardizes interactive hit areas on documents, calculators, compare, forms, tools, settings, and chip remove controls by replacing ad-hoc
min-h-8/min-h-9/min-h-10(and similar) with the sharedmin-h-taptoken, and drops redundant height classes where shared recipes (e.g.floatingControl) already enforce the floor.Document admin swaps the native “Needs review” queue checkbox for the design-system
Checkboxfromchoice.tsx, and gives several<summary>rowsmin-h-tapfor disclosure tap targets.Chip removable chips center the remove button with
min-h-tap/w-8so the painted chip stays compact while the hit target meets the production floor.Settings dialog removes Tailwind
scroll-smoothfrom the scroll port and tightens comments/behavior around section scrolling under reduced motion vs smoothscrollTo.Adoption/docs (slice F):
adoption-manifest.jsonand COMPONENTS.md refresh counts and maturity rows (Checkbox, FieldHint, FieldError now show product imports / v2 mount); P1 outline groupsAppliedFilters/CopyButtonwith other spec-only items instead of a separate “built but unregistered” callout.Reviewed by Cursor Bugbot for commit afce182. Configure here.