Skip to content

fix(ui): tokenise globals motion/z, Ward PRM, hash scroll clamp - #2428

Merged
BigSimmo merged 10 commits into
mainfrom
claude/ds-h36-motion-scroll
Aug 27, 2026
Merged

fix(ui): tokenise globals motion/z, Ward PRM, hash scroll clamp#2428
BigSimmo merged 10 commits into
mainfrom
claude/ds-h36-motion-scroll

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 27, 2026•
edited by cursor Bot
Loading

Copy link
Copy Markdown
Owner

Summary

Verification

  • [x]
    pm run format on changed files (included in this commit)
  • [ ]
    pm run verify:pr-local

Verification not run: approved 6-PR split publication; local format applied to the replayed slice. �erify:pr-local, lint, typecheck, unit, and hosted CI were left unrun by request.
UI verification not run: �erify:ui left unrun by request.

  • [ ]
    pm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • [ ]
    pm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, �erify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • **
    pm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed** — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
  • [ ]
    pm run eval:rag -- --limit 15 +
    pm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
  • [ ]
    pm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
  • [ ]
    pm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Risk and rollout

Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.

  • Risk: low — CSS token aliases, reduced-motion, and in-page scroll clamp; no retrieval, ingestion, or auth changes.
  • Rollback: revert this PR.
  • Provider or production effects: None
  • RAG impact: no retrieval behaviour change — design-system tap/chrome/tokens only.

Clinical Governance Preflight

N/A — design-system tap/chrome/tokens only; no ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical-output contract changes.

Notes

Note

Low Risk
CSS token aliases, shared Ward PRM, and scroll clamping only; no auth, data, or retrieval changes. Residual risk is visual/stacking or scroll-position edge cases on phone chrome and Ward surfaces.

Overview
Design tokens in globals.css: Adds documented --z-base, --z-raised, and --z-chrome and wires footer/backdrop/FAB/PWA stacking to the ladder (overlay/popover/modal unchanged). Swaps many 150ms/180ms/200ms transitions for --duration-quick / --duration-base / --duration-moderate, and a few radii for --radius-xl / --radius-pill. Literals that contracts forbid retokenising (160ms chips, 240ms dock hide delay, z-index 2/30) stay with inline comments.

Scroll behaviour:scrollSurface and clinical dashboard hash navigation now clamp scroll targets to [0, maxScroll], including "end", so short #quotes / #images sections do not overscroll and fight hide-on-scroll chrome.

Ward reduced motion: New ward-reduced-motion.module.css centralises prefers-reduced-motion transition kills; ward shells compose namedKill / descendantKill / descendantKillWithScroll and drop duplicated per-module blocks.

Minor UI: Calculator guided-flow progress uses scaleX instead of animating width.

Reviewed by Cursor Bugbot for commit 5e80f64. Configure here.

@BigSimmo@cursoragent
fix(ui): tokenise globals motion/z, Ward PRM, hash scroll clamp
012821f
Remaining chrome still used raw duration, z-index, and radius literals, Ward motion ignored prefers-reduced-motion, and hash scroll could overshoot. Tokenise those values and clamp in-page scroll so reduced-motion and stacking stay on the documented ladder.
Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

chatgpt-codex-connectorBot commented Aug 27, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitaiBot commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 16 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 102 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0f4d694f-f677-4d8c-b98f-76a5a5362b9b

📥 Commits

Reviewing files that changed from the base of the PR and between ba37649 and d2611dc.

⛔ Files ignored due to path filters (1)
  • docs/design-system/GATES.md is excluded by !docs/**, !**/*.md
📒 Files selected for processing (16)
  • src/app/globals.css
  • src/components/ClinicalDashboard.tsx
  • src/components/calculators/guided-flow.tsx
  • src/components/clinical-dashboard/scroll-surface.ts
  • src/components/ward-management/coordinator/coordinator.module.css
  • src/components/ward-management/officer/officer.module.css
  • src/components/ward-management/tracker/live-tracker.module.css
  • src/components/ward-management/ward-demo-controls.module.css
  • src/components/ward-management/ward-management-modes.module.css
  • src/components/ward-management/ward-management-network.module.css
  • src/components/ward-management/ward-management.module.css
  • src/components/ward-management/ward-reduced-motion.module.css
  • src/components/ward-management/ward-role-switcher.module.css
  • src/components/ward-management/ward-sidebar.module.css
  • tests/design-system-contract-utils.test.ts
  • tests/ui-style-contract.spec.ts

Comment @coderabbitai help to get the list of available commands.

@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_aa75e12c-4a01-4deb-ab42-2098b8f23dc7)

This was referenced Aug 27, 2026
Merged
Merged
Merged
Merged
Merged
@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_bcfb8900-aac6-452f-9f3f-18fbc470e8cf)

@BigSimmo
BigSimmo enabled auto-merge (squash) August 27, 2026 13:09
@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_f3ea2d80-4719-46a4-9434-3eeb52a95724)

@github-actions

github-actionsBot commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 4 failed job(s):

  • Unit coverage — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • Production UI (3) — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • Advisory UI — not baselined: this job did NOT run on the main comparison below (path-scoped skip), so that run says nothing about it either way. Treat the comparison as absent, not green, and inspect the failing step.
  • PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #14286 (failure). That run's conclusion is an aggregate and did not exercise Advisory UI.

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_86aa9f62-6c16-470b-975c-a98b7d5ff139)

BigSimmoand others added 3 commits August 27, 2026 22:30
@BigSimmo
Merge branch 'main' into claude/ds-h36-motion-scroll
5270ef1
@claude
test(design-system): ratchet the raw CSS z-index pin from 8 to 4
5fc2446
Tokenising the globals.css stacking ladder onto --z-base/--z-raised/--z-chrome
left only four documented raw z-index exceptions (-1, 2, 2, 30), so the two
DS-P3-06 pins that asserted an exact count of 8 went red in Unit coverage and
Production UI (3). Lower both pins and the GATES.md prose to 4 — a tightening
of the ratchet, and the expansion probe still rejects a fifth.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K2z2dWV4KAa2ryYkictVtC
@claude
Merge branch 'main' into claude/ds-h36-motion-scroll
d2611dc
@BigSimmo
BigSimmo merged commit 6f364c1 into mainAug 27, 2026
29 checks passed
@BigSimmo
BigSimmo deleted the claude/ds-h36-motion-scroll branch August 27, 2026 15:14
BigSimmo pushed a commit that referenced this pull request Aug 27, 2026
@claude
Merge branch 'main' into claude/ds-h36-baseline
e691247
PR #2428 (E, globals motion/z + Ward reduced-motion + hash scroll clamp)
landed on main, completing the A-E stack. Its version of the DS-P3-06
z-index pin is byte-identical to this branch's ratchet (8 -> 4, probe
9 -> 5), so take main and keep the file free of divergence.
The branch now contributes exactly one file over main — the regenerated
scripts/design-system-contract-baseline.json — which is what this PR is
for. Regenerating against the merged tree produced no further change.
Evidence: 898 test files / 10862 tests passed;
check:design-system-contract, adoption and design-sync all clean.
@BigSimmoBigSimmo mentioned this pull request Aug 27, 2026
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@claude