feat(design-system): compact-meta density policy - #2425
Conversation
Metadata and disclosure controls were borrowing tap-floor or ad-hoc min-heights. Add --spacing-compact-meta (40px) and adopt it on those surfaces so primary CTAs stay at 48px. Co-authored-by: Cursor <cursoragent@cursor.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used the included review currently available. Your 102 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (18)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a846df69-9897-4b2c-9b76-77c263e0d771) |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #14226 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_111d7c7e-7a31-410e-af32-a4b7309c52db) |
--spacing-compact-meta was added to globals.css for the density policy but not added to CLINICAL_TWMERGE_THEME.spacing, failing the config tracking test.
…-meta # Conflicts: # src/components/ui-primitives.tsx
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2f069067-d093-41e2-9961-ea6af7262bee) |
Uh oh!
There was an error while loading. Please reload this page.
Resolve conflicts in favour of main, which has since landed the same design-system intent through the shared recipes and Button/PageHeader adoption (PRs #2420, #2424, #2425, #2426): - ui-primitives.tsx: main split the module into primitive-recipes/*; the branch's compact-meta edits to `interactiveCompact` and `tableMicroActionRow` are already present verbatim in recipes.ts. - specifier compare/map/record/builder, differential-detail: main's `primaryControl` / `Button` adoption carries the same `min-h-tap` floor through `controlBase`, so the hand-rolled classes are superseded. - formulation-builder: main's `fieldControlPlain` recipe supersedes the hand-rolled textarea classes. - pathways-screen: main's therapy-pathways redesign (#2413) already removed the arbitrary spacing literals this branch was ratcheting. Regenerate the contract baseline against the merged tree.
Summary
Verification
pm run format on changed files (included in this commit)
pm run verify:pr-local
Verification not run: approved 6-PR split publication; local format applied to the replayed slice. �erify:pr-local, lint, typecheck, unit, and hosted CI were left unrun by request.
UI verification not run: �erify:ui left unrun by request.
pm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
pm run verify:release before release or handoff confidence claims
For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, �erify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.
pm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed** — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
pm run eval:rag -- --limit 15 +
pm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
pm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
pm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed
Risk and rollout
Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.
Clinical Governance Preflight
N/A — design-system tap/chrome/tokens only; no ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical-output contract changes.
Notes
Note
Low Risk
CSS density and touch-target sizing across many UI surfaces; primary CTAs are tightened to remain 48px, but widespread class changes could affect layout or pointer hit areas on desktop until UI verification runs.
Overview
Introduces
--spacing-compact-meta(40px) and themin-h-compact-metautilities so metadata, disclosure, filter chips, and search-band chrome can shrink on pointer layouts without treating row height (min-h-9/--row-compact) or ad-hocsm:min-h-10as tap targets.Policy (documented in TOKENS §2 and COMPONENTS): filled primary/command actions stay
min-h-tapat every breakpoint — this PR removes desktop step-downs on CTAs such as Continue, Create set, Compare, Apply/Done, View PDF, and mode-home command buttons. Secondary/metadata controls gainsm:/lg:min-h-compact-meta(filters, sort/view toggles, disclosures, catalogue chips, table micro-actions,interactiveCompact/tableMicroActionRowrecipes).min-h-11is explicitly banned;tailwind-mergelearns thecompact-metaspacing group.Call-site tweaks: calculator jump/filter chips move from
min-h-9/min-h-10to compact-meta; Copy summary moves tomin-h-tap; document tag “show more” chips expand hit area via::beforewhile staying visually compact.Reviewed by Cursor Bugbot for commit 006c77b. Configure here.