Skip to content

Cursor/cloud agent 1787842840327 vmus2 - #2441

Closed
BigSimmo wants to merge 11 commits into
mainfrom
cursor/cloud-agent-1787842840327-vmus2
Closed

Cursor/cloud agent 1787842840327 vmus2#2441
BigSimmo wants to merge 11 commits into
mainfrom
cursor/cloud-agent-1787842840327-vmus2

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run verify:pr-local

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • npm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
  • npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
  • npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
  • npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Risk and rollout

Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.

  • Risk:
  • Rollback:
  • Provider or production effects: None / describe the explicitly authorized effect
  • RAG impact: Required if touching RAG ranking surfaces (src/lib/rag/, retrieval RPCs, golden fixtures, ranking tests; see docs/rag-behaviour/safeguards.md). Must use one of:
    • RAG impact: no retrieval behaviour change — <reason>
    • RAG impact: behaviour change — canary pair <baseline run> -> <post run>
    • (Use RAG impact: none or omit for non-RAG PRs)

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes


Note

Low Risk
Changes are documentation, indexes, and a repo snapshot; no application or gate script changes appear in this diff.

Overview
Closes the Hazard 1–2 design-system sweep in documentation: adds docs/design-system/FIX-GUIDE.md as the disposition ledger (Fixed / Documented / Deferred / Out-of-scope) and wires it into the design-system README and top-level docs index.

Doc set is brought in line with sweep outcomes without re-stating rules in the fix guide: registry counts 55 visual exports; ErrorState is recorded as built/registered; --text-placeholder is live; type-scale contract text drops per-step -lh/-tr orphans in favor of --leading-prose and hero companions; medication #0f766e defaults are documented as scoped RAW_COLOR_EXEMPTIONS (data, not --clinical-accent); GATES.md and design-system-contract.md reflect updated ratchet numbers (e.g. raw colours 0, edge/spread/tap debt counts).

Navigation hygiene: UI work is pointed at docs/design-system/README.md as the front door (with design-system.md as live-layer transition notes) across codebase index, testing, and process-hardening; repo-awareness-snapshot.json is refreshed (new SHA, FIX-GUIDE catalogued, doc counts). A branch review record notes verification gaps on the sweep branch (focused tests / contract checks not run).

Reviewed by Cursor Bugbot for commit 5e3eaae. Configure here.

BigSimmoand others added 11 commits August 27, 2026 14:10
Remaining Lucide size={15} and 1px shadow spreads were blocking the
token contract. Map those to named tokens, drop unused v2 line-height
companions, and record leftover Hazard 2/3 items in FIX-GUIDE.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts:
#	src/components/therapy-compass/therapy-card.tsx
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep quoted contract numbers in lockstep with the baseline JSON, and replace nested brief-duration ternaries plus leftover Lucide size={16} on screens this sweep already touched.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@supabase

supabaseBot commented Aug 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 33 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 103 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 06c0122c-aa91-455b-b580-d58e0bdd549f

📥 Commits

Reviewing files that changed from the base of the PR and between c177519 and 5e3eaae.

⛔ Files ignored due to path filters (15)
  • docs/README.md is excluded by !docs/**, !**/*.md
  • docs/branch-review-records/be0d35ad96adbaa5219303ff8595fd560ba330b3fc03c79f10d2dabdf35b4921.record.md is excluded by !docs/**, !**/*.md
  • docs/codebase-index.md is excluded by !docs/**, !**/*.md
  • docs/design-system-contract.md is excluded by !docs/**, !**/*.md
  • docs/design-system/ADOPTION.md is excluded by !docs/**, !**/*.md
  • docs/design-system/COMPONENTS.md is excluded by !docs/**, !**/*.md
  • docs/design-system/DECISIONS.md is excluded by !docs/**, !**/*.md
  • docs/design-system/FIX-GUIDE.md is excluded by !docs/**, !**/*.md
  • docs/design-system/GATES.md is excluded by !docs/**, !**/*.md
  • docs/design-system/README.md is excluded by !docs/**, !**/*.md
  • docs/design-system/SPEC.md is excluded by !docs/**, !**/*.md
  • docs/design-system/TOKENS.md is excluded by !docs/**, !**/*.md
  • docs/process-hardening.md is excluded by !docs/**, !**/*.md
  • docs/scripts-index.md is excluded by !docs/**, !**/*.md
  • docs/testing.md is excluded by !docs/**, !**/*.md
📒 Files selected for processing (16)
  • data/repo-awareness-snapshot.json
  • scripts/design-system-contract-baseline.json
  • scripts/design-system-contract-utils.mjs
  • src/app/ckb-v2-tokens.css
  • src/app/globals.css
  • src/components/differentials/differential-detail-page.tsx
  • src/components/specifiers/specifier-builder-page.tsx
  • src/components/specifiers/specifier-ui.tsx
  • src/components/therapy-compass/screens/brief-screen.tsx
  • src/components/therapy-compass/screens/compare-screen.tsx
  • src/components/therapy-compass/screens/recommend-screen.tsx
  • src/components/therapy-compass/screens/sheets-screen.tsx
  • tests/ckb-v2-token-contract.test.ts
  • tests/design-system-adoption.test.ts
  • tests/design-system-contract-utils.test.ts
  • tests/therapy-compass-responsive-contract.test.ts

Comment @coderabbitai help to get the list of available commands.

@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_39bfc42d-2e76-4c27-be1e-50495561c0dd)

@BigSimmoClaude

Copy link
Copy Markdown
OwnerAuthor

Closing as superseded/stale.

This branch forked from main 36 commits back, right before the "Hazard 1–2" design-system sweep it describes itself as closing was merged. That sweep, and seven follow-on PRs, have since landed on main: #2416, #2420, #2421, #2425, #2426, #2427, #2428, #2429.

Evidence:

  • git merge-tree against current main shows real content conflicts (not just staleness) in 8 files, including two generated files (data/repo-awareness-snapshot.json, scripts/design-system-contract-baseline.json) and core design-system docs/source (docs/design-system/GATES.md, docs/design-system/TOKENS.md, docs/design-system/FIX-GUIDE.md, src/app/globals.css, src/components/specifiers/specifier-builder-page.tsx, src/components/specifiers/specifier-ui.tsx).
  • docs/design-system/FIX-GUIDE.md already exists on main with materially the same content (added by Pay down design-system Hazard 1–2 (icons, shadows, tokens, docs) #2416) — this PR's copy is an earlier, slightly less accurate draft of the same disposition table.
  • differential-detail-page.tsx would regress the PageHeader adoption that landed via refactor(ui): adopt PageHeader on mode pages and Button in sidebar #2426, reverting to the pre-adoption hand-rolled header/breadcrumb markup.
  • tests/design-system-adoption.test.ts and tests/therapy-compass-responsive-contract.test.ts, which this PR adds as new files, already exist on main.
  • The PR body's Summary, Risk, Rollback, and Notes sections were never filled in, and the PR mergeability / PR policy checks are already failing on the current head.

There's no net-new content here worth salvaging — everything genuine in this diff already landed through a cleaner lineage. Recommend closing rather than rebasing; a rebase would mean discarding nearly the whole diff in favor of what main already has.


Generated by Claude Code

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo