Sigp audit fixes by JasonVranek · Pull Request #438 · Commit-Boost/commit-boost-client

JasonVranek · 2026-03-19T18:22:31Z

Implements the recommended changes to address issues from the Sigma Prime audit report.

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

…st-client into sigp-audit-fixes

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

…st-client into sigp-audit-fixes

Co-authored-by: Joe Clapis <jclapis@outlook.com>

… rightmost setup (#410)

- add missing ADMIN_JWT_ENV and SIGNER_TLS_CERTIFICATES_PATH_ENV - support https healthchecks

…eserialization error message

…which conflicted with deserializing `SignConsensusRequest`

…fault to readlock

…estart

Will address in next PR

* PBS: Reload the config file when it changes (Commit-Boost#409) * ssv-network: SSV-node API support (Commit-Boost#415) Co-authored-by: Joe Clapis <jclapis@outlook.com> * fix(tests): update tests for SSV API rename and PbsState signature change (Commit-Boost#427) * Fix broken CLI caused by double-parse bug (Commit-Boost#428) Co-authored-by: Joe Clapis <jclapis@outlook.com> * Support custom chain ids (Commit-Boost#429) * Update README.md (Commit-Boost#436) * Unify the CLI, PBS, and Signer Binaries into One (Commit-Boost#425) Co-authored-by: Jason Vranek <jasonvranek@gmail.com> ClosesCommit-Boost#430, Commit-Boost#431, Commit-Boost#432 * add get_header auction winner log (Commit-Boost#443) * Sigp audit fixes (Commit-Boost#438) Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com> Co-authored-by: Joe Clapis <jclapis@outlook.com> Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> * fix deps from cherrypicking * Update release.yml to work with unified binaries Commit-Boost#415 --------- Co-authored-by: Joe Clapis <jclapis@outlook.com> Co-authored-by: iurii-ssv <183610124+iurii-ssv@users.noreply.github.com> Co-authored-by: Sergey Yakovlev <selfuryon@pm.me> Co-authored-by: Dominik Niedbała <dominikniedbala18@gmail.com> Co-authored-by: ninaiiad <nina@gattaca.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com> Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

* PBS: Reload the config file when it changes (Commit-Boost#409) * ssv-network: SSV-node API support (Commit-Boost#415) Co-authored-by: Joe Clapis <jclapis@outlook.com> * fix(tests): update tests for SSV API rename and PbsState signature change (Commit-Boost#427) * Fix broken CLI caused by double-parse bug (Commit-Boost#428) Co-authored-by: Joe Clapis <jclapis@outlook.com> * Support custom chain ids (Commit-Boost#429) * Update README.md (Commit-Boost#436) * Unify the CLI, PBS, and Signer Binaries into One (Commit-Boost#425) Co-authored-by: Jason Vranek <jasonvranek@gmail.com> ClosesCommit-Boost#430, Commit-Boost#431, Commit-Boost#432 * add get_header auction winner log (Commit-Boost#443) * Sigp audit fixes (Commit-Boost#438) Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com> Co-authored-by: Joe Clapis <jclapis@outlook.com> Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> * fix deps from cherrypicking * Create v0.9.7-rc1.yml (Commit-Boost#463) * Feature/commit boost default image (Commit-Boost#464) --------- Co-authored-by: Joe Clapis <jclapis@outlook.com> Co-authored-by: iurii-ssv <183610124+iurii-ssv@users.noreply.github.com> Co-authored-by: Sergey Yakovlev <selfuryon@pm.me> Co-authored-by: Dominik Niedbała <dominikniedbala18@gmail.com> Co-authored-by: ninaiiad <nina@gattaca.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com> Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com> Co-authored-by: Joe Clapis <jclapis@outlook.com> Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

ManuelBilbaoand others added 30 commits July 27, 2025 22:13

CBST2-04: Update JWT secrets on reload and revoke module endpoint (#295)
5935659

Merge branch 'main' into sigp-audit-fixes
91f2cb4

Merge branch 'main' into sigp-audit-fixes
46e6f94

Merge branch 'main' into sigp-audit-fixes
b802fec

Merge branch 'main' into sigp-audit-fixes
151e811

CBST2-02: Make proposer commitment signatures unique to modules (#329)
498eed9
Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Splitrequest_signatureinto separate paths that return JSON (#350)
af13089
Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Add nonce and chain ID to signature requests (#354)
0ef8787
Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Merge branch 'main' into sigp-audit-fixes
ee18aa1

Mergemaintosigp-audit-fixes(#361)
6988444
Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

Merge branch 'sigp-audit-fixes' of github.com:Commit-Boost/commit-boo…
25bd5a6
…st-client into sigp-audit-fixes

Add payload hash to signer JWT claims (#356)
52aec57
Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Merge branch 'main' into sigp-audit-fixes
f2a275b

Add TLS to signer (#357)
6b14d77
Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Removed old dependency (#370)
eb61667

Merge main to sigp audit fixes (#371)
2dfe96b
Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

Fix misc findings from reaudit (#376)
d566dea
Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Added make to the build file
8ddb055

Merge branch 'main' into sigp-audit-fixes
9103b51

fix(signer): Mark a JWT failure if payload conversion fail (#387)
a3f8d9d

Merge branch 'sigp-audit-fixes' of github.com:Commit-Boost/commit-boo…
7bf2589
…st-client into sigp-audit-fixes

Removed a test that was deleted in main
b66f411

Merge branch 'main' into sigp-audit-fixes
b541ffa

Merge branch 'main' into sigp-audit-fixes
58b4eb9

refactor(signer): Use config-based header to extract IP from (#388)
e58d67e
Co-authored-by: Joe Clapis <jclapis@outlook.com>

fix(signer): introduce config to set the amount of trusted proxies in…
85382a5
… rightmost setup (#410)

fix(signer): rightmost header fixes (#420)
19121f3

Merge branch 'main' into sigp-audit-fixes
d4d5260

Merge branch 'main' into sigp-audit-fixes
02364f3

Merge branch 'main' into sigp-audit-fixes
533e4c0

address review comments
717390e

ninaiiad approved these changes Mar 24, 2026
View reviewed changes

ltitanb previously approved these changes Mar 25, 2026
View reviewed changes

Comment threadcrates/common/src/signature.rs

JasonVranek added 2 commits March 25, 2026 12:10

address Dirk issues in docker_init.rs:
04ae8b7
- add missing ADMIN_JWT_ENV and SIGNER_TLS_CERTIFICATES_PATH_ENV - support https healthchecks

cleaner error message if TLS CryptoProvider fails
6ec3782

JasonVranek dismissed ltitanb’s stale review via 6ec3782March 25, 2026 19:32

JasonVranek added 3 commits March 25, 2026 13:03

users get error message on missing [signer] section instead of toml d…
58b4b22
…eserialization error message

support partial jwt reloads
001b312

require the nonce in signer-api.yml - previously was marked optional …
76905de
…which conflicted with deserializing `SignConsensusRequest`

github-advanced-securityAI found potential problems Mar 25, 2026
View reviewed changes

Comment threadcrates/common/src/commit/request.rs Dismissed
Comment threadcrates/common/src/commit/request.rs Dismissed

JasonVranek added 5 commits March 25, 2026 15:43

fix suffix when displaying X-Forwaded-For
8268572

only take the jwt_auth_failures writelock if strictly necessary, de…
7c8cce6
…fault to readlock

remove mark_jwt_failure() calls from failures unrelated to jwts
4a9aff7

add round-trip sign->verify unit tests
d834242

Merge remote-tracking branch 'upstream/main' into sigp-audit-fixes
a9a5c11

ninaiiad previously requested changes Apr 7, 2026
View reviewed changes

Comment threadcrates/signer/src/service.rs
Comment threadcrates/signer/src/service.rs Outdated

ManuelBilbao reviewed Apr 7, 2026
View reviewed changes

Comment threadcrates/common/Cargo.toml Outdated
Comment threaddocs/docs/get_started/configuration.md Outdated
Comment threadcrates/common/src/signer/schemes/ecdsa.rs Outdated
Comment threadcrates/signer/src/manager/dirk.rs
Comment threadcrates/signer/src/service.rs

address comments. /reload now allows new module jwts without a full r…
2c3efde
…estart

ninaiiad reviewed Apr 10, 2026
View reviewed changes

Comment threadcrates/signer/src/service.rs
Comment threadcrates/signer/src/service.rs

ltitanb approved these changes Apr 10, 2026
View reviewed changes

ManuelBilbao approved these changes Apr 10, 2026
View reviewed changes

JasonVranek merged commit 77f11ec into mainApr 10, 2026
6 checks passed

JasonVranek deleted the sigp-audit-fixes branch April 10, 2026 21:45

JasonVranek mentioned this pull request Apr 22, 2026
Revert/pre 0.9.3 cleanup #453
Merged

Navigation Menu

Uh oh!

Sigp audit fixes - #438

Sigp audit fixes#438
JasonVranek merged 47 commits into
mainfrom
sigp-audit-fixes

JasonVranek commented Mar 19, 2026•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

JasonVranek commented Mar 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JasonVranek commented Mar 19, 2026•
edited
Loading