Improve mobile details, form errors, nav restore, and request IDs - #762
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@miss-yusrah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #680
closes #681
closes #678
closes #686
#680 — Improve Mobile Event Detail Layout
EventCardshortens long contract addresses, tx hashes, and event IDs, keeps full values available via title + copy actions, and wraps payload/value text so narrow viewports do not scroll horizontally.NotificationDetailsDraweradds a payload section with copy support and stacks row layout on small screens so labels, values, and actions stay usable.min-width: 0,overflow-wrap, sticky-accessible copy/close controls).#681 — Add Responsive Navigation State Restoration
useMediaQuery/useIsMobileNav(aligned to the dashboard 768px hamburger breakpoint).Appcloses the mobile nav drawer when the viewport crosses into desktop layout so overlay, body scroll lock, and focus-trap state cannot linger after resize.#678 — Improve Form Error Messaging
FormField/FormInput/FormSelect/FormTextareahelpers with:aria-invalid+aria-describedbywiringrole="alert"error text and a non-colour invalid indicator (icon + left accent border)#686 — Add Request ID Middleware
listener/src/middleware/request-id.tsand enhancesapplyRequestContextto:X-Request-Idbefore reuse ([\w.:-]{8,128})X-Request-Id/X-Correlation-Idon responsesX-Request-Idin CORS, and exposes request/correlation/response-time headers to browsers.Test plan
aria-invalid, and non-colour invalid stylingX-Request-Id; confirm response header and logs use reused vs minted ids appropriatelydashboardtests for FormField, EventCard, NotificationDetailsDrawer, useMediaQuery, NotificationTimelineViewlistenertests forrequest-idutils/middleware