Skip to content

Use lib199 with compliant names for sim devices and data. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettle merged 5 commits into from
Jun 20, 2024
Merged

Use lib199 with compliant names for sim devices and data. #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5d8181
Use lib199 with compliant names for sim devices and data.
brettle May 21, 2024
2a4b389
Bump lib199 commit hash to include latest commit on the compliance br…
brettle May 21, 2024
6f970d9
Merge remote-tracking branch 'origin/master' into fix-use-lib199-with…
brettle Jun 20, 2024
5a198cf
Bump lib199 version.
brettle Jun 20, 2024
85ae2c3
Revert unrelated formatting changes.
brettle Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ dependencies {
simulationRelease wpi.sim.enableRelease()

testImplementation 'org.junit.jupiter:junit-jupiter:5.10.1'
implementation "com.github.deepbluerobotics:lib199:3170c4433a775e90d6110334bc5658e573317ab6"
implementation "com.github.deepbluerobotics:lib199:400693b52180c82a1f26c08025bc12f144b930f9"
}

test {
Expand Down
17 changes: 9 additions & 8 deletions src/main/java/org/carlmontrobotics/subsystems/Arm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public class Arm extends SubsystemBase {
private ShuffleboardTab sysIdTab = Shuffleboard.getTab("arm SysID");
private boolean setPIDOff;

private SimDouble positionSim;
private SimDouble rotationsSim;

public Arm() {
// weird math stuff
Expand Down Expand Up @@ -162,8 +162,8 @@ public Arm() {
armProfile = new TrapezoidProfile(TRAP_CONSTRAINTS);
SmartDashboard.putBoolean("arm is at pos", false);
if (RobotBase.isSimulation()) {
positionSim = new SimDeviceSim("SparkMax[%d]_AbsoluteEncoder".formatted(ARM_MOTOR_PORT_MASTER))
.getDouble("Position");
rotationsSim = new SimDeviceSim("CANDutyCycle:CANSparkMax",
ARM_MOTOR_PORT_MASTER).getDouble("position");
}

}
Expand Down Expand Up @@ -469,11 +469,12 @@ public void setDefaultCommand(TeleopArm teleopArm, Object object) {

@Override
public void simulationPeriodic() {
// Fake goaling to the goal instantaneously
if (positionSim != null) {
positionSim.set((goalState.position - armMasterEncoder.getZeroOffset())
* (armMasterEncoder.getInverted() ? -1.0 : 1.0)
/ armMasterEncoder.getPositionConversionFactor() * MockedEncoder.NEO_BUILTIN_ENCODER_CPR);
// Fake going to the goal instantaneously
if (rotationsSim != null) {
rotationsSim
.set((goalState.position - armMasterEncoder.getZeroOffset())
* (armMasterEncoder.getInverted() ? -1.0 : 1.0)
/ armMasterEncoder.getPositionConversionFactor());
}
}
}