Use lib199 with compliant names for sim devices and data. - #68
Merged
Conversation
…-compliant-sim-names Also bump lib199 version.
brettle
marked this pull request as ready for review
June 20, 2024 21:34
brettle
enabled auto-merge
June 20, 2024 21:34
Merged
ProfessorAtomicManiac
approved these changes
Jun 20, 2024
ProfessorAtomicManiac
left a comment
Contributor
There was a problem hiding this comment.
I'm not familiar with the changes going on in lib199 regarding sim, but I don't see anything that could break if you are just changing the names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll make this ready for review after lib199 PR #94 is merged.