Uh oh!
There was an error while loading. Please reload this page.
fix(rp2040): encode complete firmware at XIP address - #1046
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR documents FastLED/boards as the authoritative USB VID/PID source and revises fixture refresh guidance. It also changes RP2040 UF2 full-image encoding to use the XIP address base and adds coverage for boot2-prefixed firmware. ChangesUSB VID/PID source documentation
RP2040 UF2 full-image encoding
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Correct the RP2040 UF2 base for fbuild's complete firmware.bin. The image includes boot2 at 0x10000000; 0x2000 is only valid for app-only BINs. Add a boot2-prefix regression test and document the FastLED/boards-only VID/PID policy. Closes the incorrect-address portion of #1040; do not claim hardware acceptance until a real 2E8A:000A CDC endpoint is observed.
Summary by CodeRabbit
Bug Fixes
Documentation