Uh oh!
There was an error while loading. Please reload this page.
feat(rp2040): support RAM-only UF2 loads - #1072
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRP2040 deployment now validates UF2 images as flash or RAM targets. RAM images produce a ChangesRP2040 RAM deployment
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DeployMethod
participant prepare_uf2_artifact
participant validate_uf2
participant CDC_Runtime
DeployMethod->>prepare_uf2_artifact: prepare UF2 artifact
prepare_uf2_artifact->>validate_uf2: validate and classify UF2
validate_uf2-->>prepare_uf2_artifact: Uf2Target::Ram or Uf2Target::Flash
prepare_uf2_artifact-->>DeployMethod: artifact and target
DeployMethod->>DeployMethod: return RamLoad for RAM target
DeployMethod->>CDC_Runtime: discover or recover runtime port for flash target
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Why
The attached Pico 1 already enters ROM USB, but every flash UF2 stalls on the first erase/program. Raspberry Pi's boot ROM supports RAM UF2 independently of QSPI, making it the decisive transport-vs-flash discriminator.
Validation
Supports #1049.
Summary by CodeRabbit
New Features
Bug Fixes