Uh oh!
There was an error while loading. Please reload this page.
fix(rp2040): match upstream UF2 deploy semantics - #1050
Conversation
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
📝 WalkthroughWalkthroughRP2040/RP2350 builds now generate managed UF2 artifacts, deployment validates BOOTSEL transfers and CDC recovery, and Raspberry Pi identity matching uses catalogue metadata. Packaging now stages and ships both the CLI and daemon binaries. ChangesRP2040 deployment and identity
CLI and daemon packaging
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes#1049
Progresses #1040
Related: FastLED/FastLED#3626
Summary
firmware.uf2from ELF with a SHA-256-pinned, framework-managed pqt-picotool on Windows/Linux/macOSNEW.UF2, validate family/block/address structure, wait for ROM-volume ejection, and classify only device-disappearance copy races as acceptedValidation
soldr cargo test -p fbuild-deploy rp2040 --lib(13 passed)soldr cargo test -p fbuild-daemon deploy_port --lib(7 passed)ruff check setup.pyandpython -m py_compile setup.pytests/platform/rp2040emitted a 166,400-byte, 325-block RP2040 UF2 with familyE48BFF56Hardware status
The attached Pico is still enumerated as stock
2E8A:0003/RPI-RP2, but Windows reports the current virtual FAT mount asWarning / Full Repair Neededafter earlier failed uploader experiments. No corrupted-mount result is claimed as acceptance evidence. Fresh reconnect plus CDC/JSON-RPC/soak remains the closeout gate on parent #1040.Summary by CodeRabbit
New Features
Bug Fixes
Documentation