Skip to content

Bump @metamask/eth-keyring-controller - #3617

Merged
mikesposito merged 1 commit into
mainfrom
chore/update-eth-keyring-controller
Dec 6, 2023
Merged

Bump @metamask/eth-keyring-controller#3617
mikesposito merged 1 commit into
mainfrom
chore/update-eth-keyring-controller

Conversation

@mikesposito

@mikespositomikesposito commented Dec 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Explanation

This PR bumps @metamask/eth-keyring-controller minimum version to ^15.1.0.

To adapt unit tests, and to align the two packages, the MockEncryptor has been ported from @metamask/eth-keyring-controller

References

n/a

Changelog

@metamask/keyring-controller

  • CHANGED: Bump @metamask/eth-keyring-controller to ^15.1.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security

socket-securityBot commented Dec 5, 2023

Copy link
Copy Markdown

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
@metamask/eth-keyring-controller15.0.0...15.1.0None+2/-2267 kBgudahtt

@socket-security

socket-securityBot commented Dec 5, 2023•
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/eth-keyring-controller@15.1.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    @mikesposito
    mikespositoforce-pushed the chore/update-eth-keyring-controller branch from cbf36ee to 35d02c7CompareDecember 5, 2023 13:55
    @mikesposito

    mikesposito commented Dec 5, 2023

    Copy link
    Copy Markdown
    MemberAuthor
    @SocketSecurity ignore @metamask/eth-keyring-controller@15.1.0

    This is our package

    @mikesposito
    mikesposito marked this pull request as ready for review December 5, 2023 14:01
    @mikesposito
    mikesposito requested a review from a team as a code ownerDecember 5, 2023 14:01
    @mikespositomikesposito changed the title chore: update eth-keyring-controllerBump @metamask/eth-keyring-controllerDec 5, 2023
    @danrocdanroc mentioned this pull request Dec 6, 2023
    Merged
    6 tasks
    @mikesposito

    mikesposito commented Dec 6, 2023

    Copy link
    Copy Markdown
    MemberAuthor
    @SocketSecurity ignore shiki@0.14.5

    Version currently used is 0.14.4, not affected by the Network access risk

    @mikesposito
    mikespositoforce-pushed the chore/update-eth-keyring-controller branch from 35d02c7 to 19d1024CompareDecember 6, 2023 09:25
    @mikesposito
    mikesposito merged commit 1b60d47 into mainDec 6, 2023
    @mikesposito
    mikesposito deleted the chore/update-eth-keyring-controller branch December 6, 2023 09:28
    danroc added a commit that referenced this pull request Jan 22, 2024
    @danroc
    feat: add methods to support ERC-4337 accounts (#3602)
    8a79dc5
    ## Description
**Depends on:**
- [x] <MetaMask/keyring-api#213>
- [x] <MetaMask/KeyringController#315>
- [x] <#3617>
This PR adds the following new methods available in the `EthKeyring`
interface:
- `prepareUserOperation`
- `patchUserOperation`
- `signUserOperation`
See the [PR](MetaMask/keyring-api#213) in the
`keyring-api` for more details.
## Checklist
- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation for new or updated code as appropriate
(note: this will usually be JSDoc)
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @danrocdanrocdanroc approved these changes

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @mikesposito@danroc