Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 7, 2024. It is now read-only.
feat: add support for ERC-4337 accounts - #213
Merged
Merged
Conversation
danrocforce-pushed
the
feature/erc-4337-support
branch
from
December 1, 2023 09:54
8b392ff to
8ffd019Comparedanrocforce-pushed
the
feature/erc-4337-support
branch
from
December 1, 2023 09:55
8ffd019 to
7cd842dCompare1 task
danrocforce-pushed
the
feature/erc-4337-support
branch
from
December 1, 2023 10:01
7cd842d to
94b46dbComparedanrocforce-pushed
the
feature/erc-4337-support
branch
from
December 1, 2023 10:05
94b46db to
67ffc9aCompare
This was referenced Dec 1, 2023
gantunesr
previously approved these changes
Dec 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
danrocforce-pushed
the
feature/erc-4337-support
branch
from
December 5, 2023 14:21
6dcec41 to
6741d22Comparegantunesr
approved these changes
Dec 6, 2023
legobeat added a commit
that referenced
this pull request
Dec 6, 2023
legobeat added a commit
that referenced
this pull request
Dec 6, 2023
danroc pushed a commit
that referenced
this pull request
Dec 7, 2023
danroc pushed a commit
that referenced
this pull request
Dec 7, 2023
danroc added a commit
to MetaMask/core
that referenced
this pull request
Jan 22, 2024
## Description **Depends on:** - [x] <MetaMask/keyring-api#213> - [x] <MetaMask/KeyringController#315> - [x] <#3617> This PR adds the following new methods available in the `EthKeyring` interface: - `prepareUserOperation` - `patchUserOperation` - `signUserOperation` See the [PR](MetaMask/keyring-api#213) in the `keyring-api` for more details. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc) - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to ERC-4337 accounts. These new accounts should implement the following signing flow:
Changes
This PR adds a new
EthKeyringinterface to be used internally by MetaMask.It also adds the follwoing methods that are required to implement the flow described above:
prepareUserOperationpatchUserOperationsignUserOperation