Skip to content

Update tests to close buffers. - #1096

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
Andy-Jost:ipc-mempool
Oct 8, 2025
Merged

Update tests to close buffers.#1096
leofang merged 2 commits into
NVIDIA:mainfrom
Andy-Jost:ipc-mempool

Conversation

@Andy-Jost

@Andy-JostAndy-Jost commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Update the memory_ipc tests to explicitly call close on buffers.

@copy-pr-bot

copy-pr-botBot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Andy-Jost

Andy-Jost commented Oct 7, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test bb12ac9

Andy-Jost
Andy-Jost commented Oct 7, 2025
View reviewed changes
Comment threadcuda_core/tests/memory_ipc/test_serialize.py
@github-actions

github-actionsBot commented Oct 7, 2025

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-1096/

https://nvidia.github.io/cuda-python/pr-preview/pr-1096/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-1096/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-1096/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@leofangleofang added P1 Medium priority - Should do test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Oct 7, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Oct 7, 2025
@leofangleofang added triage Needs the team's attention and removed P1 Medium priority - Should do labels Oct 7, 2025
@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
Member

/ok to test 40f2bf2

@leofangleofang added P1 Medium priority - Should do and removed triage Needs the team's attention labels Oct 8, 2025
@leofang
leofang merged commit 75aea80 into NVIDIA:mainOct 8, 2025
72 checks passed
@Andy-Jost
Andy-Jost deleted the ipc-mempool branch October 27, 2025 17:46
github-actionsBot pushed a commit that referenced this pull request Nov 10, 2025
cuda-python-bot
Clean up PR preview folders for 61 closed/merged PRs
6fc9084
Removed preview folders for the following PRs:
- PR #1021
- PR #1034
- PR #1052
- PR #1059
- PR #1069
- PR #1086
- PR #1090
- PR #1096
- PR #1102
- PR #1103
- PR #1106
- PR #1107
- PR #1117
- PR #1133
- PR #1140
- PR #1166
- PR #1174
- PR #1185
- PR #1188
- PR #1191
... and 41 more
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes
@cpcloudcpcloudAwaiting requested review from cpcloud
@rparolinrparolinAwaiting requested review from rparolin
@kkraus14kkraus14Awaiting requested review from kkraus14

Assignees

@Andy-JostAndy-Jost

Labels

cuda.coreEverything related to the cuda.core moduleP1Medium priority - Should dotestImprovements or additions to tests

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

2 participants

@Andy-Jost@leofang