Skip to content

[Backport] Remove versioneer - #355

Merged
vzhurba01 merged 7 commits into
NVIDIA:11.8.xfrom
leofang:backport-307-to-11.8.x
Jan 10, 2025
Merged

[Backport] Remove versioneer#355
vzhurba01 merged 7 commits into
NVIDIA:11.8.xfrom
leofang:backport-307-to-11.8.x

Conversation

@leofang

@leofangleofang commented Jan 5, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Manually backported to resolve conflicts following #307 (comment). Backporting is needed in order to build wheels from the CI (#233 (comment)).

@leofang
leofang requested a review from vzhurba01January 5, 2025 01:33
@leofangleofang self-assigned this Jan 5, 2025
@copy-pr-bot

copy-pr-botBot commented Jan 5, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

leofang
leofang commented Jan 5, 2025
View reviewed changes
Comment threadcuda_bindings/cuda/bindings/_version.py Outdated
@leofangleofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages and removed P1 Medium priority - Should do labels Jan 5, 2025
@leofang

leofang commented Jan 5, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 5, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 8, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 8, 2025

Copy link
Copy Markdown
MemberAuthor

This is ready to review/merge.

@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@vzhurba01vzhurba01 mentioned this pull request Jan 10, 2025
Merged
@vzhurba01
vzhurba01 merged commit 1f01b00 into NVIDIA:11.8.xJan 10, 2025
@leofang
leofang deleted the backport-307-to-11.8.x branch January 10, 2025 18:51
@vzhurba01vzhurba01 mentioned this pull request Jan 10, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vzhurba01vzhurba01vzhurba01 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

Labels

cuda.bindingsEverything related to the cuda.bindings moduleenhancementAny code-related improvementsP0High priority - Must do!packagingAnything related to wheels or Conda packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang@vzhurba01