Skip to content

Test against CUDA wheels - #368

Merged
leofang merged 4 commits into
NVIDIA:mainfrom
leofang:wheel_test
Jan 12, 2025
Merged

Test against CUDA wheels#368
leofang merged 4 commits into
NVIDIA:mainfrom
leofang:wheel_test

Conversation

@leofang

@leofangleofang commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Close#367.

For detail see #368 (comment) below.

@leofangleofang self-assigned this Jan 9, 2025
@copy-pr-bot

copy-pr-botBot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofangleofang added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! and removed cuda.bindings Everything related to the cuda.bindings module labels Jan 9, 2025
@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

1 similar comment
@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

2 similar comments
@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Note: 11.8 + CTK wheels tests fail because we have not yet backported the [all] support (#363 (comment)).

This was referenced Jan 9, 2025
Merged
Merged
@leofang

leofang commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This PR is ready for review. Most of the commits are coming from #357, so it should be merged first.

After that, this PR will only have 2 commits:

  • 5015410: make the test job a standalone reusable workflow, to avoid increasing the length of the CI file (because we'll add more jobs to it later)
  • 7f36568: This adds a new local_ctk axis to the test matrix that choose between local CTK (provided by the mini ctk action) or CTK wheels

@leofangleofang changed the title WIP: Add wheel-based test workflow Test against CUDA wheelsJan 9, 2025
@leofangleofang added the to-be-backported Trigger the bot to raise a backport PR upon merge label Jan 9, 2025
@leofang
leofang marked this pull request as ready for review January 9, 2025 21:39
@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
MemberAuthor

@vzhurba01 sorry for the noise elsewhere. Could you check the cuda.core test failure? I confirm that the CI fetches the correct wheel from the 11.8.x (run_id 12695861564, see log), and the nvrtc wheel is correctly installed, but we still hit dlopen or nvrtcVersion not found errors...

@leofang

leofang commented Jan 10, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I noticed that unlike in the main branch, the linker flag --disable-new-dtags for RPATH hack was not showing up in the 11.8.x branch...
https://github.com/NVIDIA/cuda-python/actions/runs/12695861564/job/35388691369#step:9:844

@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
MemberAuthor

I found why: https://github.com/NVIDIA/cuda-python/pull/369/files#r1909708344

@vzhurba01

vzhurba01 commented Jan 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

#355

Backport of above should resolve that bug.

Edit: Also needed #376

@vzhurba01

vzhurba01 commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

/ok to test

@leofangleofang closed this Jan 10, 2025
@leofangleofang reopened this Jan 10, 2025
@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
MemberAuthor

#376 fixed it! This is ready now.

@leofangleofang mentioned this pull request Jan 11, 2025
Merged
@leofang

This comment was marked as outdated.

Sign in to view
@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Jan 12, 2025

Copy link
Copy Markdown
MemberAuthor

Since this is not touching the main source code, only CI, and all jobs have passed, let me admin-merge to get the Ci infra works completed. Backport PR is in #378.

@leofang
leofang merged commit 57a710a into NVIDIA:mainJan 12, 2025
@leofang
leofang deleted the wheel_test branch January 12, 2025 19:26
@github-actions

github-actionsBot commented Jan 12, 2025

Copy link
Copy Markdown

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keenan-simpsonkeenan-simpsonAwaiting requested review from keenan-simpson
@vzhurba01vzhurba01Awaiting requested review from vzhurba01

Assignees

@leofangleofang

Labels

CI/CDCI/CD infrastructureP0High priority - Must do!to-be-backportedTrigger the bot to raise a backport PR upon merge

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

CI: Add a new test axis to test against CUDA wheels

2 participants

@leofang@vzhurba01