Skip to content

[Backport] Enable discovery and loading at run time of NVRTC and nvJitLink libraries in a wheels ecosystem - #369

Merged
vzhurba01 merged 3 commits into
NVIDIA:11.8.xfrom
vzhurba01:backport-363-to-11.8.x
Jan 9, 2025
Merged

[Backport] Enable discovery and loading at run time of NVRTC and nvJitLink libraries in a wheels ecosystem#369
vzhurba01 merged 3 commits into
NVIDIA:11.8.xfrom
vzhurba01:backport-363-to-11.8.x

Conversation

@vzhurba01

@vzhurba01vzhurba01 commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@vzhurba01
Support discovery of nvrtc libraries at run time
1f4d738
CTK installations distribute their libraries using personal packages:
- nvidia-cuda-nvrtc-cuXX
The relative path of their libraries to cuda-bindings is consistent,
and allows us to use relative paths to discover them when loading
at run time.
@vzhurba01
Fix check
d4ad29f
@vzhurba01vzhurba01 added enhancement Any code-related improvements P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module labels Jan 9, 2025
@vzhurba01vzhurba01 self-assigned this Jan 9, 2025
@copy-pr-bot

copy-pr-botBot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01

vzhurba01 commented Jan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofangleofang mentioned this pull request Jan 9, 2025
Merged
leofang
leofang approved these changes Jan 9, 2025
View reviewed changes
Comment threadcuda_bindings/setup.py Outdated
@leofang

leofang commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown
Member

I'll backport #368 once it's merged. We should get this PR merged first to make it green.

@vzhurba01@leofang
Update cuda_bindings/setup.py
9f13a17
Co-authored-by: Leo Fang <leo80042@gmail.com>
@vzhurba01
vzhurba01 merged commit a20f0f4 into NVIDIA:11.8.xJan 9, 2025
@vzhurba01

vzhurba01 commented Jan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Merging. Thanks!

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
Member

All tests failed? https://github.com/NVIDIA/cuda-python/actions/runs/12695755926

@leofangleofang mentioned this pull request Jan 10, 2025
Merged
leofang
leofang reviewed Jan 10, 2025
View reviewed changes
Comment threadcuda_bindings/setup.py
@leofangleofang changed the title Backport 363 to 11.8.x[Backport] Enable discovery and loading at run time of NVRTC and nvJitLink libraries in a wheels ecosystemJan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes

Assignees

@vzhurba01vzhurba01

Labels

cuda.bindingsEverything related to the cuda.bindings moduleenhancementAny code-related improvementsP0High priority - Must do!packagingAnything related to wheels or Conda packages

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

2 participants

@vzhurba01@leofang