Uh oh!
There was an error while loading. Please reload this page.
ci: python 3.13 free threading builds - #986
Conversation
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cpcloud
commented
Sep 18, 2025
/ok to test |
2 similar comments
cpcloud
commented
Sep 18, 2025
/ok to test |
cpcloud
commented
Sep 18, 2025
/ok to test |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
This requires cuda-bindings 12.9.x to be rebuilt and merged first
There was a problem hiding this comment.
Ok, what needs to happen for that?
There was a problem hiding this comment.
Have a backport version of this PR merged first, as implied by our new shiny CI doc we fetch the 12.x wheels from the 12.9.x branch.
There was a problem hiding this comment.
Ok, I'll leave it out for now then.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b2a70a7 to
48ea7d4Comparecpcloud
commented
Sep 19, 2025
/ok to test |
This comment has been minimized.
This comment has been minimized.
cpcloud
commented
Sep 19, 2025
Looks like I am probably missing a comma in some JSON. That's what I get for copypasta-ing! |
Uh oh!
There was an error while loading. Please reload this page.
cpcloud
commented
Sep 19, 2025
/ok to test |
cpcloud
commented
Sep 19, 2025
Tests are currently not able to run because Unfortunately there's also no way to get that metadata at build time (see https://packaging.python.org/en/latest/specifications/dependency-specifiers/#dependency-specifiers for what's available. I tried them all, and saw nothing that indicated whether a build was a FT build). I'll have to come up with a WAR to skip installation of that dependency. |
…testing the FT builds
de5815a to
96ee1c2Comparecpcloud
commented
Sep 19, 2025
/ok to test |
cpcloud
commented
Sep 19, 2025
Ah, I need to edit the build matrix I think. |
cpcloud
commented
Sep 19, 2025
/ok to test |
leofang
commented
Sep 19, 2025
Thanks, Phillip! Code-wise LGTM! A few questions on the next steps you have in mind:
|
cpcloud
commented
Sep 19, 2025
Will do each of those in a separate PR! |
leofang
left a comment
There was a problem hiding this comment.
Sounds good, thanks! We also need to backport this.
cpcloud
commented
Sep 19, 2025
Ok, I will get started on the backport then. Merging. |
Uh oh!
There was an error while loading. Please reload this page.
|
Closes#132. Add CI wheel builds and test matrix entries for free-threaded builds.