Skip to content

ci: python 3.13 free threading builds - #986

Merged
cpcloud merged 10 commits into
NVIDIA:mainfrom
cpcloud:free-threading-builds
Sep 19, 2025
Merged

ci: python 3.13 free threading builds#986
cpcloud merged 10 commits into
NVIDIA:mainfrom
cpcloud:free-threading-builds

Conversation

@cpcloud

Copy link
Copy Markdown
Contributor

Closes#132. Add CI wheel builds and test matrix entries for free-threaded builds.

@copy-pr-bot

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

/ok to test

2 similar comments
@cpcloud

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

/ok to test

Comment thread.github/workflows/build-wheel.yml Outdated
Comment thread.github/workflows/build-wheel.yml Outdated
Comment threadci/test-matrix.json Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires cuda-bindings 12.9.x to be rebuilt and merged first

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, what needs to happen for that?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a backport version of this PR merged first, as implied by our new shiny CI doc we fetch the 12.x wheels from the 12.9.x branch.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll leave it out for now then.

Comment threadci/tools/env-vars Outdated
Comment threadcuda_bindings/pyproject.toml Outdated
@leofangleofang added P0 High priority - Must do! CI/CD CI/CD infrastructure packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Sep 19, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Sep 19, 2025
@cpcloud
cpcloudforce-pushed the free-threading-builds branch from b2a70a7 to 48ea7d4CompareSeptember 19, 2025 13:22
@cpcloud

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloudcpcloud changed the title free threading buildsci(python): free threading buildsSep 19, 2025
@cpcloudcpcloud changed the title ci(python): free threading buildsci: free threading buildsSep 19, 2025
@cpcloudcpcloud changed the title ci: free threading buildsci: python 3.13 free threading buildsSep 19, 2025
@github-actions

This comment has been minimized.

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

Looks like I am probably missing a comma in some JSON. That's what I get for copypasta-ing!

Comment threadci/test-matrix.json Outdated
@cpcloud

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

Tests are currently not able to run because test-cu13 cannot be installed, because there's no cupy package available for free-threading builds.

Unfortunately there's also no way to get that metadata at build time (see https://packaging.python.org/en/latest/specifications/dependency-specifiers/#dependency-specifiers for what's available. I tried them all, and saw nothing that indicated whether a build was a FT build).

I'll have to come up with a WAR to skip installation of that dependency.

@cpcloud
cpcloudforce-pushed the free-threading-builds branch from de5815a to 96ee1c2CompareSeptember 19, 2025 16:25
@cpcloud

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

Ah, I need to edit the build matrix I think.

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofang

Copy link
Copy Markdown
Member

Thanks, Phillip! Code-wise LGTM! A few questions on the next steps you have in mind:

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

Will do each of those in a separate PR!

@leofangleofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks! We also need to backport this.

@cpcloud

Copy link
Copy Markdown
ContributorAuthor

Ok, I will get started on the backport then. Merging.

@cpcloud
cpcloud merged commit c4f4ffe into NVIDIA:mainSep 19, 2025
56 checks passed
@cpcloud
cpcloud deleted the free-threading-builds branch September 19, 2025 18:52
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

leofang added a commit to leofang/cuda-python that referenced this pull request Sep 29, 2025
cpcloud pushed a commit that referenced this pull request Sep 29, 2025
* backport PR #986
* backport PR #1005
@cpcloudcpcloud mentioned this pull request Oct 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CDCI/CD infrastructurecuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core moduleP0High priority - Must do!packagingAnything related to wheels or Conda packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a build/release process to support 2 build flavors

2 participants

@cpcloud@leofang