refactor: document windows handling + scene tree features by iMeaNz · Pull Request #155 · NexoEngine/game-engine

iMeaNz · 2025-03-25T21:13:41Z

No description provided.

coderabbitai · 2025-03-25T21:13:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

+
+        // Get the bounding box and draw centered text
+        auto [p_min, p_max] = utils::getItemRect();
+        ImVec2 textPos = utils::calculateCenteredTextPosition(headerText.data(), p_min, p_max);


iMeaNz · 2025-05-04T13:17:59Z

@coderabbitai summary

coderabbitai · 2025-05-04T13:18:04Z

✅ Actions performed

Summary regeneration triggered.

…n amount of logs, they get flushed in the file to better handle memory usage

… level + fix windows compilation

…ctor into multiple source file

…rce file

…rtcuts creation

…does not process inputs anymore

… creating

…eation

…rtcut

…is not docked

…era controller

…unction of the engine for different scene props

…nt size via a beginRender function that also handles the docking update and visibility update

… setup

…d on the size of the image drawn

…erly handle the mouse projection

…orld for grid hightlight

…in bounding box

iMeaNz · 2025-05-04T14:08:34Z

Overview

This PR delivers a comprehensive overhaul of the editor’s Document Windows subsystem along with enhancements to the Scene Tree view. It modularizes windows into standalone components, centralizes rendering logic, and enriches user interactions through robust undo/redo, shortcut handling, and improved camera/viewport synchronization.

Code Organization

Modularization: Split monolithic windows into dedicated classes/files
Unified Render Entry: Introduced beginRender() to centralize window position/size handling, docking updates, and visibility state .
SceneInfo Struct: Added SceneInfo to encapsulate parameters passed to the engine’s run function for each scene

State Management (Memento & Undo/Redo)

Memento Pattern: Incorporated save/restore via Memento for component windows
Action Management: Built a centralized action manager and integrated undo/redo stacks

Input & Shortcut Handling

Shortcut Infrastructure: Laid groundwork for input mapping
Core Shortcuts:
- Gizmo controls: axis press-to-show, on-release callback, exclude-axis, switch local/global
- Transform tools: delete, snapping, key-repeat, multi-selection, hide shortcuts
- Helper UI: bottom-bar shortcut helper display

Shader & Edge Detection

Flat Color Shader: Added basic flat-color shader support
Post-Processing Outline: Moved outline rendering to a post-processing pass using concentric-ring edge detection combined with a mask framebuffer
Uniform Extensions: Introduced support for float2 and bool uniforms in window shaders

Camera & Viewport Improvements

Adjustable translation speed
Ignoring mouse-key inputs correctly
Quaternion-only rotation
Scene Creation & Switching Fixes: Resolved camera blip on cancel, creation glitches, and switching issues

Viewport Sync & Projection:

Align ImGui viewport with the scene viewport
Correct gizmo rect and grid-highlight world projection

Scene Tree Enhancements

Shortcuts & Popups:
- Added expand/collapse
- Entity-creation popup in the tree
- Dedicated shortcuts for scene-tree navigation

Miscellaneous Fixes & Chores

Filtering & Rendering: Corrected texture mag filter to linear
Code Cleanup: Moved function implementations to source files, refactored shortcut builders, updated comments for clarity.

iMeaNz self-assigned this Mar 25, 2025

iMeaNz added this to Global timeline Mar 25, 2025

github-project-automation Bot moved this to Todo in Global timeline Mar 25, 2025

iMeaNz linked an issue Apr 15, 2025 that may be closed by this pull request

fix: strange padding in the console with certain logs #202

Closed

1 task

iMeaNz force-pushed the refactor/document-windows branch from 51fe844 to 08e0c00 Compare April 15, 2025 11:05

This was linked to issues Apr 15, 2025

Scene renaming functionality no longer works #191

Closed

bug: entity deletion from scene tree does not work #206

Closed

github-advanced-security AI found potential problems Apr 18, 2025

View reviewed changes

iMeaNz added 12 commits May 4, 2025 22:37

init(document-windows): init branch

dc949e9

fix(document-windows): imgui demo dont show up anymore

2f153d0

refactor(document-windows): now use std::any for sub inspector data

f7775d2

docs(documents-windows): update docstring for getSubInspectorData

adc830a

feat(document-windows): add new user log level

4bf04b8

feat(document-windows): add new utils function to open the file explorer

bb3ef2c

feat(document-windows): add a log file system, when reaching a certai…

b40e7a0

…n amount of logs, they get flushed in the file to better handle memory usage

chore(document-windows): add source files

cb5e7db

fix(document-windows): now properly computes the padding based on the…

b649803

… level + fix windows compilation

fix(document-windows): trying to fix windows

5fdd501

fix(document-windows): trying to fix again

03a55d6

fix(document-windows): trying to fix windows again

4e5da49

iMeaNz added 24 commits May 4, 2025 22:37

refactor(document-windows): split inspector window and material inspe…

44276d1

…ctor into multiple source file

refactor(document-windows): split scene tree window into multiple sou…

91cbdaa

…rce file

refactor(document-windows): now using builder pattern for command sbo…

9addf14

…rtcuts creation

feat(document-windows): add str uid for bottom bar

017c48b

refactor(document-windows): split into multiple method + fix: bottom …

8001e20

…does not process inputs anymore

feat(document-windows): add shortcuts for scene tree window

b03c95d

fix(document-windows): viewport now correspond to scene viewport when…

c2e1880

… creating

fix(document-windows): fix strange blip when cancelling the camera cr…

225a0ae

…eation

refactor(document-windows): add entity is now handled via a popup

230a8a2

feat(document-windows): add expand/collapse shortcut + add entity sho…

19f698a

…rtcut

fix(document-windows): fix camera not working when creating scene

66bf660

fix(document-windows): add export compile commands for zed editor

58c4554

refactor(document-windows): add a check for window visiblity when it …

bb10683

…is not docked

fix(document-windows): camera not moving when switching scene

5b6eec2

chore(document-windows): add source files

fbd4559

fix(document-windows): now only using quat from the transfrom for cam…

27bacea

…era controller

refactor(document-windows): add SceneInfo struct to pass to the run f…

cc43cd6

…unction of the engine for different scene props

refactor(document-windows): centralized the window pos/size and conte…

b398870

…nt size via a beginRender function that also handles the docking update and visibility update

fix(document-windows): now use the viewport bounds for the gizmo rect…

9ccce74

… setup

fix(document-windows): now properly retrieve the viewport bounds base…

5ce7f82

…d on the size of the image drawn

fix(document-windows): now pass viewport bounds to the engine to prop…

56916f4

…erly handle the mouse projection

fix(document-windows): properly project the mouse position into the w…

f3fcdb3

…orld for grid hightlight

feat(document-windows): add utils function to check if 2D pos is with…

7064c19

…in bounding box

fix(document-windows): add header include for msvc

f184c4d

iMeaNz force-pushed the refactor/document-windows branch from 395de30 to f184c4d Compare May 4, 2025 14:00

iMeaNz marked this pull request as ready for review May 4, 2025 14:43

iMeaNz merged commit 256bb6c into dev May 4, 2025

github-project-automation Bot moved this from Todo to Done in Global timeline May 4, 2025

Thyodas deleted the refactor/document-windows branch July 23, 2025 17:39

Navigation Menu

refactor: document windows handling + scene tree features - #155

refactor: document windows handling + scene tree features#155
iMeaNz merged 160 commits into
devfrom
refactor/document-windows

iMeaNz commented Mar 25, 2025

Uh oh!

coderabbitai Bot commented Mar 25, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Check warning

iMeaNz commented May 4, 2025

Uh oh!

coderabbitai Bot commented May 4, 2025

Uh oh!

iMeaNz commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

iMeaNz commented Mar 25, 2025

Uh oh!

coderabbitai Bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Check warning

iMeaNz commented May 4, 2025

Uh oh!

coderabbitai Bot commented May 4, 2025

Uh oh!

iMeaNz commented May 4, 2025

Overview

Code Organization

State Management (Memento & Undo/Redo)

Input & Shortcut Handling

Shader & Edge Detection

Camera & Viewport Improvements

Viewport Sync & Projection:

Scene Tree Enhancements

Miscellaneous Fixes & Chores

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Mar 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)