Fix for randomized retry interval format by InigoGR · Pull Request #624 · OCA/queue

InigoGR · 2024-02-01T09:49:59Z

queue_job: fix retry format with tuple values

#348 added support for randomized retry intervals.
I could not set randomized retry intervals due to the formatting checks not being updated. This should fix it.

OCA-git-bot · 2024-02-01T09:50:09Z

Hi @guewen,
some modules you are maintaining are being modified, check this out!

simahawk

Thanks for your contrib!
I guess it failed because we didn't have specific tests, right?
Any chance you add that? If you don't have time that's fine, but it's a really nice to have if you can 😉

Also, could you please rewrite the commit msg to something like:

queue_job: fix retry format with tuple values
#348 added support for randomized retry intervals.
I could not set randomized retry intervals due to the formatting checks not being updated. This should fix it.

What changes:

includes module name
includes the full description of the issue

InigoGR · 2024-02-01T14:52:59Z

Thanks for your contrib! I guess it failed because we didn't have specific tests, right? Any chance you add that? If you don't have time that's fine, but it's a really nice to have if you can 😉
Also, could you please rewrite the commit msg to something like:
queue_job: fix retry format with tuple values
#348 added support for randomized retry intervals.
I could not set randomized retry intervals due to the formatting checks not being updated. This should fix it.
What changes:
includes module name
includes the full description of the issue

I will add test coverage for that case and change the commit message.

OCA#348 added support for randomized retry intervals. Configuration of randomized retry intervals is not possible due to the formatting checks not being updated. This should fix it.

InigoGR · 2024-02-05T09:03:48Z

Added some simple tests that should cover the changes in _check_retry_pattern and _parse_retry_pattern.

simahawk

Minor remark get a more clear exception. Pre-approving

simahawk · 2024-03-08T09:52:14Z

 except ValueError:
 raise exceptions.UserError(
 record._retry_pattern_format_error_message()
 )

+ def _retry_value_type_check(self, value):
+ if isinstance(value, (tuple, list)):
+ if len(value) != 2:
+ raise ValueError
+ [self._retry_value_type_check(element) for element in value]
+ return
+ int(value)


Suggested change
exceptValueError:
raiseexceptions.UserError(
record._retry_pattern_format_error_message()
)
def_retry_value_type_check(self, value):
ifisinstance(value, (tuple, list)):
iflen(value) !=2:
raiseValueError
[self._retry_value_type_check(element) forelementinvalue]
return
int(value)
exceptValueErrorasexc:
raiseexceptions.UserError(
record._retry_pattern_format_error_message()
)fromexc
def_retry_value_type_check(self, value):
ifisinstance(value, (tuple, list)):
iflen(value) !=2:
raiseValueError("Random retry pattern must be a tuple with 2 digits")
[self._retry_value_type_check(element) forelementinvalue]
return
int(value)

OCA-git-bot · 2024-03-08T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt · 2024-05-02T15:20:43Z

@simahawk Is this good to merge?

dreispt · 2024-05-18T18:09:18Z

/ocabot merge patch

OCA-git-bot · 2024-05-18T18:09:28Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-624-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot · 2024-05-18T18:13:55Z

Congratulations, your PR was merged at cf35a44. Thanks a lot for contributing to OCA. ❤️

InigoGR marked this pull request as draft February 1, 2024 10:00

InigoGR marked this pull request as ready for review February 1, 2024 10:22

simahawk requested changes Feb 1, 2024
View reviewed changes

Comment threadqueue_job/models/queue_job_function.py

InigoGR marked this pull request as draft February 2, 2024 09:20

InigoGR force-pushed the retry-interval-format-fix branch from c36faf2 to 193e5fcCompare February 5, 2024 08:51

queue_job: fix retry format with tuple values
9b7f427
OCA#348 added support for randomized retry intervals. Configuration of randomized retry intervals is not possible due to the formatting checks not being updated. This should fix it.

InigoGR force-pushed the retry-interval-format-fix branch from 193e5fc to 9b7f427Compare February 5, 2024 08:55

InigoGR marked this pull request as ready for review February 5, 2024 09:04

InigoGR requested a review from simahawk February 5, 2024 09:04

StefanRijnhart approved these changes Mar 7, 2024
View reviewed changes

simahawk approved these changes Mar 8, 2024
View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 8, 2024

amh-mw approved these changes May 2, 2024
View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 18, 2024

OCA-git-bot merged commit 7f55495 into OCA:14.0May 18, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 18, 2024

simahawk mentioned this pull request Oct 9, 2024
[18.0][MIG] queue_job: Migrate to 18.0 #692
Merged

This was referenced Dec 27, 2024
[16.0][UPD] Forward port changes from 14.0 and 15.0 #729
Merged
[15.0][UPD] Forward port changes from 14.0 #730
Closed

florentx mentioned this pull request Dec 27, 2024
[17.0][UPD] Forward port changes from 14/15/16 #731
Merged

Navigation Menu

Uh oh!

Uh oh!

Fix for randomized retry interval format - #624

Fix for randomized retry interval format#624
OCA-git-bot merged 1 commit into
OCA:14.0from
InigoGR:retry-interval-format-fix

InigoGR commented Feb 1, 2024•
edited
Loading

Uh oh!

OCA-git-bot commented Feb 1, 2024

Uh oh!

simahawk left a comment •
edited
Loading

Uh oh!

Uh oh!

InigoGR commented Feb 1, 2024

Uh oh!

InigoGR commented Feb 5, 2024

Uh oh!

simahawk left a comment

Uh oh!

simahawkMar 8, 2024

Uh oh!

OCA-git-bot commented Mar 8, 2024

Uh oh!

dreispt commented May 2, 2024

Uh oh!

dreispt commented May 18, 2024

Uh oh!

OCA-git-bot commented May 18, 2024

Uh oh!

OCA-git-bot commented May 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

-exceptValueError:
-raiseexceptions.UserError(
-record._retry_pattern_format_error_message()
- )
-def_retry_value_type_check(self, value):
-ifisinstance(value, (tuple, list)):
-iflen(value) !=2:
-raiseValueError
- [self._retry_value_type_check(element) forelementinvalue]
-return
-int(value)
+exceptValueErrorasexc:
+raiseexceptions.UserError(
+record._retry_pattern_format_error_message()
+ )fromexc
+def_retry_value_type_check(self, value):
+ifisinstance(value, (tuple, list)):
+iflen(value) !=2:
+raiseValueError("Random retry pattern must be a tuple with 2 digits")
+ [self._retry_value_type_check(element) forelementinvalue]
+return
+int(value)

Uh oh!

Uh oh!

Conversation

InigoGR commented Feb 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Feb 1, 2024

Uh oh!

simahawk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

InigoGR commented Feb 1, 2024

Uh oh!

InigoGR commented Feb 5, 2024

Uh oh!

simahawk left a comment

Choose a reason for hiding this comment

Uh oh!

simahawkMar 8, 2024

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 8, 2024

Uh oh!

dreispt commented May 2, 2024

Uh oh!

dreispt commented May 18, 2024

Uh oh!

OCA-git-bot commented May 18, 2024

Uh oh!

OCA-git-bot commented May 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

InigoGR commented Feb 1, 2024•
edited
Loading

simahawk left a comment •
edited
Loading