Skip to content

[14.0][REF] Clean-up for Python 3 - #728

Merged
OCA-git-bot merged 2 commits into
OCA:14.0from
florentx:14.0_python3
Jan 28, 2025
Merged

[14.0][REF] Clean-up for Python 3#728
OCA-git-bot merged 2 commits into
OCA:14.0from
florentx:14.0_python3

Conversation

@florentx

@florentxflorentx commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

This will be forward ported to branches 15.0+

  • [REF] remove explicit 'object' inheritance
  • [REF] remove explicit super() arguments

@OCA-git-bot

OCA-git-bot commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

This was referenced Dec 27, 2024
Merged
Closed
Merged
@trisdoan

trisdoan commented Dec 30, 2024

Copy link
Copy Markdown

Hello, for removing explicit super() arguments, I introduced an improvement in OCA/oca-addons-repo-template#288.

It automatically removes the argument when pre-commit runs (for branch 17.0+)

@OCA-git-bot

OCA-git-bot commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk

simahawk commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-728-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 81f6262. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
OCA-git-bot merged commit 24d9d2b into OCA:14.0Jan 28, 2025
@thienvh332thienvh332 mentioned this pull request Apr 14, 2025
Merged
@florentx
florentx deleted the 14.0_python3 branch May 8, 2025 11:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyirvalyirvalyi approved these changes
+2 more reviewers
@ivantodorovichivantodorovichivantodorovich approved these changes
@trisdoantrisdoantrisdoan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedmerged 🎉ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@florentx@OCA-git-bot@trisdoan@simahawk@rvalyi@ivantodorovich