[17.0][FIX] auto_backup: pin paramiko for compatibility with pysftp - #3345
Conversation
100ee68 to
8451bb7
Compare
paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537 ``` File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 9, in <module> import pysftp File "/home/odoo/.cache/pypoetry/virtualenvs/18-0-liVCuCj7-py3.12/lib/python3.12/site-packages/pysftp/__init__.py", line 14, in <module> from paramiko import AgentKey, RSAKey, DSSKey ImportError: cannot import name 'DSSKey' from 'paramiko' ``` The import error was dropped silently, making the error show up as ``` File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 28, in <module> class TestConnectionException(pysftp.ConnectionException): ^^^^^^ NameError: name 'pysftp' is not defined ```
8451bb7 to
549db84
Compare
|
This PR has the |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-3345-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@pedrobaeza Now, that issue was fixed by me in #3254 |
Don't run makepot using both Odoo and OCB. This is redundant, but also, because of changes between both versions, the POTs may have trivial differences. The commit of a makepot run will again trigger CI to run makepot with both versions, leading to an infinite loop of competing commits trying to revert each other's trivial differences. In the current case, the sms module is set to auto_install in Odoo but not in OCB. This causes the field `message_has_sms_error` from sms' mail.thread override to show up in the Odoo generated POT files, but not in the OCB ones.
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 60ede15. Thanks a lot for contributing to OCA. ❤️ |
Port of #3343
paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537
The import error was dropped silently, making the error show up as
Also: prevent infinite loop of makepot commits
Don't run makepot using both Odoo and OCB. This is redundant, but also, because
of changes between both versions, the POTs may have trivial differences. The
commit of a makepot run will again trigger CI to run makepot with both versions,
leading to an infinite loop of competing commits trying to revert each other's
trivial differences.
In the current case, the sms module is set to auto_install in Odoo but not in
OCB. This causes the field
message_has_sms_errorfrom sms' mail.thread overrideto show up in the Odoo generated POT files, but not in the OCB ones.