Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Optimize route tree sibling sorting - #7969

Closed
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting
Closed

Optimize route tree sibling sorting#7969
Sheraff wants to merge 2 commits into
mainfrom
codex/optimize-route-tree-sorting

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

  • record dynamic sibling arrays when they first become sortable
  • sort only those arrays after route parsing finishes
  • remove the recursive pass over every node in the route tree
  • cover reverse-order optional, wildcard, and route-mask siblings

Why

Most nodes do not contain competing dynamic siblings. Tracking the few arrays that need ordering avoids traversing the entire parsed tree a second time while preserving the existing comparator and post-parse ordering.

Bundle impact

Prior isolated prototype measurements from the same main commit used as this PR's base:

  • react-router.minimal: -214 B raw, -18 B gzip, -75 B Brotli
  • solid-router.minimal: -213 B raw, -31 B gzip, -27 B Brotli

Validation

  • router-core focused unit tests (172 passed)
  • router-core type tests (TypeScript 5.6–7.0)
  • router-core ESLint (0 errors; existing warnings only)
  • router-core production build

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching so prefixed and suffixed optional or wildcard routes are prioritized correctly, regardless of declaration order.
    • Improved specificity ordering for dynamic, optional, and wildcard route masks.
  • Tests

    • Added coverage for route and route-mask matching priorities.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbf880bf-4056-46df-a48b-297b66f4e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and f07a855.

📒 Files selected for processing (2)
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts

📝 Walkthrough

Walkthrough

Route parsing now records sortable dynamic, optional, and wildcard sibling arrays. Route trees and route masks sort those arrays after parsing. Tests cover specificity when routes and masks are declared in least-specific order.

Changes

Route sorting

Layer / File(s)Summary
Sortable array collection
packages/router-core/src/new-process-route-tree.ts
parseSegments propagates a sortable-array accumulator and records dynamic, optional, and wildcard sibling arrays when they reach two elements.
Post-parse route and mask sorting
packages/router-core/src/new-process-route-tree.ts
processRouteTree and processRouteMasks sort recorded arrays after parsing. The recursive full-tree sorting pass is removed.
Route priority coverage
packages/router-core/tests/new-process-route-tree.test.ts
Tests verify specificity for prefixed and suffixed optional, wildcard, and route-mask patterns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: optimizing route tree sibling sorting.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-route-tree-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f07a855

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded12m 53sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 22:24:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b064b5733bc5
  • Measured at: 2026-08-05T22:16:20.995Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.09 KiB-19 B (-0.02%)86.96 KiB268.92 KiB75.96 KiB████▂▂▂▂▂▁▂▁
react-router.full90.84 KiB-54 B (-0.06%)90.71 KiB280.87 KiB79.10 KiB████▃▃▃▃▃▂▃▁
solid-router.minimal34.77 KiB-31 B (-0.09%)34.64 KiB99.75 KiB31.34 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.87 KiB-26 B (-0.06%)39.75 KiB114.93 KiB35.82 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-26 B (-0.05%)51.94 KiB142.91 KiB46.91 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-42 B (-0.07%)57.88 KiB161.58 KiB52.14 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.56 KiB-40 B (-0.04%)100.42 KiB312.07 KiB87.32 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.30 KiB-41 B (-0.04%)100.44 KiB313.44 KiB88.00 KiB███████▁▁▁▁▁
react-start.full103.92 KiB-5 B (-0.00%)103.78 KiB322.02 KiB90.25 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-27 B (-0.03%)100.04 KiB316.58 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-32 B (-0.03%)100.45 KiB317.52 KiB86.67 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-52 B (-0.05%)103.35 KiB326.67 KiB89.12 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-35 B (-0.07%)48.02 KiB141.89 KiB42.78 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-31 B (-0.06%)48.08 KiB149.93 KiB45.83 KiB███████▁▁▁▁▁
solid-start.full53.41 KiB-24 B (-0.04%)53.28 KiB157.62 KiB47.47 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.91 KiB-60 B (-0.08%)68.78 KiB194.90 KiB61.30 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-18 B (-0.02%)72.78 KiB207.41 KiB64.65 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7969

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7969

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7969

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7969

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7969

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7969

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7969

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7969

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7969

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7969

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7969

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7969

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7969

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7969

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7969

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7969

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7969

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7969

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7969

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7969

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7969

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7969

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7969

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7969

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7969

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7969

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7969

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7969

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7969

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7969

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7969

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7969

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7969

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7969

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7969

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7969

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7969

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7969

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7969

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7969

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7969

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7969

commit: f07a855

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths unmatched (react)317.5 KB741.7 KB-57.2%
Memorymem client unique-location-churn (solid)341.2 KB524.8 KB-34.97%
Memorymem server peak-large-page (react)1.7 MB2.5 MB-32.15%
Memorymem server error-paths redirect (vue)338.6 KB487.5 KB-30.53%
Simulationssr control-flow route headers (react)63.8 ms66.1 ms-3.48%
Memorymem server server-fn-churn (vue)4,147.3 KB264.6 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB484.9 KB×4.4
Memorymem server error-paths redirect (solid)388 KB283.8 KB+36.75%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/optimize-route-tree-sorting (f07a855) with main (697ebb6)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff