perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

perf(router-core): fuse static route node construction - #7981

Closed
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes
Closed

perf(router-core): fuse static route node construction#7981
Sheraff wants to merge 6 commits into
mainfrom
codex/fuse-static-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the case-specific static key and child map once, then share lookup and node construction
  • preserve one explicit sensitivity branch after the runtime benchmark gate
  • add focused sensitivity, prefix-reuse, route-mask tests and a static construction benchmark

Bundle impact

Across the exact 17-scenario matrix, every scenario is 162 raw bytes smaller, gzip improves by 22-45 bytes, and initial gzip improves by 22-44 bytes. react-router.minimal improves by 162 raw / 36 gzip / 161 Brotli bytes. Brotli is mixed across the matrix (-161 to +43 bytes) and is disclosed in the checked-in result report.

Runtime

Repeated focused runs show the insensitive distributions about 6-7% faster; sensitive-unique and narrowed sensitive-shared distributions are neutral. The final implementation keeps one real sensitivity branch because an earlier branchless form produced a questionable sensitive-path result.

Validation

  • router-core unit: 1,526 passed, 3 expected failures
  • router-core types: TypeScript 5.6 through 7.0 passed
  • router-core ESLint: 0 errors
  • generator CLI React e2e: 3 passed
  • full 17-scenario bundle matrix passed
  • five independent reviews approved the exact production HEAD

Integration note

This overlaps the parseSegments construction region changed by #7974. Whichever PR lands second must be rebased and have the benchmark and full bundle matrix rerun.

Summary by CodeRabbit

  • Performance
    • Improved static route-tree construction efficiency, reducing redundant processing and supporting smaller bundles in tested scenarios.
  • Bug Fixes
    • Fixed case-sensitive and case-insensitive route matching across shared and differently cased route paths.
    • Preserved route-level case-sensitivity overrides when the overall routing configuration uses a different default.
  • Documentation
    • Added documentation covering performance results, compatibility, validation, and integration considerations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 031ebdbf-8844-4e93-924a-a8c22513af11

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and 6457582.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-static-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-static-construction.bench.ts

📝 Walkthrough

Walkthrough

The route-tree parser now fuses case-sensitive and case-insensitive static-node construction. Tests cover node reuse and matching behavior. A benchmark measures shared and unique static prefixes. Documentation records results and compatibility details.

Changes

Static route-node construction

Layer / File(s)Summary
Fuse case-aware static-node construction
packages/router-core/src/new-process-route-tree.ts, packages/router-core/tests/new-process-route-tree.test.ts
parseSegments selects the appropriate static-child map and shares lookup and creation logic. Tests cover case-insensitive node reuse, route-level overrides, and uppercase route matching.
Validate construction and measurements
packages/router-core/tests/route-tree-static-construction.bench.ts, RESULT-optimization-fused-static-route-nodes.md
Benchmarks cover shared and unique prefixes for both sensitivity modes. Documentation records bundle-size results, runtime benchmarks, compatibility guarantees, and validation coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7969: Both changes modify route-tree parsing, but this PR targets static-node construction while that PR targets dynamic-sibling sorting.
  • TanStack/router#7974: Both changes modify parseSegments construction logic, with this PR targeting static nodes and that PR targeting dynamic nodes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary performance change: fusing static route node construction in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-static-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f59c15d

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded28sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:39:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 44554f12fe15
  • Measured at: 2026-08-06T10:32:23.615Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-36 B (-0.04%)86.94 KiB268.97 KiB75.76 KiB████▂▂▂▂▂▁▂▁
react-router.full90.87 KiB-32 B (-0.03%)90.73 KiB280.93 KiB79.12 KiB████▃▃▃▃▃▁▂▁
solid-router.minimal34.77 KiB-27 B (-0.08%)34.64 KiB99.81 KiB31.39 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.86 KiB-37 B (-0.09%)39.74 KiB114.99 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.06 KiB-32 B (-0.06%)51.94 KiB142.96 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.02 KiB-33 B (-0.06%)57.89 KiB161.63 KiB52.10 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.13 KiB87.27 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-44 B (-0.04%)100.44 KiB313.50 KiB87.91 KiB███████▁▁▁▁▁
react-start.full103.90 KiB-24 B (-0.02%)103.76 KiB322.07 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-22 B (-0.02%)100.04 KiB316.63 KiB86.33 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.62 KiB-22 B (-0.02%)100.46 KiB317.56 KiB86.78 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.54 KiB-26 B (-0.02%)103.37 KiB326.72 KiB89.19 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.14 KiB-41 B (-0.08%)48.01 KiB141.95 KiB42.76 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.40 KiB-42 B (-0.08%)48.07 KiB149.99 KiB45.80 KiB███████▁▁▁▁▁
solid-start.full53.39 KiB-41 B (-0.07%)53.26 KiB157.68 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-32 B (-0.05%)68.81 KiB194.96 KiB61.28 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.46 KiB64.67 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7981

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7981

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7981

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7981

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7981

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7981

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7981

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7981

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7981

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7981

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7981

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7981

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7981

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7981

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7981

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7981

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7981

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7981

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7981

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7981

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7981

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7981

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7981

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7981

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7981

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7981

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7981

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7981

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7981

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7981

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7981

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7981

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7981

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7981

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7981

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7981

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7981

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7981

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7981

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7981

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7981

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7981

commit: f59c15d

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 3 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.57%
Memorymem server error-paths unmatched (react)317.5 KB373.1 KB-14.9%
Simulationssr server-fn during document ssr (react)62.9 ms65.7 ms-4.27%
Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
Memorymem server error-paths unmatched (vue)2,142.1 KB485.8 KB×4.4
Memorymem server error-paths redirect (solid)388 KB289.2 KB+34.18%
Memorymem server error-paths redirect (vue)338.6 KB306.4 KB+10.52%
Memorymem client navigation-churn (solid)580.3 KB537.3 KB+7.99%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.22%
Memorymem server error-paths not-found (react)277.7 KB267.9 KB+3.64%
Simulationssr control-flow unmatched 404 (react)58.1 ms56.3 ms+3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-static-route-nodes (f59c15d) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:33

@nx-cloudnx-cloudBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment state issue rather than a code change. The failing task (tanstack-solid-start-e2e-basic) is unrelated to the PR's touched project (@tanstack/router-core), and the root cause is a port conflict (EADDRINUSE :::37551) where another CI process occupied the port before the test server could start. A rerun of the pipeline should resolve this.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff