perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

MetricBeforeAfterChange
gzip89,200 B89,145 B-55 B
initial gzip89,058 B89,004 B-54 B
raw275,591 B274,715 B-876 B
Brotli77,742 B77,571 B-171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s)Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant RouteTreeProcessing
participant parseSegments
participant DynamicSiblingLists
RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
parseSegments->>DynamicSiblingLists: register lists with multiple entries
RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in router-core.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded9m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.06 KiB-55 B (-0.06%)86.92 KiB268.28 KiB75.75 KiB████▂▂▂▂▂▂▂▁
react-router.full90.81 KiB-88 B (-0.09%)90.68 KiB280.24 KiB79.08 KiB████▄▄▄▄▄▃▃▁
solid-router.minimal34.74 KiB-58 B (-0.16%)34.61 KiB99.10 KiB31.42 KiB████▂▂▂▂▂▂▂▁
solid-router.full39.83 KiB-72 B (-0.18%)39.70 KiB114.27 KiB35.82 KiB████▂▂▂▂▂▂▂▁
vue-router.minimal52.03 KiB-69 B (-0.13%)51.90 KiB142.25 KiB46.84 KiB████▂▂▂▂▂▁▁▁
vue-router.full57.95 KiB-100 B (-0.17%)57.82 KiB160.92 KiB52.08 KiB████▂▂▂▂▂▂▂▁
react-start.minimal100.50 KiB-104 B (-0.10%)100.36 KiB311.42 KiB87.23 KiB███████▂▂▁▁▁
react-start.deferred-hydration101.23 KiB-106 B (-0.10%)100.38 KiB312.79 KiB87.89 KiB███████▂▂▁▁▁
react-start.full103.86 KiB-60 B (-0.06%)103.73 KiB321.37 KiB90.24 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.12 KiB-118 B (-0.11%)99.95 KiB315.90 KiB86.31 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife100.53 KiB-118 B (-0.11%)100.36 KiB316.84 KiB86.73 KiB▁▁▁▁▂▂▂████▆
react-start.rsbuild.full103.45 KiB-125 B (-0.12%)103.28 KiB326.00 KiB89.06 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.10 KiB-84 B (-0.17%)47.97 KiB141.24 KiB42.83 KiB███████▂▂▁▁▁
solid-start.deferred-hydration51.36 KiB-82 B (-0.16%)48.03 KiB149.28 KiB45.75 KiB███████▂▂▁▁▁
solid-start.full53.36 KiB-77 B (-0.14%)53.23 KiB156.97 KiB47.39 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.87 KiB-104 B (-0.15%)68.74 KiB194.25 KiB61.31 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.86 KiB-76 B (-0.10%)72.73 KiB206.75 KiB64.78 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server error-paths not-found (solid)415.1 KB759.7 KB-45.36%
Memorymem client preload-churn (vue)737 KB780.6 KB-5.59%
Simulationssr server-fn during document ssr (react)62.9 ms66 ms-4.68%
Memorymem server error-paths redirect (react)197 KB204.2 KB-3.55%
Simulationssr control-flow error 500 (react)60.4 ms62.4 ms-3.18%
Memorymem server server-fn-churn (vue)4,147.3 KB263.1 KB×16
Memorymem server error-paths unmatched (vue)2,142.1 KB480.7 KB×4.5
Memorymem server peak-large-page (react)1,737.5 KB951.2 KB+82.66%
Memorymem server error-paths redirect (solid)388 KB272.3 KB+42.5%
Memorymem server error-paths redirect (vue)338.6 KB289.7 KB+16.87%
Memorymem server error-paths not-found (react)277.7 KB256 KB+8.45%
Memorymem client navigation-churn (vue)1.3 MB1.2 MB+4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff