Uh oh!
There was an error while loading. Please reload this page.
fix: Message sending GC allocations - #4119
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@## develop-2.0.0 #4119 +/- ##
=================================================
+ Coverage 73.88% 73.94% +0.06%
=================================================
Files 172 172 Lines 28095 28099 +4 =================================================
+ Hits 20758 20779 +21 + Misses 7337 7320 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
ShadauxCat
approved these changes
Aug 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
michalChrobot added a commit
that referenced
this pull request
Aug 31, 2026
* fix: Message sending GC allocations (#4119) * fix: GC allocations * Add message receive allocations test * Revert the fix to check ILPP build fails the test * Revert forced failure * Remove gc checks on NetworkListTests * ci: re-enable PS5 and Switch jobs (#4117) * Re-enabled ps5 and webgl * ci: Add WebGL PlayMode test job (MTT-15569) Split the WebGL CI into a build phase and a run phase. webgl-build.yml now exposes the built player as a dedicated 'players' artifact, and a new webgl-test.yml run job consumes it and executes the PlayMode tests inside Firefox on a GPU-backed Ubuntu agent (Unity::VM::GPU, rtx2080). The Firefox browser flags are passed explicitly so UTR does not attempt to download the browser from Stevedore. The run job is wired into the Nightly and Weekly (QV) triggers only, not into PR triggers, since WebGL failures are infrequent and the build is slow. Runtime RuntimePlatform.WebGLPlayer exclusions are intentionally deferred to be added reactively after the first real CI run. * corrected images * disabled webgl test * adjustments * Removed WebGL changes * reverted change * added diagnostic for switch * corrected Switch sdk version * temporarily disabled switch * corrected ticket description * chore: Updated aspects of Netcode package in anticipation of v2.13.2 release (#4121) * ci: Add pets-svc to pr-description-check exclusion list (#4125) Changde users exclusion to pattern exclusion in pr description check * trunk shadow changes: com.unity.netcode.gameobjects (#4120) * Updated changelog and package version for Netcode in anticipation of v2.13.1 release * typo in build automation * trunk shadow changes: com.unity.netcode.gameobjects [skip ci] * Revert CHANGELOG changes * Added UNITY_TEST_FRAMEWORK_1_7_OR_NEWER guard and UnityCoreClrExplicitDisabledAttributeShim.cs to make attribute usage possible * corrected svc bot exclusion --------- Co-authored-by: netcode-automation <svc-netcode-sdk@unity3d.com> Co-authored-by: Michał Chrobot <michal.chrobot@unity3d.com> Co-authored-by: PETS automation <299490404+pets-svc[bot]@users.noreply.github.com> Co-authored-by: Emma <emma.mcmillan@unity3d.com> * chore(deps): update ci deps updates (#4085) Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com> * fixed CI + addressed U-PR comments --------- Co-authored-by: Emma <emma.mcmillan@unity3d.com> Co-authored-by: Netcode team bot <svc-netcode-sdk@unity3d.com> Co-authored-by: pets-svc[bot] <299490404+pets-svc[bot]@users.noreply.github.com> Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes some GC allocations in message hot paths.
Jira ticket
fixes: #4091
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
Up-port needed
Backports
n/a