Skip to content

fix(tabs): duplicate animation events on some browsers - #13674

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:tabs-duplicate-events
Nov 3, 2018
Merged

fix(tabs): duplicate animation events on some browsers#13674
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:tabs-duplicate-events

Conversation

@crisbeto

@crisbetocrisbeto commented Oct 18, 2018

Copy link
Copy Markdown
Member

Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the animationDone event being fired too many times.

@crisbeto
fix(tabs): duplicate animation events on some browsers
199aede
Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the `animationDone` event being fired too many times.
@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Oct 18, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 18, 2018
josephperrott
josephperrott approved these changes Nov 1, 2018
View reviewed changes

@josephperrottjosephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrottjosephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 1, 2018
@jelbourn
jelbourn merged commit 28e3d36 into angular:masterNov 3, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@crisbeto@atscott
fix(tabs): duplicate animation events on some browsers (angular#13674)
663a0fd
Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the `animationDone` event being fired too many times.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
@crisbeto@jelbourn
fix(tabs): duplicate animation events on some browsers (#13674)
7106681
Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the `animationDone` event being fired too many times.
jelbourn added a commit to jelbourn/components that referenced this pull request Nov 6, 2018
@jelbourn
Revert "fix(tabs): duplicate animation events on some browsers (angul…
1e10c28
…ar#13674)"
This reverts commit 28e3d36.
This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering.
vivian-hu-zz pushed a commit that referenced this pull request Nov 7, 2018
@jelbourn@vivian-hu-zz
Revert "fix(tabs): duplicate animation events on some browsers (#13674)…
11c96d6
…" (#14015)
This reverts commit 28e3d36.
This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering.
jelbourn added a commit to jelbourn/components that referenced this pull request Nov 7, 2018
@jelbourn
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
f7d3023
angular#13674)" (angular#14015)"
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was angular#13888
instead.
@jelbournjelbourn mentioned this pull request Nov 7, 2018
Merged
vivian-hu-zz pushed a commit that referenced this pull request Nov 7, 2018
@jelbourn@vivian-hu-zz
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
4508fa1
#13674)" (#14015)" (#14016)
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was #13888
instead.
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbournVivian Hu
Revert "fix(tabs): duplicate animation events on some browsers (#13674)…
ba73d24
…" (#14015)
This reverts commit 28e3d36.
This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering.
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbournVivian Hu
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
5e96e8b
#13674)" (#14015)" (#14016)
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was #13888
instead.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrottjosephperrottjosephperrott approved these changes
@andrewseguinandrewseguinAwaiting requested review from andrewseguin

Assignees

@josephperrottjosephperrott

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto@josephperrott@jelbourn@googlebot