Skip to content

Revert "Revert "fix(tabs): duplicate animation events on some browser… - #14016

Merged
vivian-hu-zz merged 1 commit into
angular:masterfrom
jelbourn:revert-revert
Nov 7, 2018
Merged

Revert "Revert "fix(tabs): duplicate animation events on some browser…#14016
vivian-hu-zz merged 1 commit into
angular:masterfrom
jelbourn:revert-revert

Conversation

@jelbourn

@jelbournjelbourn commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

…s (#13674)" (#14015)"

This reverts commit 11c96d6.

Turns out the original change wasn't actually the problem. It was #13888
instead.

@jelbourn
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
f7d3023
angular#13674)" (angular#14015)"
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was angular#13888
instead.
@jelbournjelbourn added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 7, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2018
vivian-hu-zz
vivian-hu-zz approved these changes Nov 7, 2018
View reviewed changes

@vivian-hu-zzvivian-hu-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 7, 2018
@vivian-hu-zz
vivian-hu-zz merged commit 4508fa1 into angular:masterNov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbournVivian Hu
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
5e96e8b
#13674)" (#14015)" (#14016)
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was #13888
instead.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguinandrewseguinAwaiting requested review from andrewseguin
1 more reviewer
@vivian-hu-zzvivian-hu-zzvivian-hu-zz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelbourn@vivian-hu-zz@googlebot