Skip to content

Revert "fix(tabs): duplicate animation events on some browsers (#13674)" - #14015

Merged
vivian-hu-zz merged 1 commit into
angular:masterfrom
jelbourn:tabs-dupe-revert
Nov 7, 2018
Merged

Revert "fix(tabs): duplicate animation events on some browsers (#13674)"#14015
vivian-hu-zz merged 1 commit into
angular:masterfrom
jelbourn:tabs-dupe-revert

Conversation

@jelbourn

@jelbournjelbourn commented Nov 6, 2018

Copy link
Copy Markdown
Contributor

This reverts commit 28e3d36.

This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering. It has to have something to do with the timing change in this PR, but we can't figure out what exactly happened.

cc @crisbeto

@jelbourn
Revert "fix(tabs): duplicate animation events on some browsers (angul…
1e10c28
…ar#13674)"
This reverts commit 28e3d36.
This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering.
@jelbournjelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Nov 6, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2018
vivian-hu-zz
vivian-hu-zz approved these changes Nov 7, 2018
View reviewed changes

@vivian-hu-zzvivian-hu-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zzvivian-hu-zz added the action: merge The PR is ready for merge by the caretaker label Nov 7, 2018
@vivian-hu-zz
vivian-hu-zz merged commit 11c96d6 into angular:masterNov 7, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request Nov 7, 2018
@jelbourn
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
f7d3023
angular#13674)" (angular#14015)"
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was angular#13888
instead.
@jelbournjelbourn mentioned this pull request Nov 7, 2018
Merged
vivian-hu-zz pushed a commit that referenced this pull request Nov 7, 2018
@jelbourn@vivian-hu-zz
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
4508fa1
#13674)" (#14015)" (#14016)
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was #13888
instead.
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbournVivian Hu
Revert "fix(tabs): duplicate animation events on some browsers (#13674)…
ba73d24
…" (#14015)
This reverts commit 28e3d36.
This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering.
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbournVivian Hu
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
5e96e8b
#13674)" (#14015)" (#14016)
This reverts commit 11c96d6.
Turns out the original change wasn't actually the problem. It was #13888
instead.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguinandrewseguinAwaiting requested review from andrewseguin
1 more reviewer
@vivian-hu-zzvivian-hu-zzvivian-hu-zz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementGThis is is related to a Google internal issueP1Impacts a large percentage of users; if a workaround exists it is partial or overly painfultarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelbourn@vivian-hu-zz@googlebot