Add Python 3.10 support - #22050

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:add-python-3-10-support
Mar 21, 2022
Merged

Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom
potiuk:add-python-3-10-support

Conversation

@potiuk

@potiukpotiuk commented Mar 7, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.

Closes: #19059

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk

potiuk commented Mar 7, 2022

Copy link
Copy Markdown
MemberAuthor

I think we should be close to get Python 3.10 support. Let's see

@potiukpotiuk added the full tests needed We need to run full set of tests for this PR to merge label Mar 7, 2022
@potiukpotiuk closed this Mar 7, 2022
@potiukpotiuk reopened this Mar 7, 2022
@potiuk
potiukforce-pushed the add-python-3-10-support branch from 4a2a616 to b92fda0CompareMarch 7, 2022 13:52
@potiuk

potiuk commented Mar 7, 2022

Copy link
Copy Markdown
MemberAuthor

In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.

@potiuk
potiukforce-pushed the add-python-3-10-support branch from b92fda0 to 102848fCompareMarch 7, 2022 14:56
@mik-laj

mik-laj commented Mar 7, 2022

Copy link
Copy Markdown
Member

Should we remove user warning?

airflow/airflow/__main__.py

Lines 38 to 43 in 6db9b00

ifPY310:
docs_url=get_docs_url('installation/prerequisites.html')
warnings.warn(
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
)

@potiuk

potiuk commented Mar 7, 2022

Copy link
Copy Markdown
MemberAuthor

Should we remove user warning?

airflow/airflow/__main__.py

Lines 38 to 43 in 6db9b00

ifPY310:
docs_url=get_docs_url('installation/prerequisites.html')
warnings.warn(
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
)

Yep. That too :)

@potiuk
potiukforce-pushed the add-python-3-10-support branch from 102848f to d3aa026CompareMarch 7, 2022 15:05
@Bowrna

Bowrna commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

@potiuk Do I have to make changes in Breeze2 to support Python 3.10?

@potiuk

potiuk commented Mar 8, 2022

Copy link
Copy Markdown
MemberAuthor

@potiuk Do I have to make changes in Breeze2 to support Python 3.10?

No need. I made a "bulk" update here and I also updated Breeze2 :D

@potiuk
potiukforce-pushed the add-python-3-10-support branch 3 times, most recently from 1240212 to d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk marked this pull request as ready for review March 11, 2022 20:00
@potiuk
potiuk requested review from ashb and mik-laj as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed the add-python-3-10-support branch from d0f1871 to 77ebb39CompareMarch 11, 2022 21:45
@potiuk

potiuk commented Mar 11, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13

@potiukpotiuk mentioned this pull request Mar 12, 2022
Merged
@potiukpotiuk mentioned this pull request Mar 12, 2022
Merged
@potiukpotiuk reopened this Mar 13, 2022
@potiuk
potiukforce-pushed the add-python-3-10-support branch from 644c0d2 to d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani mentioned this pull request Mar 18, 2022
Closed
5 tasks
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed the add-python-3-10-support branch from d45e4fc to 7a20762CompareMarch 19, 2022 21:10
potiuk added a commit that referenced this pull request Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit that referenced this pull request Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed the add-python-3-10-support branch from 7a20762 to 740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit that referenced this pull request Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed the add-python-3-10-support branch from 740f3c9 to 03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit that referenced this pull request Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk

potiuk commented Mar 21, 2022

Copy link
Copy Markdown
MemberAuthor

Final PR to get Python 3.10 support !

@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees

No one assigned

Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support

5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add Python 3.10 support - #22050
Merged
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Mar 21, 2022
Merged
Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Conversation
@potiuk
@potiukpotiuk
commented
Mar 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Python 3.10 support has been long missing because a number of our

dependencies had problems with it. It seems that last problems

remaining should be fixed now, and we should be able to get

a proper Python 3.10 support.
Closes: #19059
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in UPDATING.md.
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
I think we should be close to get Python 3.10 support. Let's see
@potiukpotiuk
added
the 
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 7, 2022
@potiukpotiuk
closed this
Mar 7, 2022
@potiukpotiuk
reopened this
Mar 7, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
4a2a616 to
b92fda0CompareMarch 7, 2022 13:52
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
b92fda0 to
102848fCompareMarch 7, 2022 14:56
@mik-laj
mik-laj
commented
Mar 7, 2022

Copy link


Copy Markdown

Member
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
Yep. That too :)
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
102848f to
d3aa026CompareMarch 7, 2022 15:05
@Bowrna
Bowrna
commented
Mar 8, 2022

Copy link


Copy Markdown

Contributor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
@potiuk
potiuk
commented
Mar 8, 2022

Copy link


Copy Markdown

MemberAuthor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
No need. I made a "bulk" update here and I also updated Breeze2 :D
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
3 times, most recently
from
1240212 to
d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk
marked this pull request as ready for review
March 11, 2022 20:00
@potiuk
potiuk
requested review from
ashb and mik-laj
as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d0f1871 to
77ebb39CompareMarch 11, 2022 21:45
@potiuk
potiuk
commented
Mar 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13
@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
reopened this
Mar 13, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
644c0d2 to
d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani
mentioned this pull request
Mar 18, 2022
 Closed

5 tasks
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d45e4fc to
7a20762CompareMarch 19, 2022 21:10
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
7a20762 to
740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
740f3c9 to
03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiuk
commented
Mar 21, 2022

Copy link


Copy Markdown

MemberAuthor
Final PR to get Python 3.10 support !
@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees


No one assigned


Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support


5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Python 3.10 support - #22050
Merged
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Mar 21, 2022
Merged
Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Conversation
@potiuk
@potiukpotiuk
commented
Mar 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Python 3.10 support has been long missing because a number of our

dependencies had problems with it. It seems that last problems

remaining should be fixed now, and we should be able to get

a proper Python 3.10 support.
Closes: #19059
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in UPDATING.md.
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
I think we should be close to get Python 3.10 support. Let's see
@potiukpotiuk
added
the 
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 7, 2022
@potiukpotiuk
closed this
Mar 7, 2022
@potiukpotiuk
reopened this
Mar 7, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
4a2a616 to
b92fda0CompareMarch 7, 2022 13:52
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
b92fda0 to
102848fCompareMarch 7, 2022 14:56
@mik-laj
mik-laj
commented
Mar 7, 2022

Copy link


Copy Markdown

Member
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
Yep. That too :)
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
102848f to
d3aa026CompareMarch 7, 2022 15:05
@Bowrna
Bowrna
commented
Mar 8, 2022

Copy link


Copy Markdown

Contributor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
@potiuk
potiuk
commented
Mar 8, 2022

Copy link


Copy Markdown

MemberAuthor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
No need. I made a "bulk" update here and I also updated Breeze2 :D
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
3 times, most recently
from
1240212 to
d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk
marked this pull request as ready for review
March 11, 2022 20:00
@potiuk
potiuk
requested review from
ashb and mik-laj
as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d0f1871 to
77ebb39CompareMarch 11, 2022 21:45
@potiuk
potiuk
commented
Mar 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13
@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
reopened this
Mar 13, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
644c0d2 to
d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani
mentioned this pull request
Mar 18, 2022
 Closed

5 tasks
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d45e4fc to
7a20762CompareMarch 19, 2022 21:10
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
7a20762 to
740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
740f3c9 to
03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiuk
commented
Mar 21, 2022

Copy link


Copy Markdown

MemberAuthor
Final PR to get Python 3.10 support !
@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees


No one assigned


Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support


5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Python 3.10 support - #22050
Merged
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Mar 21, 2022
Merged
Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Conversation
@potiuk
@potiukpotiuk
commented
Mar 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Python 3.10 support has been long missing because a number of our

dependencies had problems with it. It seems that last problems

remaining should be fixed now, and we should be able to get

a proper Python 3.10 support.
Closes: #19059
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in UPDATING.md.
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
I think we should be close to get Python 3.10 support. Let's see
@potiukpotiuk
added
the 
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 7, 2022
@potiukpotiuk
closed this
Mar 7, 2022
@potiukpotiuk
reopened this
Mar 7, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
4a2a616 to
b92fda0CompareMarch 7, 2022 13:52
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
b92fda0 to
102848fCompareMarch 7, 2022 14:56
@mik-laj
mik-laj
commented
Mar 7, 2022

Copy link


Copy Markdown

Member
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
Yep. That too :)
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
102848f to
d3aa026CompareMarch 7, 2022 15:05
@Bowrna
Bowrna
commented
Mar 8, 2022

Copy link


Copy Markdown

Contributor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
@potiuk
potiuk
commented
Mar 8, 2022

Copy link


Copy Markdown

MemberAuthor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
No need. I made a "bulk" update here and I also updated Breeze2 :D
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
3 times, most recently
from
1240212 to
d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk
marked this pull request as ready for review
March 11, 2022 20:00
@potiuk
potiuk
requested review from
ashb and mik-laj
as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d0f1871 to
77ebb39CompareMarch 11, 2022 21:45
@potiuk
potiuk
commented
Mar 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13
@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
reopened this
Mar 13, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
644c0d2 to
d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani
mentioned this pull request
Mar 18, 2022
 Closed

5 tasks
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d45e4fc to
7a20762CompareMarch 19, 2022 21:10
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
7a20762 to
740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
740f3c9 to
03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiuk
commented
Mar 21, 2022

Copy link


Copy Markdown

MemberAuthor
Final PR to get Python 3.10 support !
@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees


No one assigned


Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support


5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add Python 3.10 support - #22050
Merged
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Mar 21, 2022
Merged
Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Conversation
@potiuk
@potiukpotiuk
commented
Mar 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Python 3.10 support has been long missing because a number of our

dependencies had problems with it. It seems that last problems

remaining should be fixed now, and we should be able to get

a proper Python 3.10 support.
Closes: #19059
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in UPDATING.md.
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
I think we should be close to get Python 3.10 support. Let's see
@potiukpotiuk
added
the 
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 7, 2022
@potiukpotiuk
closed this
Mar 7, 2022
@potiukpotiuk
reopened this
Mar 7, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
4a2a616 to
b92fda0CompareMarch 7, 2022 13:52
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
b92fda0 to
102848fCompareMarch 7, 2022 14:56
@mik-laj
mik-laj
commented
Mar 7, 2022

Copy link


Copy Markdown

Member
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
Yep. That too :)
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
102848f to
d3aa026CompareMarch 7, 2022 15:05
@Bowrna
Bowrna
commented
Mar 8, 2022

Copy link


Copy Markdown

Contributor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
@potiuk
potiuk
commented
Mar 8, 2022

Copy link


Copy Markdown

MemberAuthor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
No need. I made a "bulk" update here and I also updated Breeze2 :D
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
3 times, most recently
from
1240212 to
d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk
marked this pull request as ready for review
March 11, 2022 20:00
@potiuk
potiuk
requested review from
ashb and mik-laj
as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d0f1871 to
77ebb39CompareMarch 11, 2022 21:45
@potiuk
potiuk
commented
Mar 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13
@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
reopened this
Mar 13, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
644c0d2 to
d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani
mentioned this pull request
Mar 18, 2022
 Closed

5 tasks
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d45e4fc to
7a20762CompareMarch 19, 2022 21:10
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
7a20762 to
740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
740f3c9 to
03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiuk
commented
Mar 21, 2022

Copy link


Copy Markdown

MemberAuthor
Final PR to get Python 3.10 support !
@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees


No one assigned


Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support


5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Python 3.10 support - #22050
Merged
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Mar 21, 2022
Merged
Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Conversation
@potiuk
@potiukpotiuk
commented
Mar 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Python 3.10 support has been long missing because a number of our

dependencies had problems with it. It seems that last problems

remaining should be fixed now, and we should be able to get

a proper Python 3.10 support.
Closes: #19059
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in UPDATING.md.
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
I think we should be close to get Python 3.10 support. Let's see
@potiukpotiuk
added
the 
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 7, 2022
@potiukpotiuk
closed this
Mar 7, 2022
@potiukpotiuk
reopened this
Mar 7, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
4a2a616 to
b92fda0CompareMarch 7, 2022 13:52
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
b92fda0 to
102848fCompareMarch 7, 2022 14:56
@mik-laj
mik-laj
commented
Mar 7, 2022

Copy link


Copy Markdown

Member
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
Yep. That too :)
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
102848f to
d3aa026CompareMarch 7, 2022 15:05
@Bowrna
Bowrna
commented
Mar 8, 2022

Copy link


Copy Markdown

Contributor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
@potiuk
potiuk
commented
Mar 8, 2022

Copy link


Copy Markdown

MemberAuthor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
No need. I made a "bulk" update here and I also updated Breeze2 :D
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
3 times, most recently
from
1240212 to
d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk
marked this pull request as ready for review
March 11, 2022 20:00
@potiuk
potiuk
requested review from
ashb and mik-laj
as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d0f1871 to
77ebb39CompareMarch 11, 2022 21:45
@potiuk
potiuk
commented
Mar 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13
@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
reopened this
Mar 13, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
644c0d2 to
d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani
mentioned this pull request
Mar 18, 2022
 Closed

5 tasks
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d45e4fc to
7a20762CompareMarch 19, 2022 21:10
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
7a20762 to
740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
740f3c9 to
03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiuk
commented
Mar 21, 2022

Copy link


Copy Markdown

MemberAuthor
Final PR to get Python 3.10 support !
@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees


No one assigned


Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support


5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Python 3.10 support - #22050
Merged
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Mar 21, 2022
Merged
Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Conversation
@potiuk
@potiukpotiuk
commented
Mar 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Python 3.10 support has been long missing because a number of our

dependencies had problems with it. It seems that last problems

remaining should be fixed now, and we should be able to get

a proper Python 3.10 support.
Closes: #19059
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in UPDATING.md.
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
I think we should be close to get Python 3.10 support. Let's see
@potiukpotiuk
added
the 
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 7, 2022
@potiukpotiuk
closed this
Mar 7, 2022
@potiukpotiuk
reopened this
Mar 7, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
4a2a616 to
b92fda0CompareMarch 7, 2022 13:52
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
b92fda0 to
102848fCompareMarch 7, 2022 14:56
@mik-laj
mik-laj
commented
Mar 7, 2022

Copy link


Copy Markdown

Member
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
Yep. That too :)
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
102848f to
d3aa026CompareMarch 7, 2022 15:05
@Bowrna
Bowrna
commented
Mar 8, 2022

Copy link


Copy Markdown

Contributor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
@potiuk
potiuk
commented
Mar 8, 2022

Copy link


Copy Markdown

MemberAuthor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
No need. I made a "bulk" update here and I also updated Breeze2 :D
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
3 times, most recently
from
1240212 to
d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk
marked this pull request as ready for review
March 11, 2022 20:00
@potiuk
potiuk
requested review from
ashb and mik-laj
as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d0f1871 to
77ebb39CompareMarch 11, 2022 21:45
@potiuk
potiuk
commented
Mar 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13
@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
reopened this
Mar 13, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
644c0d2 to
d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani
mentioned this pull request
Mar 18, 2022
 Closed

5 tasks
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d45e4fc to
7a20762CompareMarch 19, 2022 21:10
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
7a20762 to
740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
740f3c9 to
03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiuk
commented
Mar 21, 2022

Copy link


Copy Markdown

MemberAuthor
Final PR to get Python 3.10 support !
@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees


No one assigned


Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support


5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add Python 3.10 support - #22050
Merged
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Mar 21, 2022
Merged
Add Python 3.10 support#22050
potiuk merged 1 commit into
apache:mainfrom 
potiuk:add-python-3-10-support
Conversation
@potiuk
@potiukpotiuk
commented
Mar 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Python 3.10 support has been long missing because a number of our

dependencies had problems with it. It seems that last problems

remaining should be fixed now, and we should be able to get

a proper Python 3.10 support.
Closes: #19059
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in UPDATING.md.
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
I think we should be close to get Python 3.10 support. Let's see
@potiukpotiuk
added
the 
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 7, 2022
@potiukpotiuk
closed this
Mar 7, 2022
@potiukpotiuk
reopened this
Mar 7, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
4a2a616 to
b92fda0CompareMarch 7, 2022 13:52
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
In order to generate constraints, I need to release a new wave of providers to PyPI now. And We should be good.
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
b92fda0 to
102848fCompareMarch 7, 2022 14:56
@mik-laj
mik-laj
commented
Mar 7, 2022

Copy link


Copy Markdown

Member
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
@potiuk
potiuk
commented
Mar 7, 2022

Copy link


Copy Markdown

MemberAuthor
Should we remove user warning?
airflow/airflow/__main__.py

Lines 38 to 43
in
6db9b00
ifPY310: 
docs_url=get_docs_url('installation/prerequisites.html') 
warnings.warn( 
"Python v3.10 is not official supported on this version of Airflow. Please be careful. "
f"For details, see: {docs_url}"
 ) 
Yep. That too :)
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
102848f to
d3aa026CompareMarch 7, 2022 15:05
@Bowrna
Bowrna
commented
Mar 8, 2022

Copy link


Copy Markdown

Contributor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
@potiuk
potiuk
commented
Mar 8, 2022

Copy link


Copy Markdown

MemberAuthor
@potiuk Do I have to make changes in Breeze2 to support Python 3.10?
No need. I made a "bulk" update here and I also updated Breeze2 :D
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
3 times, most recently
from
1240212 to
d0f1871CompareMarch 11, 2022 19:58
@potiuk
potiuk
marked this pull request as ready for review
March 11, 2022 20:00
@potiuk
potiuk
requested review from
ashb and mik-laj
as code ownersMarch 11, 2022 20:00
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d0f1871 to
77ebb39CompareMarch 11, 2022 21:45
@potiuk
potiuk
commented
Mar 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
We might need to reimplement a small issue in cgroupspy - one of the few last remaining issues for Python 3.10 - see cloudsigma/cgroupspy#13
@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
mentioned this pull request
Mar 12, 2022
 Merged

@potiukpotiuk
reopened this
Mar 13, 2022
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
644c0d2 to
d45e4fcCompareMarch 14, 2022 18:29
@marcelotrevisanimarcelotrevisani
mentioned this pull request
Mar 18, 2022
 Closed

5 tasks
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add description on the vendoring process we use
2ec4ddb
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see apache#22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 19, 2022
@potiuk
Add cgroupspy to _vendor folder
7892ac9
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
d45e4fc to
7a20762CompareMarch 19, 2022 21:10
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add description on the vendoring process we use (#22204)
9372aab
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by `bleach` package.
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Add cgroupspy to _vendor folder (#22206)
68aa019
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library
26c7e19
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
391e813
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
7a20762 to
740f3c9CompareMarch 20, 2022 10:00
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Apply import fixes to vendored cgroupspy library (#22207)
172df9e
This commit applies import fixes to vendored cgroupspy library
so that the library uses the vendored version internally.
This commit will need to be re-applied if we upgrade the
vendored cgroupspy library.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy
0c7507b
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
aaa539f
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiukforce-pushed
the
add-python-3-10-support
branch
from
740f3c9 to
03bcfeaCompareMarch 20, 2022 11:27
potiuk added a commit
that referenced
this pull request
Mar 20, 2022
@potiuk
Fix python 3.10 support in vendored in cgroupspy (#22208)
76d6089
The cgrouppspy is not Python 3.10 compliant due to Iterable
being imported directly from collections.
This is captured in cloudsigma/cgroupspy#13
We fix it in our vendored-in version of cgroupspy until
hopefully new version of it is released.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 20, 2022
@potiuk
Switched cgroupspy to vendored version
be1a1c9
This is part of the effort needed to implement Python 3.10
compatibility: apache#22050
@potiuk
potiuk
commented
Mar 21, 2022

Copy link


Copy Markdown

MemberAuthor
Final PR to get Python 3.10 support !
@potiuk
Add Python 3.10 support
9c140ce
Python 3.10 support has been long missing because a number of our
dependencies had problems with it. It seems that last problems
remaining should be fixed now, and we should be able to get
a proper Python 3.10 support.
Closes: apache#19059
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mik-lajmik-lajmik-laj approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@dstandishdstandishAwaiting requested review from dstandish
@ashbashbAwaiting requested review from ashbashb is a code owner

Assignees


No one assigned


Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to mergetype:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add Python 3.10 support


5 participants

@potiuk@mik-laj@Bowrna@alexott@ephraimbuddy