Uh oh!
There was an error while loading. Please reload this page.
Add description on the vendoring process we use - #22204
Conversation
8c5fbbe to
f98ea77CompareUh oh!
There was an error while loading. Please reload this page.
uranusjr
commented
Mar 13, 2022
Some ideas from how pip does this. pip fully automates the vendoring-patching process so a new version can be pulled immediately if needed. It uses vendoring for this. It takes a requirements file (a la requiurements.txt) and diff files for patches. When invoked, it downloads and extracts the package and applies the patches in the vendor directory (specified in pyproject.toml). Not sure if Airflow needs this much infrastructure (we only vendor two? dependencies and don’t generally upgrade the existing one), but could be useful if we want to go this route. |
Uh oh!
There was an error while loading. Please reload this page.
Yeah. I considered it too, but let's say we might want to do it when we see if it is needed. For now we have |
potiuk
commented
Mar 13, 2022
The Fix to cgroupspy submitted: cloudsigma/cgroupspy#14 - but the last change was 7 months ago, so I am not sure how fast it might get merged/released. |
potiuk
commented
Mar 13, 2022
I tihnk when we have more than one vendored in dependencies with significant changes and active development of the vendored-library (and when we see that such vendoring-in might be needed for at least few releases - we should consider automating it - in the case we have now with cgroupspy - I can't imagine they release new version without accepting the single |
335b4db to
2be7857Comparepotiuk
commented
Mar 13, 2022
First in-line to get finally Python 3.10 support :) |
2be7857 to
b7d4037Comparepotiuk
commented
Mar 14, 2022
b7d4037 to
83741e3Comparepotiuk
commented
Mar 17, 2022
🙏 |
Uh oh!
There was an error while loading. Please reload this page.
We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.
83741e3 to
2ec4ddbCompareThe PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
We need to vendor in cgroupspy library in order to make Airflow
compatible with Python 3.10 (see #22050) so this is the right time
to make our vendoring process more organized.
I based in parts on the readme described by
bleachpackage.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.