Add cgroupspy to _vendor folder by potiuk · Pull Request #22206 · apache/airflow

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk · 2022-03-12T15:25:16Z

This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.

This is part of the effort needed to implement Python 3.10
compatibility: #22050

This PR is based on #22204 so only look at the last commit.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

uranusjr

Need to merge the vendor structure PR first.

github-actions · 2022-03-13T03:45:12Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.

This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050

potiuk · 2022-03-20T09:55:37Z

Just random error. Parent PR already merged so this one can be merged too.

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14

The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

potiuk force-pushed the add-cgroupspy-to-vendor branch from 6631420 to 9ba74dfCompare March 12, 2022 15:26

potiuk changed the title ~~Add cgroupspy to vendor~~Add cgroupspy to _vendor folderMar 12, 2022

potiuk force-pushed the add-cgroupspy-to-vendor branch 2 times, most recently from a96efbe to f1218e1Compare March 12, 2022 15:36

potiuk requested review from ashb, dstandish, ephraimbuddy, jedcunningham, kaxil, mik-laj and turbaszek March 12, 2022 15:40

This was referenced Mar 12, 2022
Fix imports of vendored cgroupspy #22207
Merged
Fix python 3.10 support in vendored in cgroupspy #22208
Merged

potiuk requested a review from eladkal March 12, 2022 15:50

potiuk mentioned this pull request Mar 12, 2022
Switched cgroupspy to vendored version #22209
Merged

potiuk force-pushed the add-cgroupspy-to-vendor branch from f1218e1 to aca5385Compare March 12, 2022 16:17

potiuk mentioned this pull request Mar 12, 2022
Add Python 3.10 support #22050
Merged

uranusjr approved these changes Mar 13, 2022
View reviewed changes

github-actionsBot added the full tests needed We need to run full set of tests for this PR to merge label Mar 13, 2022

potiuk force-pushed the add-cgroupspy-to-vendor branch from aca5385 to 3d86b7eCompare March 13, 2022 15:03

potiuk closed this Mar 13, 2022

potiuk reopened this Mar 13, 2022

potiuk force-pushed the add-cgroupspy-to-vendor branch 2 times, most recently from 776ba16 to eff5643Compare March 14, 2022 18:25

potiuk mentioned this pull request Mar 15, 2022
Add description on the vendoring process we use #22204
Merged

potiuk added 2 commits March 19, 2022 22:06

potiuk force-pushed the add-cgroupspy-to-vendor branch from eff5643 to 7892ac9Compare March 19, 2022 21:07

potiuk merged commit 68aa019 into apache:mainMar 20, 2022

potiuk deleted the add-cgroupspy-to-vendor branch March 20, 2022 09:55

potiuk mentioned this pull request Apr 4, 2022
Unvendor cgroupspy #22736
Merged

potiuk added a commit that referenced this pull request Apr 4, 2022
Unvendor cgroupspy (#22736)
f2bdce4
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14

jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 7, 2022

potiuk restored the add-cgroupspy-to-vendor branch April 26, 2022 20:49

potiuk deleted the add-cgroupspy-to-vendor branch July 29, 2022 20:04