Uh oh!
There was an error while loading. Please reload this page.
ARROW-73: Support older CMake versions - #31
Closed
xhochy wants to merge 1 commit into
Closed
Conversation
wesm
commented
Mar 21, 2016
Member
+1, thank you |
wesm added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
This also changes the compiler options to use only SSE3. We can explore benchmarking to optionally enable SSE4 on supported systems for performance gains in the future. @nongli would it be OK if I remove the unused delta encodings (they depend on code that is not in Impala anymore, or never way)? Are these encodings used extensively, or primarily PLAIN / DICTIONARY encoding? Author: Wes McKinney <wes@cloudera.com> Closesapache#31 from wesm/PARQUET-438 and squashes the following commits: df9da64 [Wes McKinney] Add back (commented-out) ZigZig encode/decode impls 65c49bc [Wes McKinney] Fix comment 73c1dc1 [Wes McKinney] Fix cpplint errors post PARQUET-496 553ca0e [Wes McKinney] Fix cpplint errors 9528c83 [Wes McKinney] Updates RLE encoding routines and dependencies from upstream changes in Apache Impala (incubating). Add rle-test and bit-util-test modules unchanged from Impala. Change-Id: I6dd1ba027b316de945c56f70b390cf44dcf09f63
kou pushed a commit
that referenced
this pull request
May 10, 2020
This PR enables tests for `ARROW_COMPUTE`, `ARROW_DATASET`, `ARROW_FILESYSTEM`, `ARROW_HDFS`, `ARROW_ORC`, and `ARROW_IPC` (default on). #7131 enabled a minimal set of tests as a starting point. I confirmed that these tests pass locally with the current master. In the current TravisCI environment, we cannot see this result due to a lot of error messages in `arrow-utility-test`. ``` $ git log | head -1 commit ed5f534 % ctest ... Start 1: arrow-array-test 1/51 Test #1: arrow-array-test ..................... Passed 4.62 sec Start 2: arrow-buffer-test 2/51 Test #2: arrow-buffer-test .................... Passed 0.14 sec Start 3: arrow-extension-type-test 3/51 Test #3: arrow-extension-type-test ............ Passed 0.12 sec Start 4: arrow-misc-test 4/51 Test #4: arrow-misc-test ...................... Passed 0.14 sec Start 5: arrow-public-api-test 5/51 Test #5: arrow-public-api-test ................ Passed 0.12 sec Start 6: arrow-scalar-test 6/51 Test #6: arrow-scalar-test .................... Passed 0.13 sec Start 7: arrow-type-test 7/51 Test #7: arrow-type-test ...................... Passed 0.14 sec Start 8: arrow-table-test 8/51 Test #8: arrow-table-test ..................... Passed 0.13 sec Start 9: arrow-tensor-test 9/51 Test #9: arrow-tensor-test .................... Passed 0.13 sec Start 10: arrow-sparse-tensor-test 10/51 Test #10: arrow-sparse-tensor-test ............. Passed 0.16 sec Start 11: arrow-stl-test 11/51 Test #11: arrow-stl-test ....................... Passed 0.12 sec Start 12: arrow-concatenate-test 12/51 Test #12: arrow-concatenate-test ............... Passed 0.53 sec Start 13: arrow-diff-test 13/51 Test #13: arrow-diff-test ...................... Passed 1.45 sec Start 14: arrow-c-bridge-test 14/51 Test #14: arrow-c-bridge-test .................. Passed 0.18 sec Start 15: arrow-io-buffered-test 15/51 Test #15: arrow-io-buffered-test ............... Passed 0.20 sec Start 16: arrow-io-compressed-test 16/51 Test #16: arrow-io-compressed-test ............. Passed 3.48 sec Start 17: arrow-io-file-test 17/51 Test #17: arrow-io-file-test ................... Passed 0.74 sec Start 18: arrow-io-hdfs-test 18/51 Test #18: arrow-io-hdfs-test ................... Passed 0.12 sec Start 19: arrow-io-memory-test 19/51 Test #19: arrow-io-memory-test ................. Passed 2.77 sec Start 20: arrow-utility-test 20/51 Test #20: arrow-utility-test ...................***Failed 5.65 sec Start 21: arrow-threading-utility-test 21/51 Test #21: arrow-threading-utility-test ......... Passed 1.34 sec Start 22: arrow-compute-compute-test 22/51 Test #22: arrow-compute-compute-test ........... Passed 0.13 sec Start 23: arrow-compute-boolean-test 23/51 Test #23: arrow-compute-boolean-test ........... Passed 0.15 sec Start 24: arrow-compute-cast-test 24/51 Test #24: arrow-compute-cast-test .............. Passed 0.22 sec Start 25: arrow-compute-hash-test 25/51 Test #25: arrow-compute-hash-test .............. Passed 2.61 sec Start 26: arrow-compute-isin-test 26/51 Test #26: arrow-compute-isin-test .............. Passed 0.81 sec Start 27: arrow-compute-match-test 27/51 Test #27: arrow-compute-match-test ............. Passed 0.40 sec Start 28: arrow-compute-sort-to-indices-test 28/51 Test #28: arrow-compute-sort-to-indices-test ... Passed 3.33 sec Start 29: arrow-compute-nth-to-indices-test 29/51 Test #29: arrow-compute-nth-to-indices-test .... Passed 1.51 sec Start 30: arrow-compute-util-internal-test 30/51 Test #30: arrow-compute-util-internal-test ..... Passed 0.13 sec Start 31: arrow-compute-add-test 31/51 Test #31: arrow-compute-add-test ............... Passed 0.12 sec Start 32: arrow-compute-aggregate-test 32/51 Test #32: arrow-compute-aggregate-test ......... Passed 14.70 sec Start 33: arrow-compute-compare-test 33/51 Test #33: arrow-compute-compare-test ........... Passed 7.96 sec Start 34: arrow-compute-take-test 34/51 Test #34: arrow-compute-take-test .............. Passed 4.80 sec Start 35: arrow-compute-filter-test 35/51 Test #35: arrow-compute-filter-test ............ Passed 8.23 sec Start 36: arrow-dataset-dataset-test 36/51 Test #36: arrow-dataset-dataset-test ........... Passed 0.25 sec Start 37: arrow-dataset-discovery-test 37/51 Test #37: arrow-dataset-discovery-test ......... Passed 0.13 sec Start 38: arrow-dataset-file-ipc-test 38/51 Test #38: arrow-dataset-file-ipc-test .......... Passed 0.21 sec Start 39: arrow-dataset-file-test 39/51 Test #39: arrow-dataset-file-test .............. Passed 0.12 sec Start 40: arrow-dataset-filter-test 40/51 Test #40: arrow-dataset-filter-test ............ Passed 0.16 sec Start 41: arrow-dataset-partition-test 41/51 Test #41: arrow-dataset-partition-test ......... Passed 0.13 sec Start 42: arrow-dataset-scanner-test 42/51 Test #42: arrow-dataset-scanner-test ........... Passed 0.20 sec Start 43: arrow-filesystem-test 43/51 Test #43: arrow-filesystem-test ................ Passed 1.62 sec Start 44: arrow-hdfs-test 44/51 Test #44: arrow-hdfs-test ...................... Passed 0.13 sec Start 45: arrow-feather-test 45/51 Test #45: arrow-feather-test ................... Passed 0.91 sec Start 46: arrow-ipc-read-write-test 46/51 Test #46: arrow-ipc-read-write-test ............ Passed 5.77 sec Start 47: arrow-ipc-json-simple-test 47/51 Test #47: arrow-ipc-json-simple-test ........... Passed 0.16 sec Start 48: arrow-ipc-json-test 48/51 Test #48: arrow-ipc-json-test .................. Passed 0.27 sec Start 49: arrow-json-integration-test 49/51 Test #49: arrow-json-integration-test .......... Passed 0.13 sec Start 50: arrow-json-test 50/51 Test #50: arrow-json-test ...................... Passed 0.26 sec Start 51: arrow-orc-adapter-test 51/51 Test #51: arrow-orc-adapter-test ............... Passed 1.92 sec 98% tests passed, 1 tests failed out of 51 Label Time Summary: arrow-tests = 27.38 sec (27 tests) arrow_compute = 45.11 sec (14 tests) arrow_dataset = 1.21 sec (7 tests) arrow_ipc = 6.20 sec (3 tests) unittest = 79.91 sec (51 tests) Total Test time (real) = 79.99 sec The following tests FAILED: 20 - arrow-utility-test (Failed) Errors while running CTest ``` Closes#7142 from kiszk/ARROW-8754 Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zhztheplayer added a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Sep 11, 2021
zhztheplayer added a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Sep 23, 2021
This reverts commit e48da37.
zhztheplayer added a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Feb 8, 2022
zhztheplayer added a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Mar 3, 2022
rui-mo pushed a commit
to rui-mo/arrow-1
that referenced
this pull request
Mar 23, 2022
zhouyuan pushed a commit
to zhouyuan/arrow
that referenced
this pull request
Apr 26, 2022
rui-mo pushed a commit
to rui-mo/arrow-1
that referenced
this pull request
May 27, 2022
paddyroddy referenced
this pull request
in rok/arrow
Jul 19, 2025
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 20, 2026
Core statistics evaluation function for ORC predicate pushdown. This mirrors Parquet's TestRowGroups pattern. Algorithm: 1. Lock mutex for thread-safe cache access 2. Simplify predicate with partition-level guarantees 3. Resolve field references to ORC column indices via manifest 4. For each unprocessed field, load stripe statistics from ORC file 5. Derive guarantee expressions from min/max statistics 6. Combine guarantees incrementally into stripe-level cache 7. Simplify predicate with each stripe's guarantees Returns per-stripe simplified expressions: - literal(true) = must scan this stripe - literal(false) = can skip this stripe - Mixed expression = partial information available Thread-safe with mutex protection. Statistics cached incrementally as predicates reference different fields. Verified: Mirrors cpp/src/arrow/dataset/file_parquet.cc lines 933-983 Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 20, 2026
…ache#73) - Created file_orc_benchmark.cc with 5 comprehensive benchmarks - ScanAllStripes: Baseline performance measurement - ScanWithSelectiveFilter: Highly selective filter (1 stripe match) - ScanWithRangeFilter: Range filter (20% of data) - CountAllRows: Metadata-only count optimization - CountWithSelectiveFilter: Statistics-based count optimization - Benchmarks measure I/O reduction and cache benefits - Tests 3 configurations: 10K, 100K, 1M rows - Uses controlled stripe boundaries for predictable results - Single-threaded for consistent measurements - Memory-based I/O to eliminate filesystem variability - Added benchmark to CMakeLists.txt (conditional on ARROW_ORC) - Included comprehensive README with usage and implementation notes Verified: Code follows Arrow patterns, proper licensing, comprehensive coverage
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 20, 2026
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 20, 2026
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 20, 2026
- Reset cpp/src/arrow/dataset/CMakeLists.txt to original Arrow state - Remove cpp/src/arrow/dataset/file_orc_benchmark.cc - Remove cpp/src/arrow/dataset/file_orc_benchmark_README.md These were added in Task apache#31 without proper build verification.
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 24, 2026
Core statistics evaluation function for ORC predicate pushdown. This mirrors Parquet's TestRowGroups pattern. Algorithm: 1. Lock mutex for thread-safe cache access 2. Simplify predicate with partition-level guarantees 3. Resolve field references to ORC column indices via manifest 4. For each unprocessed field, load stripe statistics from ORC file 5. Derive guarantee expressions from min/max statistics 6. Combine guarantees incrementally into stripe-level cache 7. Simplify predicate with each stripe's guarantees Returns per-stripe simplified expressions: - literal(true) = must scan this stripe - literal(false) = can skip this stripe - Mixed expression = partial information available Thread-safe with mutex protection. Statistics cached incrementally as predicates reference different fields. Verified: Mirrors cpp/src/arrow/dataset/file_parquet.cc lines 933-983 Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 24, 2026
…ache#73) - Created file_orc_benchmark.cc with 5 comprehensive benchmarks - ScanAllStripes: Baseline performance measurement - ScanWithSelectiveFilter: Highly selective filter (1 stripe match) - ScanWithRangeFilter: Range filter (20% of data) - CountAllRows: Metadata-only count optimization - CountWithSelectiveFilter: Statistics-based count optimization - Benchmarks measure I/O reduction and cache benefits - Tests 3 configurations: 10K, 100K, 1M rows - Uses controlled stripe boundaries for predictable results - Single-threaded for consistent measurements - Memory-based I/O to eliminate filesystem variability - Added benchmark to CMakeLists.txt (conditional on ARROW_ORC) - Included comprehensive README with usage and implementation notes Verified: Code follows Arrow patterns, proper licensing, comprehensive coverage
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 24, 2026
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 24, 2026
cbb330 added a commit
to cbb330/arrow
that referenced
this pull request
Feb 24, 2026
- Reset cpp/src/arrow/dataset/CMakeLists.txt to original Arrow state - Remove cpp/src/arrow/dataset/file_orc_benchmark.cc - Remove cpp/src/arrow/dataset/file_orc_benchmark_README.md These were added in Task apache#31 without proper build verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.