Flexibilize public IP selection by erikbocks · Pull Request #11076 · apache/cloudstack

erikbocks · 2025-06-23T16:54:01Z

Description

Currently, when a public IP allocation request is made, the quarantined_ips table is ignored during the selection process. Instead, the system selects an IP without checking its quarantine status, and only validates if the IP is quarantined afterward, throwing an exception if it is.

This causes repeated failures for automatic IP selections, as the same IP will be chosen over and over, until the quarantine period ends.

This PR fixes this behaviour by considering the quarantined_ips table during the selection process, and choosing only an allocatable IP. It also brings a minor improvement to the IP quarantine logic, where IPs that were not removed either in active quarantine, were not set removed when allocated.

Now, when these IPs are allocated, the removed column is updated and the removal reason is set to: IP was removed from quarantine because it was no longer in quarantine. The PR also does a little code refactor, improving its legibility and dropping the usage of deprecated methods.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

I made the following tests:

N°	Test case	Result	Expected? (Y/N)
1	Allocate an IP to a VR	IP was allocated successfully	Y
2	Allocate an IP to a System VM	IP was allocated successfully	Y
3	Allocate a specific IP to a VR	IP was allocated successfully	Y
4	Allocate an IP to a VR, but, all the IPs are already allocated	Exception was thrown displaying insufficient address capacity	Y
5	Allocate a specific quarantined IP, but, its quarantine is due.	IP was allocated successfully	Y
6	Allocate a specific quarantined IP, but, it is in active quarantine.	Exception was thrown displaying insufficient address capacity.	Y
7	Allocate a specific quarantined IP, but, the caller is the previous owner	IP was allocated successfully	Y
8	Allocated a specific quarantined IP, but, the previous owner is different than the caller	Exception was thrown displaying insufficient address capacity.	Y

codecov · 2025-06-23T18:29:34Z

Codecov Report

❌ Patch coverage is 10.52632% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.25%. Comparing base (56dc119) to head (700ca23).
⚠️ Report is 34 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/network/IpAddressManagerImpl.java	13.63%	38 Missing ⚠️
...m/cloud/network/dao/PublicIpQuarantineDaoImpl.java	0.00%	13 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #11076 +/- ##
============================================
- Coverage 16.25% 16.25% -0.01% + Complexity 13425 13412 -13 
============================================
Files 5662 5664 +2 Lines 500167 500485 +318 Branches 60740 60780 +40 ============================================
+ Hits 81318 81334 +16 - Misses 409763 410056 +293 - Partials 9086 9095 +9

Flag	Coverage Δ
uitests	`4.15% <ø> (ø)`
unittests	`17.10% <10.52%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland · 2025-07-13T19:18:06Z

@blueorangutan package

blueorangutan · 2025-07-13T19:20:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-13T20:42:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14153

DaanHoogland · 2025-07-14T10:39:58Z

@blueorangutan LLtest

blueorangutan · 2025-07-14T10:42:03Z

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2025-12-12T09:22:56Z

@erikbocks , do you still want to move this forwards?

erikbocks · 2025-12-12T12:56:57Z

Hello, @DaanHoogland

Yes, I wish to move forward with this PR. It is currently waiting for reviews.

winterhazel · 2026-02-03T11:30:50Z

@erikbocks can this go into 4.20.3?

erikbocks · 2026-02-12T23:37:46Z

@bernardodemarco I checked the code for the OR operator (#11076 (comment)) use cases and could not find a flow that needed it. Therefore, I removed it.

@winterhazel, sure, I will re-target the PR.

sureshanaparti · 2026-02-13T04:43:20Z

@blueorangutan package

blueorangutan · 2026-02-13T04:44:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-13T05:35:38Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16819

sureshanaparti · 2026-02-13T05:47:36Z

@blueorangutan package

blueorangutan · 2026-02-13T05:48:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-13T06:52:53Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16824

kiranchavala · 2026-03-10T08:35:36Z

@blueorangutan test

blueorangutan · 2026-03-10T08:36:03Z

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

kiranchavala

LGTM Tested manually

Steps followed

Log in as Admin user , set the global setting "public.ip.address.quarantine.duration" to some value , say 5
Create a network
Acquire a public ip for the network
Release the public ip for the network
Check the list quarantinedips api call

(localcloud) 🐱 > list quarantinedips
{
"count": 1,
"quarantinedips": [
{
"created": "2026-03-10T09:48:08+0000",
"enddate": "2026-03-10T09:53:08+0000",
"id": "ae522276-dbe9-48a4-8641-42f56d0db188",
"ipaddress": "10.0.54.227",
"previousownerid": "1c27a164-1bba-11f1-a8c7-1e001c00015d",
"previousownername": "admin"
}
]
}

Login as user account and to acquire the same ip

(user) 🐱 > associate ipaddress networkid=a6bd451b-4510-4409-a6b1-dede684acf70 ipaddress=10.0.54.227
🙈 Error: (HTTP 533, error code 9999) Failed to allocate public IP address [10.0.54.227] as it is in quarantine.

Check the logs

2026-03-10 09:49:00,362 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-26:[ctx-eed29790, ctx-051b6cd9, ctx-a5d60cb1]) (logid:a450d1c0) Associate IP address called by the user User {"id":4,"username":"user","uuid":"2e631c48-bc70-4465-9231-589776697cbd"}. account Account [{"accountName":"ACSUser","id":4,"uuid":"a1c041d3-aa43-4eb9-bb21-91b146751fc8"}]
2026-03-10 09:49:00,367 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-26:[ctx-eed29790, ctx-051b6cd9, ctx-a5d60cb1]) (logid:a450d1c0) Associate IP address lock acquired
2026-03-10 09:49:00,374 ERROR [c.c.n.IpAddressManagerImpl] (qtp1390913202-26:[ctx-eed29790, ctx-051b6cd9, ctx-a5d60cb1]) (logid:a450d1c0) Public IP address [IPAddress {"address":"10.0.54.227","dataCenterId":1,"id":7,"uuid":"13360e92-3fca-4c2a-9b06-631cdc193c48"}] is in quarantine and the previous owner [Account [{"accountName":"admin","id":2,"uuid":"1c27a164-1bba-11f1-a8c7-1e001c00015d"}]] is different than the new owner [Account [{"accountName":"ACSUser","id":4,"uuid":"a1c041d3-aa43-4eb9-bb21-91b146751fc8"}]]; therefore, the IP cannot be allocated.

After fix

A check is performed on the quarantined public IPs

Follow the same steps till 6 and check the logs

(user) 🐱 > associate ipaddress ipaddress=10.0.53.8 networkid=32783a23-3880-49b2-9ea0-bc0fcc67a78d
🙈 Error: (HTTP 533, error code 9999) Insufficient address capacity

logs

2026-03-10 10:05:25,495 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-a3d8634b, ctx-13a7db14, ctx-52131ac1]) (logid:21fff657) Associate IP address called by the user User {"id":4,"username":"user","uuid":"43b36f6f-dbee-4d18-90f7-f6bc46d86b18"}. account Account [{"accountName":"ACSUser","id":4,"uuid":"495f75ba-9685-431e-a996-dce4ad11e915"}]
2026-03-10 10:05:25,503 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-a3d8634b, ctx-13a7db14, ctx-52131ac1]) (logid:21fff657) Associate IP address lock acquired
2026-03-10 10:05:25,505 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-a3d8634b, ctx-13a7db14, ctx-52131ac1]) (logid:21fff657) Listing quarantined public IPs to ignore on search for public IP for system VM. The IPs ignored will be the ones that: were not associated to account [495f75ba-9685-431e-a996-dce4ad11e915]; were not removed yet; and with quarantine end dates after [2026-03-10T10:05:25.505+0000].
2026-03-10 10:05:25,506 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-a3d8634b, ctx-13a7db14, ctx-52131ac1]) (logid:21fff657) Found addresses with the following IDs: [[8]] that will be ignored when searching for available public IPs.
2026-03-10 10:05:25,510 WARN [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-a3d8634b, ctx-13a7db14, ctx-52131ac1]) (logid:21fff657) Unable to get ip address in zone id=1: requested ip 10.0.53.8 is not available, vlanId id=[1]
2026-03-10 10:05:25,511 DEBUG [c.c.u.d.T.Transaction] (qtp1390913202-22:[ctx-a3d8634b, ctx-13a7db14, ctx-52131ac1]) (logid:21fff657) Rolling back the transaction: Time = 7 Name = qtp1390913202-22; called by -TransactionLegacy.rollback:905-TransactionLegacy.removeUpTo:848-TransactionLegacy.close:672-Transaction.execute:36-IpAddressManagerImpl.allocateIp:1461-NetworkServiceImpl.allocateIP:760-NativeMethodAccessorImpl.invoke0:-2-NativeMethodAccessorImpl.invoke:77-DelegatingMethodAccessorImpl.invoke:43-Method.invoke:569-AopUtils.invokeJoinpointUsingReflection:344-ReflectiveMethodInvocation.invokeJoinpoint:198
2026-03-10 10:05:25,511 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-a3d8634b, ctx-13a7db14, ctx-52131ac1]) (logid:21fff657) Releasing lock account Account [{"accountName":"ACSUser","id":4,"uuid":"495f75ba-9685-431e-a996-dce4ad11e915"}]

After the quaratined time period

Acquire the ip again

(user) 🐱 > associate ipaddress ipaddress=10.0.53.8 networkid=32783a23-3880-49b2-9ea0-bc0fcc67a78d
{
"ipaddress": {
"account": "ACSUser",
"allocated": "2026-03-10T10:07:13+0000",
"associatednetworkid": "32783a23-3880-49b2-9ea0-bc0fcc67a78d",
"associatednetworkname": "test-user",
"domain": "ROOT",
"domainid": "96db227a-1c3b-11f1-b617-1e00ef000409",
"domainpath": "ROOT",
"forprovider": false,
"forsystemvms": false,
"forvirtualnetwork": true,
"hasannotations": false,
"hasrules": false,
"id": "4b422a8a-3c6b-4bbe-89c3-b4443b27cf05",
"ipaddress": "10.0.53.8",
"isportable": false,
"issourcenat": true,
"isstaticnat": false,
"issystem": false,
"networkid": "ae0943e0-4224-4c70-9202-ef66ea101ac1",
"physicalnetworkid": "47de6a83-8133-402a-81fb-0115bd21807b",
"state": "Allocating",
"tags": [],
"zoneid": "8f62ed3d-b638-4ffb-a6bb-b7b9ca6b1894",
"zonename": "ref-trl-11274-k-Mol8-kiran-chavala"
}

Ip get's acquired successly

logs

2026-03-10 10:07:13,931 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) Associate IP address called by the user User {"id":4,"username":"user","uuid":"071777ff-f542-460e-b9ae-c92b91bced88"}. account Account [{"accountName":"ACSUser","id":4,"uuid":"495f75ba-9685-431e-a996-dce4ad11e915"}]
2026-03-10 10:07:13,935 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) Associate IP address lock acquired
2026-03-10 10:07:13,937 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) Listing quarantined public IPs to ignore on search for public IP for system VM. The IPs ignored will be the ones that: were not associated to account [495f75ba-9685-431e-a996-dce4ad11e915]; were not removed yet; and with quarantine end dates after [2026-03-10T10:07:13.937+0000].
2026-03-10 10:07:13,938 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) Found addresses with the following IDs: [[]] that will be ignored when searching for available public IPs.
2026-03-10 10:07:13,941 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) Public IP address [IPAddress {"address":"10.0.53.8","dataCenterId":1,"id":8,"uuid":"4b422a8a-3c6b-4bbe-89c3-b4443b27cf05"}] is no longer in quarantine; therefore, it is allowed to be allocated.
2026-03-10 10:07:13,946 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) Removing public IP Address [10.0.53.8] from quarantine by updating the removed date to [2026-03-10T10:07:13.943+0000].
2026-03-10 10:07:13,953 DEBUG [c.c.r.ResourceLimitManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) Checking if amount of resources of Type = 'public_ip', tag = 'null' for Account Name = ACSUser in Domain Id = 1 is exceeded: Account Resource Limit = 20, Current Account Resource Amount = 0, Current Account Resource Reservation = 0, Requested Resource Amount = 1.
2026-03-10 10:07:13,954 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) trying ip address 10.0.53.8
2026-03-10 10:07:13,957 DEBUG [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) locked row for ip address 10.0.53.8 (id: 4b422a8a-3c6b-4bbe-89c3-b4443b27cf05)
2026-03-10 10:07:13,958 INFO [c.c.n.IpAddressManagerImpl] (qtp1390913202-22:[ctx-3a8ee98b, ctx-345c5e95, ctx-b82d675e]) (logid:9ded10b0) successfully allocated ip address 10.0.53.8

DB

mysql> select * from quarantined_ips;
+----+--------------------------------------+----------------------+-------------------+---------------------+---------------------+---------------------+------------------------------------------------------------------------+--------------------+
| id | uuid | public_ip_address_id | previous_owner_id | created | removed | end_date | removal_reason | remover_account_id |
+----+--------------------------------------+----------------------+-------------------+---------------------+---------------------+---------------------+------------------------------------------------------------------------+--------------------+
| 1 | ac02748a-1244-4e18-a4c6-dd46789a124b | 8 | 2 | 2026-03-10 10:03:27 | 2026-03-10 10:07:13 | 2026-03-10 10:06:27 | IP was removed from quarantine because it was no longer in quarantine. | 4 |
+----+--------------------------------------+----------------------+-------------------+---------------------+---------------------+---------------------+------------------------------------------------------------------------+--------------------+
1 row in set (0.00 sec)

bernardodemarco · 2026-03-12T12:57:23Z

@erikbocks, I believe it is worth it to take a look at these test errors: #11076 (comment). They seem to be related.

erikbocks · 2026-03-18T18:44:35Z

Hello, @DaanHoogland, @bernardodemarco

After running the tests locally, I found that the errors in the integration tests were due to the error message returned as a response:

2026-03-18 15:05:20,923 - CRITICAL - FAILED: test_only_owner_can_allocate_ip_in_quarantine_vpc: ['Traceback (most recent call last):\n', ' File "/usr/lib/python3.11/unittest/case.py", line 57, in testPartExecutor\n yield\n', ' File "/usr/lib/python3.11/unittest/case.py", line 623, in run\n self._callTestMethod(testMethod)\n', ' File "/usr/lib/python3.11/unittest/case.py", line 579, in _callTestMethod\n if method() is not None:\n ^^^^^^^^\n', ' File "/home/erik/test_quarantined_ips.py", line 171, in test_only_owner_can_allocate_ip_in_quarantine_vpc\n self.assertIn(f"Failed to allocate public IP [{ip_address}] as it is in quarantine.",\n', ' File "/usr/lib/python3.11/unittest/case.py", line 1140, in assertIn\n self.fail(self._formatMessage(msg, standardMsg))\n', ' File "/usr/lib/python3.11/unittest/case.py", line 703, in fail\n raise self.failureException(msg)\n', "AssertionError: 'Failed to allocate public IP [192.168.122.31] as it is in quarantine.' not found in 'Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity'\n"]

As it can be seen in the error message above, the test's assert expected the message to be Failed to allocate public IP [192.168.122.31] as it is in quarantine., and the Insufficient address capacity message was being returned. The message discrepancy was due to this exception treatment present at the ApiServer class.

cloudstack/server/src/main/java/com/cloud/api/ApiServer.java

Lines 727 to 734 in b744824

 } catch (finalInsufficientCapacityExceptionex) { 
logger.info(ex.getMessage()); 
StringerrorMsg = ex.getMessage(); 
if (!accountMgr.isRootAdmin(CallContext.current().getCallingAccount().getId())) { 
// hide internal details to non-admin user for security reason
errorMsg = BaseCmd.USER_ERROR_MESSAGE; 
 } 
thrownewServerApiException(ApiErrorCode.INSUFFICIENT_CAPACITY_ERROR, errorMsg, ex); 

In order to prevent that any future changes to exceptions treatments or messages could cause the same behavior, I changed the tests to search for the custom 533 code returned for every InsufficientCapacityException type exceptions response.

I already ran the tests locally and they all passed successfully, but may we run the tests again? @DaanHoogland

weizhouapache · 2026-03-18T19:38:38Z

@blueorangutan package

blueorangutan · 2026-03-18T19:40:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-18T20:21:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 17192

DaanHoogland · 2026-03-19T15:34:10Z

@erikbocks , you were removed from the collaborators list recently, should we re-add you?

erikbocks · 2026-03-19T17:18:02Z

@DaanHoogland, I am still at the collaborators list, actually. Regarding the paused CI tests, I think that maybe it was because the job was triggered by my other account, that is not included at the collaborators.

DaanHoogland · 2026-03-20T08:25:16Z

@DaanHoogland, I am still at the collaborators list, actually. Regarding the paused CI tests, I think that maybe it was because the job was triggered by my other account, that is not included at the collaborators.

ok, let us know if you want the account from the contributors list changed.

winterhazel · 2026-03-31T13:24:18Z

@DaanHoogland can we rerun the smoke tests?

DaanHoogland · 2026-03-31T15:23:30Z

@blueorangutan package

blueorangutan · 2026-03-31T15:24:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-31T16:21:14Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17313

DaanHoogland · 2026-04-01T13:12:55Z

@blueorangutan test

blueorangutan · 2026-04-01T13:14:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-04-02T04:21:44Z

[SF] Trillian test result (tid-15796)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51464 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11076-t15796-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	177.62	test_routers_network_ops.py

erikbocks · 2026-04-16T14:31:48Z

@DaanHoogland, the test failed because it could not retrieve google page with curl (which does not seems related to the PR for me). Could we run the tests again to see if they all pass this time?

DaanHoogland · 2026-04-17T06:25:14Z

@DaanHoogland, the test failed because it could not retrieve google page with curl (which does not seems related to the PR for me). Could we run the tests again to see if they all pass this time?

started

blueorangutan · 2026-04-17T22:07:56Z

[SF] Trillian test result (tid-15909)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53516 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11076-t15909-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

* 4.20: Fix/flasharray delete rename destroy patch conflict (#13049) Fix VPC network offerings listing in isolated network creation form (#12645) Update mysql java connector version to 8.4.0 (matching version for MySQL 8.4) (#12640) adaptive: honor user-provided capacityBytes when provider stats are unavailable (#13059) Flexibilize public IP selection (#11076)

* 4.22: VM Deployment using snapshot in new zone (#13178) Change exception treatment on incremental snapshot wait (#12665) Move checkRoleEscalation outside DB transaction in createAccount (#13044) Fix/flasharray delete rename destroy patch conflict (#13049) Fix VPC network offerings listing in isolated network creation form (#12645) systemvm: accept ipv6 established/related return traffic (#13173) update debian change log Updating pom.xml version numbers for release 4.22.2.0-SNAPSHOT Updating pom.xml version numbers for release 4.22.1.0 Update suse15 packaging spec, use qemu-ovmf-x86_64 package instead of edk2-ovmf for agent (#13133) Change disk-only VM snapshot removal message (#11182) Update mysql java connector version to 8.4.0 (matching version for MySQL 8.4) (#12640) adaptive: honor user-provided capacityBytes when provider stats are unavailable (#13059) Flexibilize public IP selection (#11076)

boring-cyborgBot added the component:networking label Jun 23, 2025

DaanHoogland reviewed Jun 24, 2025
View reviewed changes

Comment threadengine/schema/src/main/java/com/cloud/network/dao/PublicIpQuarantineDaoImpl.java Outdated

DaanHoogland added status:needs-review status:needs-testing labels Dec 12, 2025

bernardodemarco reviewed Jan 9, 2026
View reviewed changes

Comment threadengine/schema/src/main/java/com/cloud/network/dao/PublicIpQuarantineDao.java Outdated
Comment threadengine/schema/src/main/java/com/cloud/network/dao/PublicIpQuarantineDaoImpl.java Outdated
Comment threadserver/src/main/java/com/cloud/network/IpAddressManagerImpl.java Outdated

bernardodemarco added this to the 4.23.0 milestone Jan 9, 2026

erik-bock-silva force-pushed the enhance-ip-selection-guest-network branch from 4975e0b to d5d4aa9Compare February 12, 2026 23:54

erikbocks changed the base branch from main to 4.22February 12, 2026 23:55

kiranchavala self-assigned this Mar 10, 2026

kiranchavala approved these changes Mar 10, 2026
View reviewed changes

kiranchavala added status:ready-for-merge and removed status:needs-testing labels Mar 10, 2026

winterhazel added status:waiting-for-author and removed status:ready-for-merge labels Mar 17, 2026

Fix quarantined IPs integration test logic
700ca23

boring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Mar 18, 2026

erikbocks added status:ready-for-merge and removed status:waiting-for-author labels Mar 19, 2026

DaanHoogland modified the milestones: 4.23.0, 4.20.4 Apr 17, 2026

DaanHoogland merged commit 9f96c9d into apache:4.20Apr 21, 2026
21 of 26 checks passed

Uh oh!

Conversation

erikbocks commented Jun 23, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

codecovBot commented Jun 23, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

DaanHoogland commented Jul 13, 2025

Uh oh!

blueorangutan commented Jul 13, 2025

Uh oh!

blueorangutan commented Jul 13, 2025

Uh oh!

DaanHoogland commented Jul 14, 2025

Uh oh!

blueorangutan commented Jul 14, 2025

Uh oh!

DaanHoogland commented Dec 12, 2025

Uh oh!

erikbocks commented Dec 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

winterhazel commented Feb 3, 2026

Uh oh!

erikbocks commented Feb 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sureshanaparti commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

sureshanaparti commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

blueorangutan commented Feb 13, 2026

Uh oh!

kiranchavala commented Mar 10, 2026

Uh oh!

blueorangutan commented Mar 10, 2026

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

bernardodemarco commented Mar 12, 2026

Uh oh!

erikbocks commented Mar 18, 2026

Uh oh!

weizhouapache commented Mar 18, 2026

Uh oh!

blueorangutan commented Mar 18, 2026

Uh oh!

blueorangutan commented Mar 18, 2026

Uh oh!

DaanHoogland commented Mar 19, 2026

Uh oh!

erikbocks commented Mar 19, 2026

Uh oh!

DaanHoogland commented Mar 20, 2026

Uh oh!

winterhazel commented Mar 31, 2026

Uh oh!

DaanHoogland commented Mar 31, 2026

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

DaanHoogland commented Apr 1, 2026

codecovBot commented Jun 23, 2025•
edited
Loading

erikbocks commented Feb 12, 2026•
edited
Loading