Skip to content

VM Deployment using snapshot in new zone - #13178

Merged
DaanHoogland merged 3 commits into
apache:4.22from
shapeblue:ghi12443-deployFromTemplateInNewZone
May 21, 2026
Merged

VM Deployment using snapshot in new zone#13178
DaanHoogland merged 3 commits into
apache:4.22from
shapeblue:ghi12443-deployFromTemplateInNewZone

Conversation

@DaanHoogland

@DaanHooglandDaanHoogland commented May 18, 2026

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #12443

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
DaanHoogland requested a review from CopilotMay 18, 2026 08:14
@DaanHoogland
DaanHoogland requested review from ingox and yadvrMay 18, 2026 08:14
@DaanHooglandDaanHoogland added this to the 4.22.2 milestone May 18, 2026
vishesh92
vishesh92 reviewed May 18, 2026
View reviewed changes
Comment threadserver/src/test/java/com/cloud/vm/UserVmManagerImplTest.java Outdated
@codecov

codecovBot commented May 18, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (a289bb0) to head (d9c03a1).

Files with missing linesPatch %Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java33.33%20 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## 4.22 #13178 +/- ##
============================================
- Coverage 17.67% 17.67% -0.01% 
Complexity 15792 15792 ============================================
Files 5922 5922 Lines 533123 533129 +6 Branches 65201 65205 +4 ============================================
- Hits 94246 94242 -4 - Misses 428236 428242 +6 - Partials 10641 10645 +4
FlagCoverage Δ
uitests3.69% <ø> (ø)
unittests18.75% <33.33%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CopilotAI reviewed May 18, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@DaanHoogland
DaanHoogland requested a review from CopilotMay 18, 2026 08:55
CopilotAI reviewed May 18, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadserver/src/test/java/com/cloud/vm/UserVmManagerImplTest.java Outdated
Comment threadserver/src/test/java/com/cloud/vm/UserVmManagerImplTest.java Outdated
Comment threadserver/src/main/java/com/cloud/vm/UserVmManagerImpl.java
} else if (templateId == null) {
throw new InvalidParameterValueException(
"Could not determine template from snapshot id=" + cmd.getSnapshotId() +
"; the source volume no longer exists. Please specify a templateId.");
@vishesh92vishesh92 linked an issue May 18, 2026 that may be closed by this pull request
VM Deployment using snapshot fails for local storage zone #12443
Closed
vishesh92
vishesh92 approved these changes May 18, 2026
View reviewed changes

@vishesh92vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. didn't test.

@DaanHoogland
DaanHoogland requested a review from CopilotMay 18, 2026 10:41

This comment was marked as duplicate.

Sign in to view

@DaanHoogland
DaanHoogland requested a review from CopilotMay 18, 2026 11:30

This comment was marked as duplicate.

Sign in to view

@DaanHoogland
DaanHoogland requested a review from CopilotMay 18, 2026 11:55
@DaanHooglandDaanHoogland mentioned this pull request May 18, 2026
Closed

This comment was marked as duplicate.

Sign in to view

@blueorangutan

blueorangutan commented May 18, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17897

@DaanHoogland
DaanHoogland requested a review from CopilotMay 19, 2026 07:09
CopilotAI reviewed May 19, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

vladimirpetrov
vladimirpetrov approved these changes May 20, 2026
View reviewed changes

@vladimirpetrovvladimirpetrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was able to reproduce the issue using the much easier steps, provided by @ingox:

Single zone environment, NFS and local storage pools (not sure if it's related), deploy a VM, create root volume snapshot, try to deploy a new VM using this snapshot. It fails with 'Deployment of virtual machine is supported only for Zone-wide storage pools' error message but it works fine with the patched code.

@DaanHoogland
DaanHoogland merged commit d1e1aa5 into apache:4.22May 21, 2026
25 of 26 checks passed
@DaanHoogland
DaanHoogland deleted the ghi12443-deployFromTemplateInNewZone branch May 21, 2026 12:36
winterhazel added a commit that referenced this pull request May 22, 2026
@winterhazel
Merge release branch 4.22 to main
67b849f
 * 4.22:
VM Deployment using snapshot in new zone (#13178)
Change exception treatment on incremental snapshot wait (#12665)
Move checkRoleEscalation outside DB transaction in createAccount (#13044)
Fix/flasharray delete rename destroy patch conflict (#13049)
Fix VPC network offerings listing in isolated network creation form (#12645)
systemvm: accept ipv6 established/related return traffic (#13173)
update debian change log
Updating pom.xml version numbers for release 4.22.2.0-SNAPSHOT
Updating pom.xml version numbers for release 4.22.1.0
Update suse15 packaging spec, use qemu-ovmf-x86_64 package instead of edk2-ovmf for agent (#13133)
Change disk-only VM snapshot removal message (#11182)
Update mysql java connector version to 8.4.0 (matching version for MySQL 8.4) (#12640)
adaptive: honor user-provided capacityBytes when provider stats are unavailable (#13059)
Flexibilize public IP selection (#11076)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@vishesh92vishesh92vishesh92 approved these changes
@vladimirpetrovvladimirpetrovvladimirpetrov approved these changes
@yadvryadvrAwaiting requested review from yadvr
@ingoxingoxAwaiting requested review from ingox

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

VM Deployment using snapshot fails for local storage zone

5 participants

@DaanHoogland@blueorangutan@vishesh92@vladimirpetrov