Change exception treatment on incremental snapshot wait by JoaoJandre · Pull Request #12665 · apache/cloudstack

JoaoJandre · 2026-02-19T13:02:51Z

Description

During the KVM incremental volume snapshot creation process, ACS waits for Libvirt's backup-begin command to finish; during this period, there is a possibility that the thread that is waiting is interrupted, if that happens, an exception is thrown and the snapshot fails.

This PR changes the exception handling so that the thread only informs that it was interrupted in the logs and goes back to waiting for the Libvirt process to finish.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-02-19T13:12:00Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (7aa0558) to head (99d3ce4).
⚠️ Report is 141 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.22 #12665 +/- ##
=========================================
Coverage 17.61% 17.61% - Complexity 15664 15665 +1 
=========================================
Files 5917 5917 Lines 531402 531402 Branches 64971 64971 =========================================
Hits 93596 93596 Misses 427252 427252 Partials 10554 10554

Flag	Coverage Δ
uitests	`3.70% <ø> (ø)`
unittests	`18.68% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache

code lgtm

Copilot

Pull request overview

This PR addresses a bug in the KVM incremental volume snapshot creation process where thread interruptions during the wait for Libvirt's backup-begin command would cause snapshot failures. The change modifies the exception handling to log interruptions and continue waiting instead of throwing an exception.

Changes:

Modified exception handling in waitForBackup() to log InterruptedException at trace level and continue waiting instead of throwing CloudRuntimeException

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JoaoJandre · 2026-02-23T16:36:30Z

@blueorangutan package

blueorangutan · 2026-02-23T16:38:10Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-23T17:38:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16916

sureshanaparti

clgtm

sureshanaparti · 2026-02-26T05:09:52Z

@JoaoJandre Can you rebase with 4.22 if this fix can go in 4.22.1? any advise on testing this?

JoaoJandre · 2026-03-06T12:13:41Z

@JoaoJandre Can you rebase with 4.22 if this fix can go in 4.22.1? any advise on testing this?

Yes, I can do it soon.

There is not much to test here. I was having a problem with this situation in my environment and decided to patch it. I don't know how to reproduce, as I am not sure why my threads were getting interrupted sometimes 🤷‍♂️ .

sureshanaparti · 2026-03-06T12:16:24Z

@blueorangutan test

blueorangutan · 2026-03-06T12:18:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-03-07T03:37:28Z

[SF] Trillian test result (tid-15575)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52408 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12665-t15575-kvm-ol8.zip
Smoke tests completed. 146 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_LoginApiDomain	`Error`	7.04	test_accounts.py
ContextSuite context=TestListIdsParams>:teardown	`Error`	1.13	test_list_ids_parameter.py
test_01_snapshot_root_disk	`Error`	4.99	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	49.79	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	49.79	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	`Error`	26.82	test_snapshots.py
test_01_snapshot_usage	`Error`	18.60	test_usage.py
test_01_vpn_usage	`Error`	1.09	test_usage.py

…/storage/KVMStorageProcessor.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

JoaoJandre · 2026-03-09T16:43:51Z

@blueorangutan package

blueorangutan · 2026-03-09T16:46:04Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-09T17:36:54Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17052

JoaoJandre · 2026-03-10T11:39:57Z

@sureshanaparti could we run the CI again?

DaanHoogland · 2026-03-10T14:04:47Z

@sureshanaparti could we run the CI again?

note that there are existing errors, but will do

DaanHoogland · 2026-03-10T14:04:58Z

@blueorangutan test

blueorangutan · 2026-03-10T14:06:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-03-11T06:15:02Z

[SF] Trillian test result (tid-15594)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55142 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12665-t15594-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	`Error`	1.11	test_list_ids_parameter.py
test_01_snapshot_root_disk	`Error`	5.76	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	47.37	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	47.37	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	`Error`	27.29	test_snapshots.py
test_01_snapshot_usage	`Error`	23.78	test_usage.py
test_01_vpn_usage	`Error`	1.07	test_usage.py

* 4.22: VM Deployment using snapshot in new zone (#13178) Change exception treatment on incremental snapshot wait (#12665) Move checkRoleEscalation outside DB transaction in createAccount (#13044) Fix/flasharray delete rename destroy patch conflict (#13049) Fix VPC network offerings listing in isolated network creation form (#12645) systemvm: accept ipv6 established/related return traffic (#13173) update debian change log Updating pom.xml version numbers for release 4.22.2.0-SNAPSHOT Updating pom.xml version numbers for release 4.22.1.0 Update suse15 packaging spec, use qemu-ovmf-x86_64 package instead of edk2-ovmf for agent (#13133) Change disk-only VM snapshot removal message (#11182) Update mysql java connector version to 8.4.0 (matching version for MySQL 8.4) (#12640) adaptive: honor user-provided capacityBytes when provider stats are unavailable (#13059) Flexibilize public IP selection (#11076)

boring-cyborgBot added the component:kvm label Feb 19, 2026

weizhouapache approved these changes Feb 19, 2026
View reviewed changes

weizhouapache requested a review from Copilot February 19, 2026 13:44

Copilotstarted reviewing on behalf of weizhouapache February 19, 2026 13:45 View session

CopilotAI reviewed Feb 19, 2026
View reviewed changes

Comment threadplugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
Comment threadplugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

DaanHoogland approved these changes Feb 23, 2026
View reviewed changes

sureshanaparti approved these changes Feb 26, 2026
View reviewed changes

JoaoJandre changed the base branch from main to 4.22March 9, 2026 16:41

boring-cyborgBot added component:agent component:api component:build component:integration labels Mar 9, 2026

JoaoJandreand others added 2 commits March 9, 2026 13:42

Update plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm…
b2c0083
…/storage/KVMStorageProcessor.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ignore exception
99d3ce4

JoaoJandre force-pushed the ignore-exception branch from aef2026 to 99d3ce4Compare March 9, 2026 16:43

winterhazel added this to the 4.22.2 milestone May 1, 2026

winterhazel added the status:ready-for-merge label May 13, 2026

winterhazel merged commit 35ac91e into apache:4.22May 19, 2026
19 of 26 checks passed

winterhazel removed the status:ready-for-merge label May 19, 2026

Uh oh!

Conversation

JoaoJandre commented Feb 19, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Feb 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

JoaoJandre commented Feb 23, 2026

Uh oh!

blueorangutan commented Feb 23, 2026

Uh oh!

blueorangutan commented Feb 23, 2026

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Feb 26, 2026

Uh oh!

JoaoJandre commented Mar 6, 2026

Uh oh!

sureshanaparti commented Mar 6, 2026

Uh oh!

blueorangutan commented Mar 6, 2026

Uh oh!

blueorangutan commented Mar 7, 2026

Uh oh!

JoaoJandre commented Mar 9, 2026

Uh oh!

blueorangutan commented Mar 9, 2026

Uh oh!

blueorangutan commented Mar 9, 2026

Uh oh!

JoaoJandre commented Mar 10, 2026

Uh oh!

DaanHoogland commented Mar 10, 2026

Uh oh!

DaanHoogland commented Mar 10, 2026

Uh oh!

blueorangutan commented Mar 10, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecovBot commented Feb 19, 2026•
edited
Loading