Skip to content

UEFI fixes and comments addressed - #3983

Closed
DaanHoogland wants to merge 2 commits into
apache:masterfrom
shapeblue:uefisupport-fixes
Closed

UEFI fixes and comments addressed#3983
DaanHoogland wants to merge 2 commits into
apache:masterfrom
shapeblue:uefisupport-fixes

Conversation

@DaanHoogland

@DaanHooglandDaanHoogland commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

Description

This is an attempt to address vmware issues with #3638, to prevent having to revert the entire PR. see #3978 for the issue.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHooglandDaanHoogland changed the title fixes and comments addressedUEFI fixes and comments addressedMar 23, 2020
@DaanHooglandDaanHoogland added this to the 4.14.0.0 milestone Mar 23, 2020
@DaanHooglandDaanHoogland mentioned this pull request Mar 23, 2020
5 tasks
@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@apacheapache deleted a comment from blueorangutanMar 23, 2020
@apacheapache deleted a comment from blueorangutanMar 23, 2020
@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1079

@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan help

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala']

@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan test centos7 vmware-67u3

@apacheapache deleted a comment from blueorangutanMar 24, 2020
@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

@pavanaravapalli I saw #3985. happy to go with that, but please consider the changes here as well as they address some of the comments made. Let me know and I'll close this.

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1290)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31687 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3983-t1290-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_add_delete_kubernetes_supported_versionError0.18test_kubernetes_supported_versions.py

@DaanHooglandDaanHoogland removed this from the 4.14.0.0 milestone Mar 25, 2020
@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

similar code merged in #3985,
remaining will be added to #4021

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@DaanHoogland@blueorangutan@weizhouapache@svenvogel