[UI] Add option to specify account/project while deploying VMs and creating networks by BryanMLima · Pull Request #8919 · apache/cloudstack

BryanMLima · 2024-04-15T19:17:06Z

Description

This PR adds a new component (OwnershipSelection) to specify the account/project when creating a VM and networks (can also be used for other resources in the future). This component makes it easy for operators with roles Admin and Domain Admin to create VMs for any account and/or project that it has permission.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

I deployed a number of VMs using different accounts and projects in different domains.

How did you try to break this feature and the system with this change?

I tried to verify that the UI only showed the permissions according to the account/project selected.

DaanHoogland · 2024-04-16T06:08:27Z

@BryanMLima , have you also logged in as the other user to manipulate/delete the resources created? (nice feature btw)

DaanHoogland · 2024-04-16T06:09:51Z

@blueorangutan ui

blueorangutan · 2024-04-16T06:11:03Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-04-16T06:26:25Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8919 (QA-JID-313)

DaanHoogland · 2024-04-16T06:37:11Z

It doesn't work in qa. maybe due to an older backend.

DaanHoogland · 2024-04-16T06:37:19Z

@blueorangutan package

blueorangutan · 2024-04-16T06:38:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-16T07:51:54Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9272

DaanHoogland · 2024-04-16T08:02:29Z

@blueorangutan test alma9 kvm-alma9 keepEnv

blueorangutan · 2024-04-16T08:04:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan · 2024-04-16T22:36:40Z

[SF] Trillian test result (tid-9846)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 50560 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8919-t9846-kvm-alma9.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	313.81	test_events_resource.py
test_01_events_resource	`Error`	313.82	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	97.86	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.67	test_network_permissions.py

DaanHoogland

tested ok, Note that during VM deployment the target user must already have a network to deploy the VM in or there will be no option to the admin to deploy

BryanMLima · 2024-04-19T14:17:49Z

tested ok, Note that during VM deployment the target user must already have a network to deploy the VM in or there will be no option to the admin to deploy

@DaanHoogland, thanks for testing. In the view of VM deploy, you can create a new network and specify the domain and account, therefore, there is no need to pre-create the network for the account.

@BryanMLima , have you also logged in as the other user to manipulate/delete the resources created? (nice feature btw)

Yes, I was able to manage the resources (VM and network) as expected.

KlausDornsbach · 2024-04-22T12:48:12Z

lgtm, also tested manipulating the VMs in the user end in both domain and project scopes and it is working fine.
Tested stopping, resuming, rebooting, scaling and deleting

weizhouapache

good improvement

code lgtm, not tested yet

DaanHoogland · 2024-04-23T07:00:21Z

@BryanMLima are you going to do more work or can we merge?

BryanMLima · 2024-04-23T13:52:26Z

@BryanMLima are you going to do more work or can we merge?

I added the component to the Isolated and L2 networks forms (shared networks already has the scope field, so I didn't want to change that). Now, root and domain admins can also create network to any account and project while deploying VMs (and when only creating networks, as it is the same component).

We just need another round of tests for this one.

BryanMLima · 2024-04-23T14:12:59Z

@DaanHoogland, I also removed the duplicate fields mentioned in #6442 (comment).

KlausDornsbach · 2024-04-23T16:47:38Z

Nice addition. Tested, it works fine for the cases aforementioned

DaanHoogland · 2024-04-24T06:54:45Z

@blueorangutan ui

blueorangutan · 2024-04-24T06:56:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-04-24T07:11:49Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8919 (QA-JID-318)

DaanHoogland · 2024-04-30T14:33:41Z

@blueorangutan ui

blueorangutan · 2024-04-30T14:35:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-04-30T14:50:26Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8919 (QA-JID-330)

DaanHoogland

tested ok, and clgtm

BryanMLima · 2024-05-22T14:15:54Z

@weizhouapache @KlausDornsbach, can you guys have a look at this PR with the latest change?

vladimirpetrov · 2024-06-10T08:41:54Z

@blueorangutan package

blueorangutan · 2024-06-10T08:44:04Z

@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-10T09:59:24Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9837

vladimirpetrov

LGTM based on manual testing. Tested VMs and all three network types with different accounts, projects and domains.

…eating networks (apache#8919)

boring-cyborgBot added the component:UI label Apr 15, 2024

DaanHoogland added the status:needs-testing label Apr 16, 2024

DaanHoogland approved these changes Apr 17, 2024
View reviewed changes

KlausDornsbach approved these changes Apr 22, 2024
View reviewed changes

weizhouapache approved these changes Apr 22, 2024
View reviewed changes

BryanMLima mentioned this pull request Apr 22, 2024
Possibility to choose the source NAT IP address on a isolated network or VPC #6442
Merged
12 tasks

BryanMLima changed the title ~~[UI] Add option to specify account/project while deploying VMs~~[UI] Add option to specify account/project while deploying VMs and creating networksApr 23, 2024

BryanMLima requested review from DaanHoogland, KlausDornsbach and weizhouapache April 23, 2024 13:52

DaanHoogland approved these changes May 1, 2024
View reviewed changes

BryanMLima added 6 commits May 7, 2024 11:18

Add ownership selection when deploying VMs
d33fb18

Add small fixes when changing owner
997760c

Present affinity groups for the selected account
93f76fd

Add ownership to isolated and L2 networks forms
3945144

Fix request failed for domains with no accounts
c3c8f13

Remove console log
6991793

BryanMLima force-pushed the add-ownership-selection branch from 9fcc187 to 6991793Compare May 7, 2024 14:18

vladimirpetrov self-assigned this Jun 10, 2024

vladimirpetrov approved these changes Jun 11, 2024
View reviewed changes

vladimirpetrov removed the status:needs-testing label Jun 12, 2024

DaanHoogland merged commit 3fe2b46 into apache:mainJun 12, 2024

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
[UI] Add option to specify account/project while deploying VMs and cr…
39416fa
…eating networks (apache#8919)

gp-santos mentioned this pull request Jun 17, 2024
[UI] Add option to select owner of volume when creating it #9265
Merged
8 tasks

weizhouapache mentioned this pull request Jul 5, 2024
UI: create network form constantly tries to list domains - which is not permitted for normal users #9348
Merged
14 tasks

sureshanaparti modified the milestones: 4.20.0.0, 4.19.1.0 Jul 8, 2024

weizhouapache mentioned this pull request Jul 9, 2024
UI: fix CreateIsolatedNetworkForm.vue #9359
Merged
14 tasks

This was referenced Aug 30, 2024
Repeated "Network domain" field in "Add Network" form #9603
Closed
Add Domain/Account Assignment at Instance Creation #9612
Closed

weizhouapache mentioned this pull request Dec 18, 2024
Creating VPC Network as admin there is no option to select Domain and Account #10121
Closed

Uh oh!

Conversation

BryanMLima commented Apr 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

BryanMLima commented Apr 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KlausDornsbach commented Apr 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Apr 23, 2024

Uh oh!

BryanMLima commented Apr 23, 2024

Uh oh!

BryanMLima commented Apr 23, 2024

Uh oh!

KlausDornsbach commented Apr 23, 2024

Uh oh!

DaanHoogland commented Apr 24, 2024

Uh oh!

blueorangutan commented Apr 24, 2024

Uh oh!

blueorangutan commented Apr 24, 2024

Uh oh!

DaanHoogland commented Apr 30, 2024

Uh oh!

blueorangutan commented Apr 30, 2024

Uh oh!

blueorangutan commented Apr 30, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

BryanMLima commented May 22, 2024

Uh oh!

vladimirpetrov commented Jun 10, 2024

Uh oh!

blueorangutan commented Jun 10, 2024

Uh oh!

blueorangutan commented Jun 10, 2024

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

BryanMLima commented Apr 15, 2024•
edited
Loading

BryanMLima commented Apr 19, 2024•
edited
Loading

KlausDornsbach commented Apr 22, 2024•
edited
Loading