Skip to content

UI: create network form constantly tries to list domains - which is not permitted for normal users - #9348

Merged
DaanHoogland merged 1 commit into
4.19from
fix-user-network-domains
Jul 8, 2024
Merged

UI: create network form constantly tries to list domains - which is not permitted for normal users#9348
DaanHoogland merged 1 commit into
4.19from
fix-user-network-domains

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR prevents listing domains for normal users

Before fix:
Screenshot from 2024-07-05 10-30-40

After fix:
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

this issue seems to be fixed by #8919 in main branch
but it still exist in 4.19

@codecov

codecovBot commented Jul 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.05%. Comparing base (ba85b4d) to head (8471283).

Additional details and impacted files
@@ Coverage Diff @@## 4.19 #9348 +/- ##
============================================
- Coverage 15.05% 15.05% -0.01% + Complexity 11139 11136 -3 
============================================
Files 5405 5405 Lines 472354 472355 +1 Branches 61210 60596 -614 ============================================
- Hits 71129 71119 -10 - Misses 393302 393316 +14 + Partials 7923 7920 -3 
FlagCoverage Δ
uitests4.27% <ø> (-0.01%)⬇️
unittests15.77% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yadvryadvr added this to the 4.19.1.0 milestone Jul 6, 2024
@DaanHoogland
DaanHoogland merged commit f35f3f6 into 4.19Jul 8, 2024
@DaanHoogland
DaanHoogland deleted the fix-user-network-domains branch July 8, 2024 06:28
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants

@Pearl1594@yadvr@weizhouapache@DaanHoogland