Skip to content

UI: fix CreateIsolatedNetworkForm.vue - #9359

Merged
yadvr merged 1 commit into
apache:mainfrom
weizhouapache:4.20-fix-CreateIsolatedNetworkForm.vue
Jul 9, 2024
Merged

UI: fix CreateIsolatedNetworkForm.vue#9359
yadvr merged 1 commit into
apache:mainfrom
weizhouapache:4.20-fix-CreateIsolatedNetworkForm.vue

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes the CreateIsolatedNetworkForm.vue in main/4.20 branch.

Due to PR #8919 , the PR #9348 should be ignored in main/4.20 branch.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapacheweizhouapache added this to the 4.20.0.0 milestone Jul 9, 2024
@codecov

codecovBot commented Jul 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.17%. Comparing base (0af8835) to head (dad8f11).

❗ There is a different number of reports uploaded between BASE (0af8835) and HEAD (dad8f11). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (0af8835)HEAD (dad8f11)
unittests10
Additional details and impacted files
@@ Coverage Diff @@## main #9359 +/- ##
============================================
- Coverage 15.53% 4.17% -11.37% 
============================================
Files 5492 371 -5121 Lines 480931 30420 -450511 Branches 61853 5390 -56463 ============================================
- Hits 74711 1269 -73442 + Misses 397959 29007 -368952 + Partials 8261 144 -8117 
FlagCoverage Δ
uitests4.17% <ø> (+<0.01%)⬆️
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@yadvr
yadvr merged commit 354627a into apache:mainJul 9, 2024
@DaanHoogland
DaanHoogland deleted the 4.20-fix-CreateIsolatedNetworkForm.vue branch July 9, 2024 08:17
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@weizhouapache@yadvr@DaanHoogland