Skip to content

Support "IS TRUE/FALSE" syntax (redo) - #3235

Merged
andygrove merged 1 commit into
apache:masterfrom
sarahyurick:is_true_false
Aug 24, 2022
Merged

Support "IS TRUE/FALSE" syntax (redo)#3235
andygrove merged 1 commit into
apache:masterfrom
sarahyurick:is_true_false

Conversation

@sarahyurick

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes#3159

What changes are included in this PR?

Redo of #3189 with the IsNotDistinctFrom operator instead, from @alamb's suggestion. Includes SQL-level tests as well.

Since IS TRUE and IS FALSE should only work on boolean and null datatypes, we are waiting on #3222 so that we can add type validation.

@github-actionsgithub-actionsBot added core Core DataFusion crate sql SQL Planner labels Aug 23, 2022

@andygroveandygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sarahyurick

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3235 (79759f1) into master (74872a3) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@ Coverage Diff @@## master #3235 +/- ##
==========================================
+ Coverage 85.81% 85.84% +0.02% 
==========================================
Files 292 293 +1 Lines 53117 53206 +89 ==========================================
+ Hits 45585 45675 +90 + Misses 7532 7531 -1 
Impacted FilesCoverage Δ
datafusion/expr/src/logical_plan/plan.rs78.90% <50.00%> (+0.89%)⬆️
datafusion/optimizer/tests/integration-test.rs84.00% <84.00%> (ø)
datafusion/core/tests/sql/expr.rs99.85% <100.00%> (+<0.01%)⬆️
datafusion/sql/src/planner.rs80.52% <100.00%> (+0.07%)⬆️
datafusion/core/src/physical_plan/metrics/value.rs86.93% <0.00%> (-0.51%)⬇️
datafusion/expr/src/window_frame.rs93.27% <0.00%> (+0.84%)⬆️
datafusion/expr/src/utils.rs91.10% <0.00%> (+1.07%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove
andygrove merged commit c11f303 into apache:masterAug 24, 2022
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = aa6a34b and contender = c11f303. c11f303 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratesqlSQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "IS TRUE/FALSE" syntax

4 participants

@sarahyurick@codecov-commenter@ursabot@andygrove